From: Dmitry Gutov <dmitry@gutov.dev>
To: Damien Cassou <damien@cassou.me>, 65704-done@debbugs.gnu.org
Subject: bug#65704: 29.1; Most code of `project-ignores' seems to be dead code
Date: Thu, 7 Sep 2023 00:16:42 +0300 [thread overview]
Message-ID: <76be9234-5196-a989-785b-558d4956eb48@gutov.dev> (raw)
In-Reply-To: <87bkefp138.fsf@cassou.me>
On 06/09/2023 22:12, Damien Cassou wrote:
> Dmitry Gutov<dmitry@gutov.dev> writes:
>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
>> index 29a81c7e151..2eea0ef72e0 100644
>> --- a/lisp/progmodes/project.el
>> +++ b/lisp/progmodes/project.el
>> @@ -566,6 +566,12 @@ project-try-vc
>> (project--submodule-p root))
>> (let* ((parent (file-name-directory (directory-file-name
>> root))))
>> (setq root (vc-call-backend 'Git 'root parent))))
>> + (when (not backend)
> it seems that `root' is sometimes nil at this point so I would change
> this line to
>
> (when (and (not backend) root)
>
> I've used this for the day and it seems to work fine.
Thanks for the extra testing.
I just moved the new code a little deeper down inside (when root ...)
block, should do the same. Pushed as 62229fb2d11 and bumped project.el
version to 0.10.0.
Should be out in ELPA shortly along with a few other new features added
recently.
This seems to resolve the last of the concerns here, so closing the bug
as well. Please clarify if something remains.
Addendum regarding the chosen solution: I guess there is a downside or
two: when working over Tramp, the latency will increase. And if the
subproject's dir is in the parent's .gitignore, the behavior will get worse.
Let's wait for feedback to see if those are real problems, but worst
case, the solution which you had used previously should take care at
least of the second usage scenario (ignoring the ignores).
next prev parent reply other threads:[~2023-09-06 21:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 16:03 bug#65704: 29.1; Most code of `project-ignores' seems to be dead code Damien Cassou
2023-09-02 16:17 ` bug#65704: [PATCH] project.el: Fix bug in project-ignores Damien Cassou
2023-09-03 0:26 ` bug#65704: 29.1; Most code of `project-ignores' seems to be dead code Dmitry Gutov
2023-09-04 16:03 ` Damien Cassou
2023-09-04 18:30 ` Dmitry Gutov
2023-09-04 20:11 ` Damien Cassou
2023-09-04 20:17 ` Dmitry Gutov
2023-09-05 7:58 ` Damien Cassou
2023-09-05 14:09 ` Dmitry Gutov
2023-09-05 20:22 ` Damien Cassou
2023-09-06 19:12 ` Damien Cassou
2023-09-06 21:16 ` Dmitry Gutov [this message]
2023-09-04 18:31 ` Dmitry Gutov
2023-09-04 18:48 ` Eli Zaretskii
2023-09-04 18:58 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76be9234-5196-a989-785b-558d4956eb48@gutov.dev \
--to=dmitry@gutov.dev \
--cc=65704-done@debbugs.gnu.org \
--cc=damien@cassou.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).