From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#66431: [PATCH] Fix reset treesit--explorer-last-node when explorer buffer was killed Date: Sat, 14 Oct 2023 10:08:41 -0700 Message-ID: <76FD5982-60CC-48D2-9823-C235CCEC2EEC@gmail.com> References: <83a5slsjmh.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39702"; mail-complaints-to="usenet@ciao.gmane.io" Cc: nvp , 66431@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 14 19:09:55 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qri9C-000A8m-Nw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Oct 2023 19:09:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qri8y-0007Rh-DP; Sat, 14 Oct 2023 13:09:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qri8w-0007RX-P8 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 13:09:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qri8w-0005IO-Ga for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 13:09:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qri9K-0002g1-5h for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2023 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66431 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66431-submit@debbugs.gnu.org id=B66431.169730336610231 (code B ref 66431); Sat, 14 Oct 2023 17:10:02 +0000 Original-Received: (at 66431) by debbugs.gnu.org; 14 Oct 2023 17:09:26 +0000 Original-Received: from localhost ([127.0.0.1]:50341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qri8k-0002ew-Di for submit@debbugs.gnu.org; Sat, 14 Oct 2023 13:09:26 -0400 Original-Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:45118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qri8g-0002eh-90 for 66431@debbugs.gnu.org; Sat, 14 Oct 2023 13:09:25 -0400 Original-Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-694ed847889so2554600b3a.2 for <66431@debbugs.gnu.org>; Sat, 14 Oct 2023 10:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697303333; x=1697908133; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RnOIvrosil521qqtCa9rmbowYTFH3IAvKZv3nfxq35E=; b=BUZu85r8BnjnoC4U/O1/PJ+a6FbfY0jlnDce9HUnXR3xIoiO1VUjJW02CX7f7EKpae gR1OiBI3GmSBY5q2aCWIBKGOfFBz7ThlrAzbGatqeTriv25mFXiu6g2qBwJ7uytfq5AK 8tvSDqykLK0Ih3EHdA+ws57iKu5UXCg35we6hbn6QTPrWHg/m/Fi6jKWsi6BCpRzo5Lb 3duj4vXvvqEZ67VXVmkEMsW60XR2QPwunQL4tUnr0SgFbE3wm03khLPeNbT0IR5rcMEv CstWLZXiJGjkvZz6k/1l7s0ZUNtJQfSXY9e1Os6vGyReHGpm+HVbaa/g8v+gfgTKA3tK iE8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697303333; x=1697908133; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RnOIvrosil521qqtCa9rmbowYTFH3IAvKZv3nfxq35E=; b=KYgHhl6vS+X1tNOBpLlUZKKGT7d658wARxV6vvZZESbcPq2Qw3+IWcAZ0UrXoI342G G27rLMu1HHwDT0D/rNp9aPu1qRDkH6tFOAAcJ25VJjcwPqol8hJ0yHuvOyEIgYIR4f6a 1wR5Z/9jnUtf39NXHUKxuy20B/kLw9r1ERAoBCbBsgeADUlm6g0DvePSavDl0RvvsFyd nS+rVhOPJAsGCdB5lRNSoH40EWmBrdpCDgb6ujraGL+5JFRAOaFn/ZnvK65PAw/xF19C QPmlTgHZoySMQQSoMxwKarbkc5aPiUU0P9X5Sv+GoELqgJHkLbOGZSYbzO4ayf+ScV+H DUWw== X-Gm-Message-State: AOJu0YxROanF6FhdzJ6Av8CGRztWkmNPO6tIQecNle2VheT9/REP8D5i dxTEaQVcPWPjNLkYf2lJblk= X-Google-Smtp-Source: AGHT+IEf6IxX/YM4GLys1HMJ89M3m2FOtev5yZ6OSut+e1TpUUJ9L6qxk5jMyQBdHiYbrBk7GyDk4A== X-Received: by 2002:a05:6a00:18a3:b0:6bc:c242:7915 with SMTP id x35-20020a056a0018a300b006bcc2427915mr1126938pfh.28.1697303332749; Sat, 14 Oct 2023 10:08:52 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id x24-20020aa79ad8000000b006b341144ad0sm2979319pfp.102.2023.10.14.10.08.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Oct 2023 10:08:52 -0700 (PDT) In-Reply-To: <83a5slsjmh.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272448 Archived-At: > On Oct 14, 2023, at 1:17 AM, Eli Zaretskii wrote: >=20 >> From: nvp >> Date: Mon, 9 Oct 2023 23:02:48 -0700 >>=20 >> Tags: patch >>=20 >> Bug: After `treesit-explorer-mode` is enabled in a buffer and its >> associated `treesit--explorer-buffer` is killed, a subsequent call >> to `treesit-explorer-mode` initially displays an empty explorer >> buffer b/c `treesit--explorer-refresh` sees old value for >> `treesit--explorer-last-node`. >>=20 >> * lisp/treesit.el (treesit-explorer-mode): reset >> `treesit--explorer-last-node` when `treesit--explorer-buffer` was = killed >>=20 >> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version >> 3.24.33, cairo version 1.16.0) of 2023-10-05 built on noah-X580VD >> Repository revision: 505c80623049d9e181918acdac8229c9a2041b1e >> Repository branch: master >> Windowing system distributor 'The X.Org Foundation', version = 11.0.12101004 >> System Description: Ubuntu 22.04.3 LTS >=20 > Yuan, could you please look into this? Is the patch OK to go in, and > if so, should it be installed on emacs-29? I=E2=80=99ll look at it, thanks for the reminder. Yuan