From: Jim Porter <jporterbugs@gmail.com>
To: Gregory Heytings <gregory@heytings.org>, Eli Zaretskii <eliz@gnu.org>
Cc: arstoffel@gmail.com, Stefan Monnier <monnier@iro.umontreal.ca>,
59956@debbugs.gnu.org
Subject: bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation
Date: Thu, 15 Dec 2022 22:09:10 -0800 [thread overview]
Message-ID: <765547c0-b2a5-b054-a29d-b27002b7442c@gmail.com> (raw)
In-Reply-To: <ec23ed3e9582f6be3f7e@heytings.org>
On 12/12/2022 2:21 PM, Gregory Heytings wrote:
> I'm still not Stefan, but this bug is fixed by the attached patch.
Thanks. This is pretty close to what I was thinking (I tried almost the
exact same patch locally, but wasn't sure if there was a better way).
Personally, I think something like your patch would probably be the
safest bet for the 29 branch.
Still, like Stefan and Augusto mentioned, there's probably a larger
issue here: should Eshell be allowed to feed Pcomplete non-strings?
Since Pcomplete was written for Eshell initially, there's some basis for
why it *might* support non-string values, but actually requiring that is
an awful lot to ask of every programmer who ever wants to write a
pcomplete function.
next prev parent reply other threads:[~2022-12-16 6:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 1:25 bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation Jim Porter
2022-12-11 7:44 ` Eli Zaretskii
2022-12-11 8:56 ` Augusto Stoffel
2022-12-11 15:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-12 22:21 ` Gregory Heytings
2022-12-12 22:37 ` Augusto Stoffel
2022-12-12 23:27 ` Gregory Heytings
2022-12-16 11:20 ` Augusto Stoffel
2022-12-16 6:09 ` Jim Porter [this message]
2022-12-16 14:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-16 14:28 ` Gregory Heytings
2022-12-19 0:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-19 1:19 ` Gregory Heytings
2022-12-19 2:15 ` Jim Porter
2022-12-19 3:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-19 15:00 ` Gregory Heytings
2022-12-19 16:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-19 22:22 ` Gregory Heytings
2022-12-21 6:32 ` Jim Porter
2022-12-21 9:28 ` Gregory Heytings
2022-12-29 22:02 ` Gregory Heytings
2022-12-19 10:31 ` Augusto Stoffel
2022-12-19 16:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-19 18:04 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=765547c0-b2a5-b054-a29d-b27002b7442c@gmail.com \
--to=jporterbugs@gmail.com \
--cc=59956@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).