From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: tsuucat via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#40600: [PATCH] 27.0.90; M-x strokes-list-strokes error Date: Wed, 15 Apr 2020 02:15:02 +0900 Message-ID: <763AC822-39EF-4BC2-85C2-8A473EC6CD8E@icloud.com> References: <8C7B4C5F-294E-4844-AAAF-C37101BE95F4@icloud.com> <851roqypvs.fsf@gmail.com> Reply-To: tsuucat Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_9036F527-3D3D-4412-933A-44B7D507DDF8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="73663"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40600@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 14 19:38:36 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOPW7-000J5l-Vc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Apr 2020 19:38:35 +0200 Original-Received: from localhost ([::1]:36540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOPW6-0003HN-T7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Apr 2020 13:38:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47152) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOPAJ-0002Vf-QO for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2020 13:16:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOPAI-0006ka-UX for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2020 13:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51380) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOPAI-0006kG-PX for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2020 13:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOPAH-0006SS-KS for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2020 13:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: tsuucat Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Apr 2020 17:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40600 X-GNU-PR-Package: emacs Original-Received: via spool by 40600-submit@debbugs.gnu.org id=B40600.158688451324766 (code B ref 40600); Tue, 14 Apr 2020 17:16:01 +0000 Original-Received: (at 40600) by debbugs.gnu.org; 14 Apr 2020 17:15:13 +0000 Original-Received: from localhost ([127.0.0.1]:34693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOP9V-0006RO-8o for submit@debbugs.gnu.org; Tue, 14 Apr 2020 13:15:13 -0400 Original-Received: from pv50p00im-ztdg10022001.me.com ([17.58.6.58]:60005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOP9S-0006R3-ST for 40600@debbugs.gnu.org; Tue, 14 Apr 2020 13:15:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1586884505; bh=Pc8BzvuWxh5a0tNI0Aobyy+oiPXdKngrpTT4+4jPl/4=; h=From:Message-Id:Content-Type:Subject:Date:To; b=TkXL/+Fjcu/zx9aUrXDI2CibyT5AqGP02PQHV6mhgJc6LKf3B889zbF7naJnUWj+o H4xdAGXQH56wFA0RJY2Wc1fYfi6SXXDtZYUpCGUzfImqk6D6K9ZvSy0EF0qKYyPNcD kvnzFk4R29xxtuZQD/h6U6l8N1RnX76MnU3mHOweo7v6e4DG4Xk3P37bPA4TldBk1W AZWsKAoljxDm44ax7DHOpPcCvxUQqZTFTF7JVaVU0IZ5gCWRyelnTYY3K02BUIJosz lIo763SN7VpnGAygafPzIfceX6AzNCDcml38Rg1oRezhiaB7BWYFuJw9UbUyyg91V6 C/+NBNSssny5g== Original-Received: from [192.168.129.26] (i114-183-98-221.s41.a008.ap.plala.or.jp [114.183.98.221]) by pv50p00im-ztdg10022001.me.com (Postfix) with ESMTPSA id B1BC2A0826; Tue, 14 Apr 2020 17:15:04 +0000 (UTC) In-Reply-To: <851roqypvs.fsf@gmail.com> X-Mailer: Apple Mail (2.3445.104.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-14_08:2020-04-14, 2020-04-14 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=808 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2002250000 definitions=main-2004140131 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178370 Archived-At: --Apple-Mail=_9036F527-3D3D-4412-933A-44B7D507DDF8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Why use prin1-to-string? That=E2=80=99s simply because I imitate the code in strokes-list-strokes = function. > Actually, since string-lessp accepts symbols, an easier fix would be = to > just drop the calls to symbol-name. Thanks for the advice! I made another patch and checked this works = well. -- tsuucat --Apple-Mail=_9036F527-3D3D-4412-933A-44B7D507DDF8 Content-Disposition: attachment; filename=0001-Fix-comparing-command-names-in-strokes.el-bug-40600.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-comparing-command-names-in-strokes.el-bug-40600.patch" Content-Transfer-Encoding: quoted-printable =46rom=20af31735e07528973392cb1e163f9f9e1682951e4=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Masahiro=20Nakamura=20=0A= Date:=20Tue,=2014=20Apr=202020=2022:37:17=20+0900=0ASubject:=20[PATCH]=20= Fix=20comparing=20command=20names=20in=20strokes.el=20(bug#40600)=0A=0A*=20= lisp/strokes.el=20(strokes-alphabetic-lessp):=20Simply=20call=20= string-lessp=0Abecause=20the=20cdr=20of=20the=20argument=20may=20be=20= string.=0A---=0A=20lisp/strokes.el=20|=204=20+---=0A=201=20file=20= changed,=201=20insertion(+),=203=20deletions(-)=0A=0Adiff=20--git=20= a/lisp/strokes.el=20b/lisp/strokes.el=0Aindex=207a887445..e511a63f=20= 100644=0A---=20a/lisp/strokes.el=0A+++=20b/lisp/strokes.el=0A@@=20= -1373,9=20+1373,7=20@@=20strokes-list-strokes=0A=20=0A=20(defun=20= strokes-alphabetic-lessp=20(stroke1=20stroke2)=0A=20=20=20"Return=20t=20= if=20STROKE1's=20command=20name=20precedes=20STROKE2's=20in=20= lexicographic=20order."=0A-=20=20(let=20((command-name-1=20(symbol-name=20= (cdr=20stroke1)))=0A-=09(command-name-2=20(symbol-name=20(cdr=20= stroke2))))=0A-=20=20=20=20(string-lessp=20command-name-1=20= command-name-2)))=0A+=20=20(string-lessp=20(cdr=20stroke1)=20(cdr=20= stroke2)))=0A=20=0A=20(defvar=20strokes-mode-map=0A=20=20=20(let=20((map=20= (make-sparse-keymap)))=0A--=20=0A2.21.0=0A=0A= --Apple-Mail=_9036F527-3D3D-4412-933A-44B7D507DDF8--