From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56393: Actually fix the long lines display bug Date: Wed, 06 Jul 2022 13:45:27 +0000 Message-ID: <762d224809b600ab6df5@heytings.org> References: <38c1a31040d2d2bc47ae@heytings.org> <38c1a310405bd4bbe370@heytings.org> <87a69n98yy.fsf@yahoo.com> <38c1a31040f5546dbd3a@heytings.org> <83a69n90t8.fsf@gnu.org> <38c1a31040ad21b41adc@heytings.org> <835ykb8x3z.fsf@gnu.org> <38c1a310403dbabc7270@heytings.org> <834jzv8sv4.fsf@gnu.org> <38c1a31040ba2976eb4d@heytings.org> <83y1x77c2w.fsf@gnu.org> <38c1a31040a5b59ba27f@heytings.org> <877d4qlboc.fsf@gnus.org> <01d4369f802989ba53ac3a9f4a522589@webmail.orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25211"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= , Lars Ingebrigtsen , Eli Zaretskii , 56393@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 15:46:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o95ME-0006Kg-Nj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 15:46:22 +0200 Original-Received: from localhost ([::1]:55166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o95MD-0008KS-7Q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 09:46:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o95Lw-0008KE-PJ for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:46:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o95Lu-0002FK-Ev for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:46:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o95Lu-0004bc-8S for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56393 X-GNU-PR-Package: emacs Original-Received: via spool by 56393-submit@debbugs.gnu.org id=B56393.165711513217657 (code B ref 56393); Wed, 06 Jul 2022 13:46:02 +0000 Original-Received: (at 56393) by debbugs.gnu.org; 6 Jul 2022 13:45:32 +0000 Original-Received: from localhost ([127.0.0.1]:52881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o95LQ-0004ai-L1 for submit@debbugs.gnu.org; Wed, 06 Jul 2022 09:45:32 -0400 Original-Received: from heytings.org ([95.142.160.155]:55140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o95LN-0004aX-QK for 56393@debbugs.gnu.org; Wed, 06 Jul 2022 09:45:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1657115128; bh=Rha2UZi5FViNhFMQKFIyMR5pO/QUgN++C5YZSbxPALs=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=VHvN9RHSaBu/DevYUnreUxvK/wY6A3NLxJVNxMsQX8/igmsykaFytbWmBfMSGdrGu g8e6zhXqj7yvvVf7p4Be9OObHxlGkLm1DufungANsrMBzvTp1LIXGYj0m4qrkmHfFe 7QGf9t4UwTbFAXi1AOfRQ7vQ10oCPfY3VaFrwpCr3OhZOt3wicwzzI4gLDzG+Pnket V9IbIlZHlIjVPg3rNnld0DxnlxIfRIojndf0MqedHGtJGz5LjCK8ZHS24C7JvOHBL9 k2gJeXOTl1AC2wdwyCexeGk4N1vmLZeY4MCzjLnfJC4y5AzdGUV3GRGRB+cxkZHyuV ONM55gYHIYFjA== In-Reply-To: <01d4369f802989ba53ac3a9f4a522589@webmail.orcon.net.nz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236245 Archived-At: Hi Phil, Thanks for your detailed feedback. > > I can cause it to glitch by visiting a large file and leaning on the > page down key. After a little while it fails to widen, and I'm left in > some narrowed portion of the buffer until I use a command which > re-triggers it. > That probably means you have a very big frame, you should set auto-narrow-display-length to a larger value than its default one (30000). > > I see an explicit list of supported commands in the code though, and I > worry about that. Surely(?) we can't insist that all commands (if not > functions generally?) which need to deal with the full buffer (including > all the custom code out there in users' configs) should be updated to > make them explicitly aware of this new mode? That doesn't seem > maintainable to me, and I can only imagine it causing lots of problems. > This new mode isn't necessary for ordinary files, so it will be activated only rarely. That already means that it cannot cause "lots of problems". I think it's okay if it "breaks" a few commands, especially if the fix is only to add these commands to a list or to put a property on them. > > So-long is conservative in when it triggers by comparison, partly to be > confident of not causing unwanted issues, and partly by necessity > because its default action (a major mode) is very disruptive. > I see, so-long restricts its action to so-long-target-modes, is that correct? I'm not sure such a restriction is necessary for auto-narrow-mode, it does not change anything apart from turning font-lock-mode off (by default) and narrowing the buffer.