From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2 Date: Fri, 20 Jul 2018 07:37:18 -0700 Organization: UCLA Computer Science Department Message-ID: <760fc9a2-26b9-a322-f8d0-c32cb9e6d8bf@cs.ucla.edu> References: <031d18cf-e661-6dea-8882-38d75924d0d4@cornell.edu> <83601c4m37.fsf@gnu.org> <83in5b2w1q.fsf@gnu.org> <83d0vj2tu2.fsf@gnu.org> <6642c8ac-55ff-ca2b-0141-a26b69d082ad@cs.ucla.edu> <83y3e61jl2.fsf@gnu.org> <83601a0z66.fsf@gnu.org> <8a6d43f0-02b2-87a4-4a2a-1abb76cbd577@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1532097366 29602 195.159.176.226 (20 Jul 2018 14:36:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Jul 2018 14:36:06 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: p.stephani2@gmail.com, 32189@debbugs.gnu.org To: Ken Brown , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 20 16:36:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgWVl-0007ax-Th for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jul 2018 16:36:02 +0200 Original-Received: from localhost ([::1]:48447 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgWXs-000502-U9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jul 2018 10:38:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgWXl-0004zm-PK for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 10:38:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgWXi-0006Ks-LH for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 10:38:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fgWXi-0006Km-HB for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 10:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fgWXi-0003v2-2S for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 10:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jul 2018 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32189-submit@debbugs.gnu.org id=B32189.153209744915021 (code B ref 32189); Fri, 20 Jul 2018 14:38:02 +0000 Original-Received: (at 32189) by debbugs.gnu.org; 20 Jul 2018 14:37:29 +0000 Original-Received: from localhost ([127.0.0.1]:49846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgWXA-0003uD-U1 for submit@debbugs.gnu.org; Fri, 20 Jul 2018 10:37:29 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgWX9-0003ty-5g for 32189@debbugs.gnu.org; Fri, 20 Jul 2018 10:37:27 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5AA56160747; Fri, 20 Jul 2018 07:37:21 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 5nO4mfaiPiEP; Fri, 20 Jul 2018 07:37:20 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9980F1606CC; Fri, 20 Jul 2018 07:37:20 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xKXZoTVpIvah; Fri, 20 Jul 2018 07:37:20 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 26DFA160656; Fri, 20 Jul 2018 07:37:20 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <8a6d43f0-02b2-87a4-4a2a-1abb76cbd577@cornell.edu> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148733 Archived-At: Ken Brown wrote: > Amended patch attached. Thanks for checking it. I installed it in master. Eli Zaretskii wrote: > GCC 7 is not exactly "old". True. > If you are saying > that this switch does a better job in later versions of GCC, Yes, it does in some cases. I don't know whether it does in this particul= ar=20 case. Someone would have to check. But I wouldn't bother checking since w= e have=20 a better fix now anyway (which is often the case for this particular warn= ing). > maybe we should disable it for GCC 7 alone? I'd rather not bother. Better to move on. The general rule for warnings s= hould=20 be to cater to the latest GCC, and not worry much about older ones. (I us= ed to=20 try doing things the other way and it was way more trouble than it was wo= rth.)=20 We need to cater to old compilers for correctness, but we don't need to d= o it=20 for warnings.