unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Ken Brown <kbrown@cornell.edu>, Eli Zaretskii <eliz@gnu.org>
Cc: p.stephani2@gmail.com, 32189@debbugs.gnu.org
Subject: bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2
Date: Fri, 20 Jul 2018 07:37:18 -0700	[thread overview]
Message-ID: <760fc9a2-26b9-a322-f8d0-c32cb9e6d8bf@cs.ucla.edu> (raw)
In-Reply-To: <8a6d43f0-02b2-87a4-4a2a-1abb76cbd577@cornell.edu>

Ken Brown wrote:
> Amended patch attached.

Thanks for checking it. I installed it in master.

Eli Zaretskii wrote:

 > GCC 7 is not exactly "old".

True.

 > If you are saying
 > that this switch does a better job in later versions of GCC,

Yes, it does in some cases. I don't know whether it does in this particular 
case. Someone would have to check. But I wouldn't bother checking since we have 
a better fix now anyway (which is often the case for this particular warning).

 > maybe we should disable it for GCC 7 alone?

I'd rather not bother. Better to move on. The general rule for warnings should 
be to cater to the latest GCC, and not worry much about older ones. (I used to 
try doing things the other way and it was way more trouble than it was worth.) 
We need to cater to old compilers for correctness, but we don't need to do it 
for warnings.





  reply	other threads:[~2018-07-20 14:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 19:26 bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2 Ken Brown
2018-07-18 15:09 ` Eli Zaretskii
2018-07-18 19:42   ` Ken Brown
2018-07-19  2:38     ` Eli Zaretskii
2018-07-19  6:10     ` Philipp Stephani
2018-07-19 12:49       ` Ken Brown
2018-07-19 13:25       ` Eli Zaretskii
2018-07-19  6:21   ` Philipp Stephani
2018-07-19 13:29     ` Eli Zaretskii
2018-07-19 13:56       ` Ken Brown
2018-07-19 14:17         ` Eli Zaretskii
2018-07-19 23:19           ` Paul Eggert
2018-07-20  6:56             ` Eli Zaretskii
2018-07-20 13:49               ` Ken Brown
2018-07-20 14:17                 ` Eli Zaretskii
2018-07-20 14:27                   ` Ken Brown
2018-07-20 14:37                     ` Paul Eggert [this message]
2018-07-20 14:51                       ` Eli Zaretskii
2018-07-20 19:34                       ` Ken Brown
2018-07-20 21:03                         ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=760fc9a2-26b9-a322-f8d0-c32cb9e6d8bf@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=32189@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=kbrown@cornell.edu \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).