From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#50387: Possible bug in Tramp or in completions Date: Mon, 06 Sep 2021 20:55:15 +0000 Message-ID: <75d560562c15a7c4aab4@heytings.org> References: <79cd87e590549c0d916d@heytings.org> <79cd87e590b404a83d08@heytings.org> <8735qi3yn0.fsf@gmx.de> <75d560562c0ab9fd3910@heytings.org> <87r1e1ej2y.fsf@gmx.de> <75d560562c20d8f71e17@heytings.org> <87h7exeh56.fsf@gmx.de> <75d560562c1f93d6a0f7@heytings.org> <877dftebod.fsf@gmx.de> <75d560562c385dda28c0@heytings.org> <87y289cuos.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="zvQHgJyZHr" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9244"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , 50387@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 06 22:56:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNLf0-0002Ep-GW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Sep 2021 22:56:10 +0200 Original-Received: from localhost ([::1]:54128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNLey-0000xX-Qb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Sep 2021 16:56:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNLes-0000xP-2A for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 16:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43050) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNLer-00007D-QU for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 16:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNLer-0006sg-Mz for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 16:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Sep 2021 20:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50387 X-GNU-PR-Package: emacs Original-Received: via spool by 50387-submit@debbugs.gnu.org id=B50387.163096171926399 (code B ref 50387); Mon, 06 Sep 2021 20:56:01 +0000 Original-Received: (at 50387) by debbugs.gnu.org; 6 Sep 2021 20:55:19 +0000 Original-Received: from localhost ([127.0.0.1]:54596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNLeB-0006rj-0e for submit@debbugs.gnu.org; Mon, 06 Sep 2021 16:55:19 -0400 Original-Received: from heytings.org ([95.142.160.155]:49700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNLe8-0006ra-MF for 50387@debbugs.gnu.org; Mon, 06 Sep 2021 16:55:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1630961715; bh=kjlqqmDbKA0fC6qOzqZd60Vgn3K/9uoS5dwKKnM+Dts=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=TbSjzcC1R4VjoCb20KS3i8B/NJppDQI8pbFUkp/Cl1e+tILMNXYtAbP3DOBfgv2Dn CDh0UVe9l+Jah+BfsVj9b9Tc8Vjwn+MssoEwRpbywDpQY5SruQmQQpYDJs59phO/3C nxOSRuUgclqDUUoQr8he13SHoNxSDXOaAfhKdzrBdLQ/Sr7SdX5QZRjozMlZawp9Ao QCV5G1aVjSIY7ET6+PLrVcvV7X4So+AYZeuNZZdikMSWrQN+91QNvQSFWbDP7MRaHc zFMzucaa+gd+10ow0ACARsWzS7ndPM1uj40/Ig/Wz8phoT/EFm1LT8PvEc2grsN7Ke /dRwrWWPkXrPQ== In-Reply-To: <87y289cuos.fsf@gmx.de> Content-ID: <75d560562c06caad5339@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213639 Archived-At: --zvQHgJyZHr Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-ID: <75d560562cd964c3739d@heytings.org> Hi Michael, >> * lisp/net/tramp.el (tramp-completion-handle-file-name-all-completions): >> Do not return methods when the filename already contains a complete meth= od. >> Fixes bug#50387. > > I don't see this implemented. You rather don't return methods when the=20 > filename does not contain a possible method string at all. > Yet this is what is happening. You can try it yourself: emacs -Q, M-:=20 (require 'tramp), M-: (add-to-list 'completion-styles 'substring), C-x C-f= =20 /scp: TAB. This will display "Sole completion", and it displays "Sole=20 completion" because "scp:" and "scpx:" are added in the completion=20 candiates in tramp-completion-handle-file-name-all-completions. You can=20 see this with (message "method '%s' result '%s'" method (tramp-get-completion-methods m)) around "Possible methods". With C-x C-f /scp TAB, you will see method =E2=80=99scp=E2=80=99 result =E2=80=99(nil nil nil nil nil nil nil n= il nil nil nil nil nil=20 nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil /scpx: /scp:=20 nil nil nil nil nil)=E2=80=99 which is correct, but with C-x C-f /scp: TAB, you will see method =E2=80=99=E2=80=99 result =E2=80=99(nil nil nil nil nil nil nil nil = nil nil nil nil nil nil=20 nil nil nil nil nil nil nil nil nil nil nil nil nil nil /scpx: /scp: nil=20 nil nil nil nil)=E2=80=99 which is wrong. >> =09 ;; Possible methods. >> -=09 (setq result >> -=09=09 (append result (tramp-get-completion-methods m))))))) >> +=09 (unless (or (string-empty-p method) >> +=09=09 (string-empty-p user) >> +=09=09 (string-empty-p host)) > > The check for (string-empty-p user) and (string-empty-p host) wouldn't=20 > be needed, you are in the else branch of (or user host). IOW, user and=20 > host are already nil, nothing left to test for them. > Whoops, yes, indeed. Updated patch attached. --zvQHgJyZHr Content-Type: text/x-diff; name=Improve-handling-of-non-default-completion-styles-wi.patch Content-Transfer-Encoding: base64 Content-ID: <75d560562c08a66e09b1@heytings.org> Content-Description: Content-Disposition: attachment; filename=Improve-handling-of-non-default-completion-styles-wi.patch RnJvbSA1ZjRiODIxYmJmNTEyMzQyMmQ0Mzg5NWJlZTRjODQ3Y2ZhZGYzMWIw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBNb24sIDYgU2Vw IDIwMjEgMjA6NTI6MjEgKzAwMDANClN1YmplY3Q6IFtQQVRDSF0gSW1wcm92 ZSBoYW5kbGluZyBvZiBub24tZGVmYXVsdCBjb21wbGV0aW9uIHN0eWxlcyB3 aXRoIFRyYW1wDQogbWV0aG9kcw0KDQoqIGxpc3AvbmV0L3RyYW1wLmVsICh0 cmFtcC1jb21wbGV0aW9uLWhhbmRsZS1maWxlLW5hbWUtYWxsLWNvbXBsZXRp b25zKToNCkRvIG5vdCByZXR1cm4gbWV0aG9kcyB3aGVuIHRoZSBmaWxlbmFt ZSBhbHJlYWR5IGNvbnRhaW5zIGEgY29tcGxldGUgbWV0aG9kLg0KRml4ZXMg YnVnIzUwMzg3Lg0KLS0tDQogbGlzcC9uZXQvdHJhbXAuZWwgfCA1ICsrKy0t DQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkNCg0KZGlmZiAtLWdpdCBhL2xpc3AvbmV0L3RyYW1wLmVsIGIvbGlz cC9uZXQvdHJhbXAuZWwNCmluZGV4IDRmZDdhMzIyZDQuLjI1OWZjMWZjZmMg MTAwNjQ0DQotLS0gYS9saXNwL25ldC90cmFtcC5lbA0KKysrIGIvbGlzcC9u ZXQvdHJhbXAuZWwNCkBAIC0yODM5LDggKzI4MzksOSBAQCB0cmFtcC1jb21w bGV0aW9uLWhhbmRsZS1maWxlLW5hbWUtYWxsLWNvbXBsZXRpb25zDQogCQkJ ICAgICAgIChkZWxxIG5pbCBhbGwtdXNlci1ob3N0cykpKSkpDQogDQogCSAg ICA7OyBQb3NzaWJsZSBtZXRob2RzLg0KLQkgICAgKHNldHEgcmVzdWx0DQot CQkgIChhcHBlbmQgcmVzdWx0ICh0cmFtcC1nZXQtY29tcGxldGlvbi1tZXRo b2RzIG0pKSkpKSkpDQorCSAgICAodW5sZXNzIChzdHJpbmctZW1wdHktcCBt ZXRob2QpDQorCSAgICAgIChzZXRxIHJlc3VsdA0KKwkJICAgIChhcHBlbmQg cmVzdWx0ICh0cmFtcC1nZXQtY29tcGxldGlvbi1tZXRob2RzIG0pKSkpKSkp KQ0KIA0KICAgICA7OyBVbmlmeSBsaXN0LCBhZGQgaG9wLCByZW1vdmUgbmls IGVsZW1lbnRzLg0KICAgICAoZG9saXN0IChlbHQgcmVzdWx0KQ0KLS0gDQoy LjMzLjANCg0K --zvQHgJyZHr--