From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#54698: non-recursive GC marking [PATCH] Date: Tue, 5 Apr 2022 13:11:44 +0200 Message-ID: <75F6D65B-9CA1-4ECF-97BD-B934A84EB2CA@acm.org> References: <5A577100-75CE-4C9E-A7DA-02B917662AF5@acm.org> <8735itglid.fsf@gnus.org> <8527E407-8190-4574-B8D5-BE68220AE663@acm.org> <871qyc5o0y.fsf@yahoo.com> <5BBEDBDA-4C85-4237-9EF7-5635A4950365@acm.org> <87czhv53gd.fsf@yahoo.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4335"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 54698@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 05 13:12:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbh6n-0000wu-1u for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Apr 2022 13:12:25 +0200 Original-Received: from localhost ([::1]:46502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbh6m-0005pm-4y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Apr 2022 07:12:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbh6Q-0005ml-OR for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 07:12:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59952) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbh6Q-0007BA-DC for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 07:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbh6Q-0006xA-34 for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 07:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Apr 2022 11:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54698-submit@debbugs.gnu.org id=B54698.164915711226710 (code B ref 54698); Tue, 05 Apr 2022 11:12:02 +0000 Original-Received: (at 54698) by debbugs.gnu.org; 5 Apr 2022 11:11:52 +0000 Original-Received: from localhost ([127.0.0.1]:53849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbh6F-0006wj-Px for submit@debbugs.gnu.org; Tue, 05 Apr 2022 07:11:52 -0400 Original-Received: from mail153c50.megamailservers.eu ([91.136.10.163]:35474 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbh6D-0006wa-Cg for 54698@debbugs.gnu.org; Tue, 05 Apr 2022 07:11:50 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1649157107; bh=rV7MNZaozTh/fIkWgnEHFHEXHMCFXErKRewpFdNVRuo=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=EcKbu3AyeWLebvpIsgDY9CyTFBsyUDeCtyG4L8Z7M6Q7NuiVgyp2rrmlHYYELf23v VNnZJvGTcqpsg0D0o1KZflIaFtOVDo3cDX3zHgDZO1l7z8H58sPZuNyxNqA1glnWXA vJKiefmIg9pL6PP6j2gSfc8aygZijWDMToIKByww= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 235BBjMV002596; Tue, 5 Apr 2022 11:11:46 +0000 In-Reply-To: <87czhv53gd.fsf@yahoo.com> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F19.624C23F3.003D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229435 Archived-At: 5 apr. 2022 kl. 10.39 skrev Po Lu : > I think a failed xmalloc will also make Emacs prompt to "C-x s, then > exit". Yes, you're probably right. (Never seen it happen myself.) > That code wasn't tested in an actual out-of-memory situation yet (it's > too soon to consider this), but hopefully it will work. I think it > works when running out of memory in general, because otherwise it > wouldn't be what memory_full eventually asks the user to do. Out-of-memory handling is difficult to do correctly and to test, = especially on modern systems. You are right to make a reasonable effort = at dealing with it but don't go overboard -- at some point effort is = better spent on limiting user data loss in other ways (robust auto-save = in particular). > There's a lot of other > low hanging fruit for optimization as well, but it's too early to work > on those, since at present the garbage collector is not even working = due > to the recent changes that added a manually managed stack to the > bytecode interpreter. Very sorry about that (but Progress stops for nobody)! In fact the new bytecode stack should provide more opportunities for = efficient GC, but let's discuss that elsewhere. > Thanks. You're welcome.