From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#48228: json-serialize should signal error when dll is not found [MS Windows] Date: Thu, 6 May 2021 01:36:06 +0300 Message-ID: <75507c21-1910-5f4d-76d7-63fc3c0dc2a9@yandex.ru> References: <83o8dq4h2s.fsf@gnu.org> <3b2dba36-1714-6c19-556b-6cfe52fdb222@yandex.ru> <87fsz28n5x.fsf@gmail.com> <83eeem4cqt.fsf@gnu.org> <463fc132-792a-4e4d-9a04-ec6c78549b21@yandex.ru> <83bl9q4bkz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1183"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: rpluim@gmail.com, p.stephani2@gmail.com, 48228@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 00:37:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leQ8k-0000Ba-Ng for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 00:37:10 +0200 Original-Received: from localhost ([::1]:41850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leQ8j-0002lw-8q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 18:37:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leQ8c-0002lp-Qd for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 18:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leQ8c-000545-Ic for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 18:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leQ8c-0005Ru-GQ for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 18:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 22:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48228 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48228-submit@debbugs.gnu.org id=B48228.162025417920915 (code B ref 48228); Wed, 05 May 2021 22:37:02 +0000 Original-Received: (at 48228) by debbugs.gnu.org; 5 May 2021 22:36:19 +0000 Original-Received: from localhost ([127.0.0.1]:34955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leQ7v-0005RH-K3 for submit@debbugs.gnu.org; Wed, 05 May 2021 18:36:19 -0400 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:37479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leQ7r-0005RB-U9 for 48228@debbugs.gnu.org; Wed, 05 May 2021 18:36:17 -0400 Original-Received: by mail-ed1-f45.google.com with SMTP id y26so3870530eds.4 for <48228@debbugs.gnu.org>; Wed, 05 May 2021 15:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jf+lqSzEDOE14fyAMAkesbQFvlYLGBsVjcfkZm+7+5w=; b=m3Y+8SntWTaCjf5C6BpGjMaZw92t7jIlQJDbnjFW3WRGYd/XDmfFFLPY6LQ5uY1Bd8 GFYN4c/jR5ksabdulofDNqO3HJypHIUF/nlxT8dcrMwRWnzFncxHeI9cresnW4178VNb tmKyuog2Tf6yqqlfH0If9CkpIq/wQRj7TKytafA8ugCHS6wo9e7p6fR4m0iTGElZg21H RblTV13/m/6qEROmhXyhkSfO3a3C1pv4MBoaKlw2/8kNz2uRwzH6xgvbgnYxs4TobAcv RGmrOMW+wY7OuNQsF90/6hoOfJlaUQTh7egsYJGm3TSKE1H1kR94WOyTkTcYkTBBXgeT 1zRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jf+lqSzEDOE14fyAMAkesbQFvlYLGBsVjcfkZm+7+5w=; b=GMk5qsckIDPDllccD6+rvHe7I7Tz54+IXy13usFmkyE/mJrYvhX7oLQv/acJ2Hk06f qJD6bFLoytrie61lLdy2iG3xNcgxhg9ZBIwB67hCtjK8Wek3hwzpeej+nB7PTKnG6vKn Vt3iN7jFqXJlrVVf6UN172DV4pK1FproldB06MYA0p6qPJs/RebPU0JSF+Ygrwre8ojO tjTyfiRMRHgu2i2zAcnzHPxflVBwhpSoVvl0CwEmX0RoegteIOkUEsEFi5o85f5mNaSx eQqRXwp01Tqj4o64cqXKXPoDyd0YqW4WQCxCD+sMvhg94Pk4uIcAIK6PoANmt+rrOx1a m4tg== X-Gm-Message-State: AOAM530LZ5J7bVnTINFRsY1McFgNq1lu/P2+5L1XQZdXfu5hDCaXDT+b +l0M0B3zfUyBhyM2Wt79egLAUTZ1Odg= X-Google-Smtp-Source: ABdhPJzJG9cubTCp/d1zxEVgE3hF///FDPwEXshknYQkP2M0PpBKOwPwCHkYPVEwEsf3PbP5l4aflQ== X-Received: by 2002:a05:6402:17:: with SMTP id d23mr1372779edu.63.1620254169925; Wed, 05 May 2021 15:36:09 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u24sm241627edt.85.2021.05.05.15.36.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 May 2021 15:36:08 -0700 (PDT) In-Reply-To: <83bl9q4bkz.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205743 Archived-At: On 04.05.2021 21:07, Eli Zaretskii wrote: >> Cc: rpluim@gmail.com, p.stephani2@gmail.com, 48228@debbugs.gnu.org >> From: Dmitry Gutov >> Date: Tue, 4 May 2021 20:47:26 +0300 >> >> On 04.05.2021 20:42, Eli Zaretskii wrote: >>> How is that different from similar code that relies on, say, librsvg >>> to display SVG images? >> >> Does it have a Lisp entry point? If so, I suppose it should be fixed too. > > We have create-image, which currently explicitly checks for the > relevant library to be available to Emacs. > >> My main experience with librsvg is creating image specs manually and >> having them used via the 'display' text property. There is no obvious >> place to signal an error in that scenario. > > There is: in create-image. It does make sense to signal an error in that case, too (with a dedicated error symbol). A bit less critical than the JSON case, because the latter can erroneously return nil (and print a message) in situations where nil is a valid return value. And one can create an image spec by hand without calling create-image, so the "real" error is going to happen somewhere else anyway (during redisplay, I imagine). So I would probably split this change into 2 commits: the essential places where no valid code should proceed when there is no support, and cases like create-image, to be easily reverted if we see significant complaints.