From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60197: 30.0.50; beginning-of-defun broken after new treesit impl Date: Wed, 21 Dec 2022 21:00:43 -0800 Message-ID: <7507B4C4-A9E7-4ABF-8D34-9D176F4E20A0@gmail.com> References: <87edsv7lc4.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16511"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60197@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 22 06:01:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p8Dhz-00049N-FS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Dec 2022 06:01:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p8Dhk-0003Zv-PM; Thu, 22 Dec 2022 00:01:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8Dhj-0003Zm-FG for bug-gnu-emacs@gnu.org; Thu, 22 Dec 2022 00:01:15 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p8DhW-00074c-P7 for bug-gnu-emacs@gnu.org; Thu, 22 Dec 2022 00:01:15 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p8DhW-0001XV-4Y for bug-gnu-emacs@gnu.org; Thu, 22 Dec 2022 00:01:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87edsv7lc4.fsf@thornhill.no> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Dec 2022 05:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60197 X-GNU-PR-Package: emacs Original-Received: via spool by 60197-submit@debbugs.gnu.org id=B60197.16716852555902 (code B ref 60197); Thu, 22 Dec 2022 05:01:02 +0000 Original-Received: (at 60197) by debbugs.gnu.org; 22 Dec 2022 05:00:55 +0000 Original-Received: from localhost ([127.0.0.1]:55960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8DhO-0001X8-La for submit@debbugs.gnu.org; Thu, 22 Dec 2022 00:00:54 -0500 Original-Received: from mail-pl1-f169.google.com ([209.85.214.169]:46833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8DhM-0001X0-3f for 60197@debbugs.gnu.org; Thu, 22 Dec 2022 00:00:53 -0500 Original-Received: by mail-pl1-f169.google.com with SMTP id jn22so915536plb.13 for <60197@debbugs.gnu.org>; Wed, 21 Dec 2022 21:00:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=1pNmVNg6y6UyYIcxSIBFRyD1gzHk+UaPysfkQH47UqQ=; b=O0tMtIwqzl6peGxVufp5e0r1kpUlotZG1xDMIq6EUQDl7vcB64nvE7Zp710or/DVL/ kOzv+yWOF2SqZYYQjEOhdF2PPpbhnqceh8idDyMQroQqOyKAWkteNbrhcsNQct0Rj4Tl CWdGWHVK69dGB56vZl1cPSK0uNF5Pd0Eh1rda0mXU1oO+B3YTtKem1ebLPW5LtAqg4gV G7585GqMtxLwQrozNakCDZ+r4Ya/zfgJSK2fHg9NeKS/THFrBg6XOueM0HYssYE2360i tpLO6WPcPmGXB6jofgOF5Y73dtOIl6U2TRivqKl4EXKBFAal1fhL/oZ+wWRTZsDcIFgd Kesg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1pNmVNg6y6UyYIcxSIBFRyD1gzHk+UaPysfkQH47UqQ=; b=JK3a1SAjzeP/Qy7I/lzLoewUb7xaP8qTbVikYWCk6FSziMhTCQYMfS4hbnVtr8lMGk NlK23nOobtbKxPHrlN0PORZTAPfPCzzhG1Z0tMC2w0vGOXk0YSpamHsAD2ppLxvFjF3b 408yqRYeNjy0CovtGC4OXuY5JVpFlzRBhDaJ0W/h5KisGfzFuyl8q2lT2oCY+TVyShMX 5ZSl3gv2aHdbLT8nBh/IE5QqIoSzfWhEdCxRt5jw+ixjXCDlZfpDpnG/1wL0IF9Xs01v 88yDRbLcaz1LoHBQP8qC5KRcV26um1KP7mw2ZhpRlmh+8lbqxYmhrB5eaRN4IFmbZ819 Zi6w== X-Gm-Message-State: AFqh2kqG+cJlKoP3ntt6bvTshYJ2XtTK1ngtKVOTb+C0DdmLhrU1lXXu Pek/tpXhoX1T2O/tBnNzqxk= X-Google-Smtp-Source: AMrXdXupR1Xtz9UQtUUFK3JMkEWfWiXFo3csd5N6cGZ4+i3uCZDDK3RklDVybPm6fZa8n1VHRnCWNw== X-Received: by 2002:a05:6a20:d398:b0:ac:1265:d5bb with SMTP id iq24-20020a056a20d39800b000ac1265d5bbmr6150666pzb.49.1671685246062; Wed, 21 Dec 2022 21:00:46 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id o6-20020a635a06000000b004774b5dc24dsm10426501pgb.12.2022.12.21.21.00.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Dec 2022 21:00:45 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251637 Archived-At: Theodor Thornhill writes: > On 21 December 2022 07:50:04 CET, Yuan Fu wrote: >> >>Yuan Fu writes: >> >>> Theodor Thornhill writes: >>> >>>> Hi, Yuan! >>>> >>>> It seems 'prog-fill-reindent-defun' is broken after the latest = changes >>>> to treesit-beginning-of-defun. The culprit is that we now use = remap >>>> instead of setting the beginning-of-defun-function. What is the >>>> reasoning behind that change? Can't we just rely on the variable >>>> beginning-of-defun-function? >>> >>> Not really, end-of-defun uses beginning/end-of-defun-function in a = way >>> that=E2=80=99s incompatible with nested defuns[1]. So if we want to = support >>> navigation nested defuns reliably we need to remap the commands = instead. >>> In the future (ie emacs 30), we can extend the current >>> beginning/end-of-defun to support nested defuns, then we don=E2=80=99t= need to >>> remap the commands anymore. >> >>I see the problem now... Many other functions uses >>beginning/end-of-defun. I didn=E2=80=99t thought about that initially = :-( >> >>But I don=E2=80=99t want to make big changes to beg/end-of-deun, hmmm. >> >>Yuan > > > I think you can set the functions and remap, right? Maybe you can > force the beginning-of-defun-function variant to choose the smallest > scope as a default? Or just follow the same tactic the user set? Maybe, we can have beg-of-defun-function respect treesit-defun-tactic, and end-of-defun-function simply jump to the end of the defun at point, and remap the commands as we do now. I=E2=80=99ll experiment with that = and see if it works well. Yuan