From: Sergey Vinokurov <serg.foo@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 53242@debbugs.gnu.org
Subject: bug#53242: [PATCH] unify reads from local_var_alist
Date: Fri, 14 Jan 2022 18:37:45 +0000 [thread overview]
Message-ID: <74db84b1-5433-dfb8-8ee3-9d86d8fc9be7@gmail.com> (raw)
In-Reply-To: <83zgny20z2.fsf@gnu.org>
On 14/01/2022 08:08, Eli Zaretskii wrote:
>> Date: Fri, 14 Jan 2022 00:23:42 +0000
>> From: Sergey Vinokurov <serg.foo@gmail.com>
>>
>> I've noticed that local_var_alist field of the buffer structure is
>> accessed inconsistently. Sometimes it's Fassoc, sometimes it's Fassq and
>> other times it's assq_no_quit and even an explicit loop.
>>
>> I think it's safe to unify all the accesses via assq_no_quit since it's
>> an internaly maintained alist that definitely has no cycles and elements
>> are cons cells with symbol as their car.
>
> How long can local_var_alist be? This change will not allow the user
> to C-g from a long search. Do we care? How about using Fassq
> consistently instead?
This list is not directly observed by the user. The lookups happen
during reads and writes of the buffer-local variables so if it's really
slow the only effect user would observe is that elisp got slow. There's
no single point for the user to C-g from.
This list definitely cannot be longer than a list of all the global
variables ever defined. This upper bound is probably a high number, but
not astronomically high. Perhaps if list gets really long it could be
beneficial to use some other data structure, perhaps a hash table, instead.
next prev parent reply other threads:[~2022-01-14 18:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 0:23 bug#53242: [PATCH] unify reads from local_var_alist Sergey Vinokurov
2022-01-14 7:49 ` Lars Ingebrigtsen
2022-01-14 8:08 ` Eli Zaretskii
2022-01-14 8:33 ` Lars Ingebrigtsen
2022-01-14 18:37 ` Sergey Vinokurov [this message]
2022-01-14 19:01 ` Eli Zaretskii
2022-01-14 21:01 ` Sergey Vinokurov
2022-01-15 7:32 ` Eli Zaretskii
2022-01-15 11:41 ` Sergey Vinokurov
2022-01-15 16:02 ` Corwin Brust
2022-01-15 17:54 ` Sergey Vinokurov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74db84b1-5433-dfb8-8ee3-9d86d8fc9be7@gmail.com \
--to=serg.foo@gmail.com \
--cc=53242@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).