unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 71681@debbugs.gnu.org
Subject: bug#71681: 29.3.50; tree-sitter crash
Date: Mon, 24 Jun 2024 00:46:22 -0700	[thread overview]
Message-ID: <74F62063-1C20-4257-92BA-F2CF02B9A588@gmail.com> (raw)
In-Reply-To: <86o77rpnjz.fsf@mail.linkov.net>



> On Jun 23, 2024, at 10:38 AM, Juri Linkov <juri@linkov.net> wrote:
> 
>>> Evaluating this expression causes a crash:
>>> 
>>> (progn
>>> (find-file (expand-file-name "src/treesit.c" installation-directory))
>>> (c-ts-mode)
>>> (font-lock-ensure 63209 63387))
>>> 
>>> in latest master, but not in latest emacs-29 (only in 5-months old emacs-29).
>>> 
>>> If this is not reproducible, I could provide more details.
>>> 
>>> libtree-sitter is at the latest version.
>> 
>> Hmm, I can’t reproduce with latest master and libtree-sitter. Maybe you can send me the exact commits that you used?
>> 
>> Here’s mine:
>> 
>> Emacs: 72f2b01e318
>> Tree-sitter: 6ec478c1
> 
> Probably reproducibility depends on the content of the src/treesit.c file.
> Then the most reliable way to reproduce it is this:
> 
> 0. emacs -Q
> 1. eval: (add-to-list 'major-mode-remap-alist '(c-mode . c-ts-mode))
> 2. C-x v L
> 3. in the *vc-change-log* buffer move point to the commit 20af58d3a13
> 4. type D
> 5. crash caused by diff-font-lock-syntax fontification that uses treesit
> 
> The numbers in (font-lock-ensure 63209 63387) above were extracted
> from diff hunk boundaries that might be different when the file was edited.

I reproduce it once with the first set of commits you provided, but for some reason couldn’t reproduce it again. I’m sure it’s something wrong that I did. I’ll report back when I make progress. TBH it seems like something wrong with tree-sitter itself, but I’ll make sure to figure out what’s the problem exactly.

Yuan




  reply	other threads:[~2024-06-24  7:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 16:33 bug#71681: 29.3.50; tree-sitter crash Juri Linkov
2024-06-22 23:55 ` Yuan Fu
2024-06-23  5:32   ` Eli Zaretskii
2024-06-23  6:46   ` Juri Linkov
2024-06-23 17:38   ` Juri Linkov
2024-06-24  7:46     ` Yuan Fu [this message]
2024-06-26  6:04       ` Yuan Fu
2024-06-29 23:54         ` Yuan Fu
2024-06-30 14:28           ` Vincenzo Pupillo
2024-06-30 16:15           ` Juri Linkov
2024-06-30 19:22           ` Vincenzo Pupillo
2024-07-01  5:37             ` Yuan Fu
2024-07-01 10:20               ` Vincenzo Pupillo
2024-07-01  6:49           ` Juri Linkov
2024-07-01  7:01             ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74F62063-1C20-4257-92BA-F2CF02B9A588@gmail.com \
    --to=casouri@gmail.com \
    --cc=71681@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).