From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Cameron Desautels Newsgroups: gmane.emacs.bugs Subject: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Date: Tue, 9 Dec 2014 13:47:56 -0600 Message-ID: <74EB846F-F46E-427B-90BB-E79EC1934F93@gmail.com> References: <745fafd0-6bc9-40f7-830f-32a916dd898e@default> <8DD29730-77B2-49C6-9FB4-8ABF0D73C2E4@gmail.com> <22ed7d40-17aa-4f93-85fc-565b659fd43f@default> <2C7E5AC2-9C0A-43EB-8FC7-A2C9FB091EA3@gmail.com> <09009907-c8b9-4279-baa8-5c4be0cdf66b@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1418154526 13714 80.91.229.3 (9 Dec 2014 19:48:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Dec 2014 19:48:46 +0000 (UTC) Cc: 19328@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 09 20:48:39 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XyQly-0005dj-4L for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Dec 2014 20:48:38 +0100 Original-Received: from localhost ([::1]:42229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyQlx-0004jw-IQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Dec 2014 14:48:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyQlV-00044l-Lj for bug-gnu-emacs@gnu.org; Tue, 09 Dec 2014 14:48:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyQlO-0003W0-5X for bug-gnu-emacs@gnu.org; Tue, 09 Dec 2014 14:48:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyQlO-0003Vu-2D for bug-gnu-emacs@gnu.org; Tue, 09 Dec 2014 14:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XyQlN-0004lu-P5 for bug-gnu-emacs@gnu.org; Tue, 09 Dec 2014 14:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Cameron Desautels Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Dec 2014 19:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19328-submit@debbugs.gnu.org id=B19328.141815448018335 (code B ref 19328); Tue, 09 Dec 2014 19:48:01 +0000 Original-Received: (at 19328) by debbugs.gnu.org; 9 Dec 2014 19:48:00 +0000 Original-Received: from localhost ([127.0.0.1]:59975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyQlM-0004le-6p for submit@debbugs.gnu.org; Tue, 09 Dec 2014 14:48:00 -0500 Original-Received: from mail-oi0-f49.google.com ([209.85.218.49]:63461) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XyQlK-0004lW-0I for 19328@debbugs.gnu.org; Tue, 09 Dec 2014 14:47:58 -0500 Original-Received: by mail-oi0-f49.google.com with SMTP id i138so912412oig.36 for <19328@debbugs.gnu.org>; Tue, 09 Dec 2014 11:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=b9j/ffEacM6ximJ+ddJAsIpTQaMj+WG0/tAkTF8RdAg=; b=Thuh7zQe5VDSQkEJfYpf+KyxgM9Amv5xeh+keKwKF0pv8W9n2JFhnK0WF9w/4WAp/I bIRRXPRVEb3MQPigaPD7sMQmSfO7HWO0pfvai2qv/gWNYiCkjEfRXkNJbfQWI21oXpeI jqwksE8uAk5jiK1gf9g4J3paPpECW4U4IA1K1Jbh2KkxXO+qI12R2btGecRipRlGlDaW 9pkrs8u9H8k9xGQUdQqE26ZGI1hzOKmRrUsO1viVXV+QbUIBJSiF/CZ0dJRk2d972nQa x8jHBliSuvNK10vbV/fdiUeidbb3XaQvqFw85nqsd3WMhATThnaES3XSUHoYf406GJwE TrAQ== X-Received: by 10.202.89.138 with SMTP id n132mr11238352oib.109.1418154477140; Tue, 09 Dec 2014 11:47:57 -0800 (PST) Original-Received: from [192.168.168.123] (rrcs-24-227-130-234.sw.biz.rr.com. [24.227.130.234]) by mx.google.com with ESMTPSA id ph6sm901129oeb.5.2014.12.09.11.47.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 09 Dec 2014 11:47:56 -0800 (PST) X-Priority: 3 In-Reply-To: <09009907-c8b9-4279-baa8-5c4be0cdf66b@default> X-Mailer: Apple Mail (2.1993) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97104 Archived-At: > FWIW, These are the changes I made to `customize-unsaved': > ;; 1. By default, ignores preferences in `customize-customized-ignore'. > ;; 2. Added prefix arg to override `customize-customized-ignore'. > ;; 3. When not interactive and there are changes, ask for confirmation. > ;; 4. Always returns `t', so it can be used as a > ;; `kill-emacs-query-functions' hook. > ;; 5. Wrap in `condition-case' and reissue error. Thank you for sharing that! I looked through it to see if I'm missing anything important. Your code is much more ambitious than the humble patch I'm offering. I definitely see the rationale behind your work on `cus-edit+.el' but I think the important parts of it are orthogonal to what I've done here. WRT the five items above, 1 & 2 can be disregarded here because `customize-customized-ignore' only exists in your library (and is only necessary because of the elimination of the "changed outside of Customize" state). 3-5 I cover differently--a new function rather than changing the behavior of `customize-unsaved'--and this way has the benefit of being minimally invasive (i.e. shouldn't break anyone else's code). TLDR I still think it makes sense to merge the patch. -- Cameron Desautels