From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Felician Nemeth <felician.nemeth@gmail.com>, 61506@debbugs.gnu.org
Cc: joaotavora@gmail.com
Subject: bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function
Date: Tue, 14 Feb 2023 18:44:01 +0100 [thread overview]
Message-ID: <74E0BF9F-42AF-4578-9681-D0FB936081AE@thornhill.no> (raw)
In-Reply-To: <87pmacjl4l.fsf@betli.tmit.bme.hu>
On 14 February 2023 16:56:58 CET, Felician Nemeth <felician.nemeth@gmail.com> wrote:
>Hi Theo,
>
>> The LSP spec supports an optional command in the completion results, so
>> that the server can know what completion candidate was selected. That
>> information can then be used by the server to score candidates for
>> better completion results etc.
>
>Can you list some servers that send this info? And if it is not too
>much trouble can write a simple recipe where supporting this feature
>actually makes a difference? Thanks.
>
Jdtls does. See https://github.com/eclipse/eclipse.jdt.ls/blob/c4ed39a70e8c32e055a1b136ceb6c0477687a330/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTDelegateCommandHandler.java#L152
As for proving a difference, not sure how easy that is. The code around the link I posted seems to score, so I guess over time the server should learn _something_. It's a little hard to verify anyway because eglot doesn't respect the ordering provided by the server (which is a different bug in itself).
Anyway, lsp-mode, neovim and others support this, so I see no reason we shouldn't :)
>> This simple patch adds support for this.
>> I have no strong opinions on _where_ exactly the command should be sent,
>> as in before or after the didchange notification.
>
>The specification only says: "An optional command that is executed
>*after* inserting this completion." I think it is worth asking for
>clarification at https://github.com/microsoft/language-server-protocol
>(I'd guess it's safer to send the command after the didChange
>notification.)
I agree.
Theo
next prev parent reply other threads:[~2023-02-14 17:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 11:00 bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-14 15:56 ` Felician Nemeth
2023-02-14 17:44 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-14 23:49 ` João Távora
2023-02-15 12:34 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-18 22:20 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-18 23:23 ` João Távora
2023-02-20 14:13 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 11:51 ` Felician Nemeth
2023-02-15 12:24 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-11 15:12 ` Felician Nemeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74E0BF9F-42AF-4578-9681-D0FB936081AE@thornhill.no \
--to=bug-gnu-emacs@gnu.org \
--cc=61506@debbugs.gnu.org \
--cc=felician.nemeth@gmail.com \
--cc=joaotavora@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).