From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#56025: [PATCH v2] 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin Date: Sat, 23 Jul 2022 21:05:42 -0700 Message-ID: <73ed3965-3dfb-75e9-eab1-389507b7112d@gmail.com> References: <8e21db9c-0100-998e-f280-81304e7ff61a@cornell.edu> <96e47ba7-efaa-b6df-dd98-60f09068e68c@gmail.com> <874k097lbh.fsf@melete.silentflame.com> <8735frmjrr.fsf@athena.silentflame.com> <4676f52c-4758-38df-f0f4-dbcb5d848c1b@gmail.com> <8735fr2kq6.fsf@melete.silentflame.com> <10cf6a90-f86a-b0df-4dc2-c258b7494158@gmail.com> <18e79c02-3a2a-77d1-3798-33711f52d6b9@cornell.edu> <19c66901-2eeb-1f40-17a4-4ed54827e065@gmail.com> <5990de80-63a5-ac9b-1a11-c814aa9e38f2@gmail.com> <3779ea08-f481-5fb5-3257-ca9fa7c604bc@cornell.edu> <60cf587b-5d83-31d6-f0af-56979b221425@gmail.com> <6725161c-1d45-8ded-5d75-aa1a74c9b3ed@gmail.com> <91cb3365-119c-8f3a-4c7b-5c83792dcf88@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27046"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 56025@debbugs.gnu.org To: Ken Brown , Sean Whitton , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 24 06:06:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFSsg-0006ra-Tq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Jul 2022 06:06:15 +0200 Original-Received: from localhost ([::1]:51612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFSsf-0006yq-6o for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Jul 2022 00:06:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFSsU-0006yc-V5 for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 00:06:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56915) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFSsU-0005am-LC for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 00:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFSsU-00073m-DV for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 00:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jul 2022 04:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56025 X-GNU-PR-Package: emacs Original-Received: via spool by 56025-submit@debbugs.gnu.org id=B56025.165863555727128 (code B ref 56025); Sun, 24 Jul 2022 04:06:02 +0000 Original-Received: (at 56025) by debbugs.gnu.org; 24 Jul 2022 04:05:57 +0000 Original-Received: from localhost ([127.0.0.1]:46662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFSsP-00073U-3r for submit@debbugs.gnu.org; Sun, 24 Jul 2022 00:05:57 -0400 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:39652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFSsI-000739-5N for 56025@debbugs.gnu.org; Sun, 24 Jul 2022 00:05:54 -0400 Original-Received: by mail-pg1-f179.google.com with SMTP id q16so7546017pgq.6 for <56025@debbugs.gnu.org>; Sat, 23 Jul 2022 21:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=IFhB6mOJuWnEz8XLZd5+X+Atlv0L/Ejm5P3bEtw5hE0=; b=P4ZfPWeENPv2RPPDxafoSUJ1QX8hxWllS08kGeoqtkzBALawgDCVLrE/3/NHQa27z9 R7kzvj4y8cOBd7vogECz7oW1XQjNdqANY3yFIQzbHluIxzCTjmTUjHggTEwi8M+gaot6 NyGuTPf407G9By8wCAaRfvKL29fQ2pxI6nYNXFt9rrz46qXuxiGcIQMDzTrT9T/67YO/ pnTwOPEvuKgKZgKoLu4oz55O9/mRRPi1rnU4e/7Xz7zzVCrst6l1AGgscGZsuf6ub6uo ssJ92n/jSdRN4gR3q9uV3b2Ohwm7zF73NuNoOaz/F6g+SBsGjX36Y4LO40oarpSLoGEI xAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IFhB6mOJuWnEz8XLZd5+X+Atlv0L/Ejm5P3bEtw5hE0=; b=e5pQDK4WbpRM+d6k6wTaXeayDm+p+7XTNoiiuyCO28orhNd9wXhX40tPCHpn8brQBt eT6/AB2C0jQav6ParDbaTT/gU24vpjHHo2a88DUIPY+6TCworJFA9nOe8mmzcVBTBtv8 nBXn1rXfF4dovOI9NcCLgCpUXWytTNtgwYQIqHzRvvhCYsJUG+l1Bzulq4MVJgzMcZR3 zCddO4cjA7jSVdjPTaAPcQAyfjUFuHqJ/p9AfkF4/n8Pm1Q/3i6TiCA1mso+mcAxw1Tq kygOe4gTGf6cyWVNkiN3XhO9h1aRKF8MPqyBL/rYAMfQavQMYl0YaTlt6OIzEBuIQQYX S0rw== X-Gm-Message-State: AJIora9KzNNcvR3FH1oZojolqZmFIPjXfwgm3wPlS3j8lQFUoNWHAU14 bT2okDupEtCLQk5jwltVs2Uy21r6l9o= X-Google-Smtp-Source: AGRyM1szITjZSG/zRA2sY53hOGDi8aSzdQ5dSzbNCokVEoiLpoZ20YZOGw7t+LwbKh/mAfiM2YeIOw== X-Received: by 2002:a05:6a00:124b:b0:52a:c7de:c76 with SMTP id u11-20020a056a00124b00b0052ac7de0c76mr7084937pfi.5.1658635544162; Sat, 23 Jul 2022 21:05:44 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b9-20020a17090ae38900b001f20c694cccsm6086272pjz.35.2022.07.23.21.05.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Jul 2022 21:05:43 -0700 (PDT) In-Reply-To: <91cb3365-119c-8f3a-4c7b-5c83792dcf88@cornell.edu> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237798 Archived-At: On 7/22/2022 12:00 PM, Ken Brown wrote: > On 7/22/2022 12:16 AM, Jim Porter wrote: >> Ok, I *think* this is done. > > I can confirm that the em-extpipe tests now all pass on Cygwin, as do > the process tests. Thanks for testing. I'm glad everything seems to be working for you too. I did a bit more testing on my end to check out performance, since I figured we'd see at least some improvement from switching to pipes for passing data between processes. I wasn't prepared for just how much of an improvement though. On my system (GNU/Linux), this change makes piping in Eshell faster by a factor of 35x![1] I'll repeat that since I'm pretty shocked myself: Eshell pipes are *thirty-five* times faster now! For some details: I tested this by running "time *cat config.log | wc" in Eshell (n=20), and it went from an average of 4.80s to an average of 0.134s. (Note that `time' in Eshell only times the first command, not the whole pipeline.) I chose this to test since config.log is reasonably big (1.13MiB on my system), the external cat program is pretty simple and mostly just does I/O, and wc's output is short so we don't have to worry about it writing a bunch of output to its (slow) PTY. However, to put just a bit of a damper on things, this is still 5-10x slower than doing it in Bash, or with Eshell extpipes (which is really the same as just doing it in Bash, ultimately). [1] YMMV, of course.