From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Date: Thu, 9 Jan 2025 15:52:57 +0100 Message-ID: <73d3590c-8393-4585-86c1-d6d69a3e42da@orange.fr> References: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> <8cc723b7-c6c5-450d-9832-9039362d63a5@gmail.com> <86ed1c31o6.fsf@gnu.org> <822bd2c9-7463-4c55-89c2-2eabd990944d@orange.fr> <86tta812cz.fsf@gnu.org> Reply-To: David Ponce Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5990"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: maurooaranda@gmail.com, 73178-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 09 15:54:36 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVtve-0001M9-LP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jan 2025 15:54:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVtvA-0007Cl-Va; Thu, 09 Jan 2025 09:54:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVtv8-0007CP-BQ for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 09:54:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVtv8-0000bJ-36 for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 09:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=b/u9ztohVvuGm4ks1BNAQpbzOmaw5hrZkO1dcZvpmTI=; b=qkHUTCmbFY+51+GeB+8WeGXvtv9dyPCcFEpoAOTyUGv6YQ42IC/0aJ+tHxrtkJqFA39y1CCo+zSpbW/ry7UXzzzSNc1Ghou9lxBScNcr+uwAkonsp9+lQKt+rWdQXWLzzT6VYc/vS0X8lrQb78J/t3I8/Q7OHI9Zds+fwyp2WUWl9qJeecah9vlbTtDP9x05a09ax92ZtdqAd5j++QskCBAp6gm9nUAQWv2WPf87WDc0hZobr2+pYfwg3Erz4xFDX4YSU5EbBsla+LsJSnN8eDpLqP3VP1Cg/odZ7G0BM3WGKiV9eqAm7uqmUyWyV72fhqD1DRLLt+5jKODgLhpObQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVtv7-00042J-Sm for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 09:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 14:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73178-done@debbugs.gnu.org id=D73178.173643438815437 (code D ref 73178); Thu, 09 Jan 2025 14:54:01 +0000 Original-Received: (at 73178-done) by debbugs.gnu.org; 9 Jan 2025 14:53:08 +0000 Original-Received: from localhost ([127.0.0.1]:51362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVtuF-00040u-Uc for submit@debbugs.gnu.org; Thu, 09 Jan 2025 09:53:08 -0500 Original-Received: from smtp-79.smtpout.orange.fr ([80.12.242.79]:56135 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVtuD-00040k-1Y for 73178-done@debbugs.gnu.org; Thu, 09 Jan 2025 09:53:06 -0500 Original-Received: from [192.168.1.21] ([90.112.40.65]) by smtp.orange.fr with ESMTPA id Vtu5tVJJgTA3oVtu8tHswx; Thu, 09 Jan 2025 15:53:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1736434383; bh=b/u9ztohVvuGm4ks1BNAQpbzOmaw5hrZkO1dcZvpmTI=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=Jajc7VVrNTTDokf6XBXadZ3Nfdmlz6YL4fSglyH7uICh8Qu7lYmLshdycCFdr5doc +U0ejDltXTy7qHsU8cpwkJAijYW/iWqHizJVq1EU8g4fYSyMLPMYyltjBK5stHan+z zNU3WSy8tvnL5snhecCHWjQLe4kQpPwcY01U2Wzo0ynYHTf7Y0h6CY3kmq+C0zWS5Q N7svvr3xBMQ+aWY5Y2dP+EXE/qFjcKREgoyo+5/zdXlEl//ie363Sl2mSGKHzVAX3u gIxb5ImCR8NHtawcQATfysQ7npPRd5vK/n20IeSfQWwOyebURXwtHM2avOGjiyrWHS 1pLRwsePWgnow== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Thu, 09 Jan 2025 15:53:03 +0100 X-ME-IP: 90.112.40.65 Content-Language: fr, en-US In-Reply-To: <86tta812cz.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298842 Archived-At: On 2025-01-09 15:35, Eli Zaretskii wrote: >> Date: Thu, 9 Jan 2025 11:01:40 +0100 >> Cc: 73178@debbugs.gnu.org >> From: David Ponce >> >>> I wanted to install this, but byte-compiler produces a warning: >>> >>> ELC cus-edit.elc >>> >>> In toplevel form: >>> cus-edit.el:5595:20: Warning: reference to free variable `custom-icon--texts-widget' >>> >>> Is that a typo, and you actually meant custom-icon--texts-sub-type? >>> >>> Also, could you please accompany the patch with the ChangeLog-style >>> commit log message (see CONTRIBUTE for the details)? Otherwise, I >>> will have to write the log message manually when installing your >>> changes. >>> >>> Thanks. >> >> Hello Eli, >> >> Hmm, it seems you didn't install the correct patch? >> I attached the correct patch (V2) which applies cleanly for me. >> Also below is my proposed ChangeLog. >> >> Thank you, and thanks Mauro for your review. > > Thanks, and sorry for missing the last patch earlier. No worries. I should have double-checked my patch before submitting it ;-) > > Now installed on master, and closing the bug. Thank you very much!