unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: maurooaranda@gmail.com, 73178-done@debbugs.gnu.org
Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon
Date: Thu, 9 Jan 2025 15:52:57 +0100	[thread overview]
Message-ID: <73d3590c-8393-4585-86c1-d6d69a3e42da@orange.fr> (raw)
In-Reply-To: <86tta812cz.fsf@gnu.org>

On 2025-01-09 15:35, Eli Zaretskii wrote:
>> Date: Thu, 9 Jan 2025 11:01:40 +0100
>> Cc: 73178@debbugs.gnu.org
>> From: David Ponce <da_vid@orange.fr>
>>
>>> I wanted to install this, but byte-compiler produces a warning:
>>>
>>>       ELC      cus-edit.elc
>>>
>>>     In toplevel form:
>>>     cus-edit.el:5595:20: Warning: reference to free variable `custom-icon--texts-widget'
>>>
>>> Is that a typo, and you actually meant custom-icon--texts-sub-type?
>>>
>>> Also, could you please accompany the patch with the ChangeLog-style
>>> commit log message (see CONTRIBUTE for the details)?  Otherwise, I
>>> will have to write the log message manually when installing your
>>> changes.
>>>
>>> Thanks.
>>
>> Hello Eli,
>>
>> Hmm, it seems you didn't install the correct patch?
>> I attached the correct patch (V2) which applies cleanly for me.
>> Also below is my proposed ChangeLog.
>>
>> Thank you, and thanks Mauro for your review.
> 
> Thanks, and sorry for missing the last patch earlier.

No worries. I should have double-checked my patch before submitting it ;-)

> 
> Now installed on master, and closing the bug.

Thank you very much!





  reply	other threads:[~2025-01-09 14:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11 14:28 bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-11 15:19 ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-11 15:28   ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-08 13:59     ` Mauro Aranda
2025-01-09  7:07       ` Eli Zaretskii
2025-01-09  9:10         ` Mauro Aranda
2025-01-09 10:01         ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-09 14:35           ` Eli Zaretskii
2025-01-09 14:52             ` David Ponce via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-09-14  9:52   ` Eli Zaretskii
2024-09-14  9:51 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73d3590c-8393-4585-86c1-d6d69a3e42da@orange.fr \
    --to=bug-gnu-emacs@gnu.org \
    --cc=73178-done@debbugs.gnu.org \
    --cc=da_vid@orange.fr \
    --cc=eliz@gnu.org \
    --cc=maurooaranda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).