From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#3600: 23.0.94; shrink-window-if-larger-than-buffer Date: Fri, 19 Jun 2009 14:23:36 -0700 Message-ID: <72CF189B361D4D1E8D8E3FED0AFEEDA0@us.oracle.com> References: <0F4C735B7FF74432818F7CFAB4C85394@us.oracle.com> <4A3A11E7.4060900@gmx.at> <4A3B518B.20806@gmx.at> Reply-To: Drew Adams , 3600@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1245447459 6815 80.91.229.12 (19 Jun 2009 21:37:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Jun 2009 21:37:39 +0000 (UTC) Cc: 3600@emacsbugs.donarmstrong.com To: "'martin rudalics'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 19 23:37:36 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MHlmB-0005gG-3Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Jun 2009 23:37:35 +0200 Original-Received: from localhost ([127.0.0.1]:47529 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHlmA-0001IR-EK for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Jun 2009 17:37:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHlm4-0001FP-Ri for bug-gnu-emacs@gnu.org; Fri, 19 Jun 2009 17:37:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHlm0-00016c-OL for bug-gnu-emacs@gnu.org; Fri, 19 Jun 2009 17:37:28 -0400 Original-Received: from [199.232.76.173] (port=41644 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHlm0-00016K-Hl for bug-gnu-emacs@gnu.org; Fri, 19 Jun 2009 17:37:24 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:52273) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MHllz-0006Oe-UC for bug-gnu-emacs@gnu.org; Fri, 19 Jun 2009 17:37:24 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5JLbLUQ025119; Fri, 19 Jun 2009 14:37:21 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n5JLU4cU023764; Fri, 19 Jun 2009 14:30:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 19 Jun 2009 21:30:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3600 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3600-submit@emacsbugs.donarmstrong.com id=B3600.124544662722881 (code B ref 3600); Fri, 19 Jun 2009 21:30:03 +0000 Original-Received: (at 3600) by emacsbugs.donarmstrong.com; 19 Jun 2009 21:23:47 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from rgminet11.oracle.com (rcsinet11.oracle.com [148.87.113.123]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5JLNhws022870 for <3600@emacsbugs.donarmstrong.com>; Fri, 19 Jun 2009 14:23:44 -0700 Original-Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5JLOfSI004704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 19 Jun 2009 21:24:43 GMT Original-Received: from abhmt006.oracle.com (abhmt006.oracle.com [141.146.116.15]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5JLNeT5032561; Fri, 19 Jun 2009 21:23:40 GMT Original-Received: from dradamslap1 (/24.5.177.54) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 19 Jun 2009 14:23:33 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4A3B518B.20806@gmx.at> Thread-Index: Acnwu1kHaRgDpQ3JQsGvkURPSnuIAAAaEe/g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt006.oracle.com [141.146.116.15] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.4A3C01D6.0175:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 19 Jun 2009 17:37:28 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28856 Archived-At: > > I don't know how to try it. What recipe do you suggest? > > Apply the patch and either remake emacs or put the code of the patched > `shrink-window-if-larger-than-buffer' into your .emacs and > wait till it starts barking. And don't forget to tell me if it > doesn't bark at you for a couple of weeks. Then we can install it. I think I'll pass. The affected part of the code is something that I will probably never run into, let alone within a couple of weeks. The use case for that code path is something that someone else will need to test, if it is tested at all. > > I didn't try anything before; I was just perusing the > > code, and I wondered what it was trying to do. > > The only way to understand such code is by comparing the original code > with the present one and, if they differ, go through the > revisions, look at the ChangeLogs, and maybe scan emacs-devel and > friends for errors reported wrt that code. I think you misunderstood me. I was speaking about perusing the original code, not yours. I was saying that I didn't run into a problem trying to do something. I didn't run into a problem at all. I was simply browsing the (original) code and noticed that it seemed strange. That's all. I have no problem with your fix. (And I personally have no problem if no fix is applied.)