From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#73911: Issue with `widget-specify-button' Date: Wed, 1 Jan 2025 08:03:07 -0300 Message-ID: <72485098-73be-470f-8965-9922613af637@gmail.com> References: <075599db-7d78-4475-aa71-daba0e06cf9e@orange.fr> <864j4pzwxx.fsf@gnu.org> <86bjyfguns.fsf@gnu.org> <861pyt9hdo.fsf@gnu.org> <86zfkyvc74.fsf@gnu.org> <86jzbkt647.fsf@gnu.org> <7cc4a2df-41d7-4b11-8fe9-c4b639ed7c8e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38001"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii , 73911@debbugs.gnu.org To: David Ponce Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 01 12:04:25 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSwWW-0009kC-Uh for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Jan 2025 12:04:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSwWE-000491-B1; Wed, 01 Jan 2025 06:04:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSwWB-00048i-Oy for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 06:04:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tSwWB-0007wO-Ay for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 06:04:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=YjnahUkwdmdw083pinO9Th3hu+z4TKjI1sVgXQR4kPU=; b=gfSh1uPHOR0vHEYqJpw5gMH7II3Em9yqTyAM0OlExNKR+JGEet2H1PqI0Ag8Vbd1ryAu2g2WjjnAki3tv9b5iua3rPQOuNKzh3hQBx/yLqI1juRDqRy7F24QchrtjXjs3yUfLGrPjSjB9UHv/5t92Zrf2r63evq1Yh/dgCpMiBJRaYJRvRgqgQY9rdqBnMPCS53a4wvWUVl5GVnvLnDp4ibNvx0xuYEb/HPKDeNti4YodddvcQEYEerr+CldDSVqTbiMVBgIedwcfdd4wxEu+uFYdOp0I7t4fuzQfEM+g8F141iFDaGa+Eq1rVqZ+Pw5mhvlniQ9mNK3Fg7YHSkoHw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tSwWA-0007MB-65 for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 06:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Jan 2025 11:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73911 X-GNU-PR-Package: emacs Original-Received: via spool by 73911-submit@debbugs.gnu.org id=B73911.173572939628208 (code B ref 73911); Wed, 01 Jan 2025 11:04:02 +0000 Original-Received: (at 73911) by debbugs.gnu.org; 1 Jan 2025 11:03:16 +0000 Original-Received: from localhost ([127.0.0.1]:37854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSwVP-0007Ku-N8 for submit@debbugs.gnu.org; Wed, 01 Jan 2025 06:03:16 -0500 Original-Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:59592) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tSwVN-0007Kl-5r for 73911@debbugs.gnu.org; Wed, 01 Jan 2025 06:03:13 -0500 Original-Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-21675fd60feso188041995ad.2 for <73911@debbugs.gnu.org>; Wed, 01 Jan 2025 03:03:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735729392; x=1736334192; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YjnahUkwdmdw083pinO9Th3hu+z4TKjI1sVgXQR4kPU=; b=XBoidNdFw2Jyyn9aM6Okj4/bNlNbLPVkravEL+4AITNiWZdHFh/DvelLrrOgcCA9eh 2gA4YMunqdUByki29qI+huR8iarOYoIGKnvNgqewcfGvl6c7MlLmbFfBIqpHiZFt2Mj0 kidClqdV6uK1kYp6du5UoLjfKOC2wV1A//Lw2s6hOSbLj5pmrUIrDTZjXKSqzxmHNFK6 aXDpjomft50VSzwXTPHoEZt/U4uWNYKix8EhSTN51u966FkSr7paHtJuPYVfBOLsQ+lM 88x2mgUuJnHDEgh3JYW1gWN3VVhmTQAMbfKhatysbpUEJzpz3QDAlZvGERQJ8U9uLDRP ELlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735729392; x=1736334192; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YjnahUkwdmdw083pinO9Th3hu+z4TKjI1sVgXQR4kPU=; b=M//n402Gy/x4xptZ+JgmzXgN8Ik6IX6+1NfI63ChDtZ9mFLH1Bj8nIzFWq5pEm+xLs +75462mM/HxWmQuBeovhT1lpsd9/oVti4umsmDhtG+S+HpaWc+zUUvfQhGzpbUNWBjNj TVoRzsH5+H57uszODoZYFEXiwf2kh5bLXjCPlIz8UmoMT/vQifaWeL7p5PP9vK2OAf4h mT2IST0PX2+hcMia7OV954QC2pfeZZWrSBYbzehL3HXPXOViR2RdOrsu4GgKe6Nejxxs bPza4drhxwbxEk5HK+H0ZMAFNdXULD0+x8tG7cij1e2UNihlqGMCKjfH9J6CrN5ErLtF 1QSQ== X-Forwarded-Encrypted: i=1; AJvYcCWenE+s2amN1AZYlz3X/W5slFmE2utXeQjfXDS60J4BidhoTpDY8LIR+7gvlXtXs3WtCvJdXw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzimAgP+qAxrHSVuEWpQBIPPJwm/xn8uJ+6L1GdVGPGzd7lq3MA kSLKj3g6fGLZVRgcnzL7spTGrZ1cpjCK2Es2Rikk+WO5ZvYUg5t0 X-Gm-Gg: ASbGncs9CyZGdIM3b6aGIPvBY07ftblTO3gzk8v9V1GKGM7KZjO1yoIyrF2yU6YgZTL xgtHva5NDVijNn8MizDVkqfJ0LPvT67iH/XOagD1vJy1I07pk+ckIiqRaYi5xZ3qBo77yqkSm6M t8hRtIuIbSmIJO8hNRrxrZPWmqOTq9G/CUBmm2mOJT84XjaPDmkB7f0wsL881a0QL0gJuRpSbdf EXvd1YeRuz5uL32lTk0XEq8VgpMgo861rXANBKIlyM0hRbPjKfzh1LN1n7CDaE= X-Google-Smtp-Source: AGHT+IECyHxhe0KW99APC/3Hqcvrcopve2yNHTVG88i3culEj8MtPQN3d+vbWFiD7JSY+DOM10ORjw== X-Received: by 2002:a17:902:d2c6:b0:216:2bd7:1c36 with SMTP id d9443c01a7336-219e6e8bbb6mr598955125ad.1.1735729391871; Wed, 01 Jan 2025 03:03:11 -0800 (PST) Original-Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca01415sm208939715ad.231.2025.01.01.03.03.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jan 2025 03:03:11 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298061 Archived-At: David Ponce writes: > On 2024-12-31 12:34, Mauro Aranda wrote: > [...] >>  >> > > > Mauro, any comments? >>  >> > > > >>  >> > > > >>  >> > > > >> I don't really know the effects that this change could have (whether >> good or bad).  The added invisible space comes from Bug#51550, which >> involved some discussions about the display engine itself. >> I had trouble reproducing the bug itself, since I don't understand >> what >> the unexpected result is. >> David, I'm sorry it took me so long to reply, but can you explain a >> bit >> more what's the unexpected result? Thank you. >> > > Hi Mauro, > > I attached a screenshot of the result: > > 1. with the current version of `widget-specify-button' which clearly shows >    the unexpected appearance of the "OK" button when the button face has a >    :box attribute and the button prefix use a display space property. > > 2. with the patched version of `widget-specify-button' which shows the >    expected appearance of the same "OK" button. > Thanks, I see it now. > It seems the problem is due to the invisible space inserted in front of the > button without specifying the face property, which causes a discontinuous > display of the button prefix when it uses a display space property. > Agreed. > My proposed change just set the face of the invisible space to the button > face, which seems to fix the appearance of the button when the button > prefix has a display space text property. I think it makes sense.  It's the only place in wid-edit that we add something "extra" to the overlay (as in not specified in the :format property) that represents the widget in-buffer, and we should respect the button face. > I hope you will enjoy the new year. > > Thank you for your help. Thanks, have a great year you too.