From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Date: Tue, 14 Dec 2021 16:17:39 -0800 Message-ID: <723c8965-31be-b636-beee-478fb77423ec@gmail.com> References: <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> <86mtl3629t.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5433"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 15 01:52:58 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxIXR-0001Dg-Du for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Dec 2021 01:52:57 +0100 Original-Received: from localhost ([::1]:49744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxIXP-0007I5-M2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Dec 2021 19:52:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxHzf-00055h-1C for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 19:18:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mxHze-0006TZ-Lx for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 19:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mxHze-000672-H8 for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 19:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 00:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163952746823477 (code B ref 52293); Wed, 15 Dec 2021 00:18:02 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 15 Dec 2021 00:17:48 +0000 Original-Received: from localhost ([127.0.0.1]:59872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxHzQ-00066a-93 for submit@debbugs.gnu.org; Tue, 14 Dec 2021 19:17:48 -0500 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:50882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxHzO-00066O-US for 52293@debbugs.gnu.org; Tue, 14 Dec 2021 19:17:47 -0500 Original-Received: by mail-pj1-f52.google.com with SMTP id gj24so1850938pjb.0 for <52293@debbugs.gnu.org>; Tue, 14 Dec 2021 16:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=LqQxRkmbvbybKq6F5Y0iK0KvP8Tos1K0p72VgQv/4vo=; b=E+cES5ftS19KQqRQPnI7ooWLbYRcjVZEAeg4NgLjsv4xZL4xLVxydY3KKXvYiBshE1 qlwooYgV0yem2cBw8jkTOOSRT5Ft0MOZU6W8dARZZh5tMt5ODK8QaY+uMvnB8fefjGTk ud9a/hSz8Su6cumMR8SQpIdi/b8vdMabrgo/qdI6WDSA/JRRMDOINcAChGcG1upbPuXQ ocIrhLqO+lNI1ct8Eqpmc2xbrmOjjx3GU1F2CojUKw8Yu1fkWGKvD+biCZMUiHIW+aMC UN2aoAdu2wv04A2zpd87scmDbMwva4o4aEQz52XaDh6W4smyRmgoF+punoKRM3xN+GPR 7lFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LqQxRkmbvbybKq6F5Y0iK0KvP8Tos1K0p72VgQv/4vo=; b=NrfIPkJazu97bz8Izdz42/xwTV6k5GX1AGC/yprFf5fHhpAJRqavP9ZcgrQKToRybs mWHc1vNUC0yjoZ4RenvsxULixk4TBmSL+PUVvGu+hFHHwDkMPbX4amj+tChvlsj4CR36 Ms+DLOd2cnywermzyeLzoXKjF6DE+UfaR8p80geVxozsZ6J7RJn4b8OUJRTOhwd+ncTe 7yjqeSoREdZ9K0Wtzr+27FcuGp9U+c+Ii0B82K1KPdbwTwMLnE6CMq8ko27dbGNqJGOy RDEkGEHfTjtA7GbubXHXZlI7Loe7LxrQEUITXpIHyiYgus2tIhsWctlZlgk4sDKoKpRa +DTw== X-Gm-Message-State: AOAM53381XGQbFpqeuaUzxVndSlTH2tbCt23lnlMS5MaMxEF+dwreajW HJVffpiIdvzBtTk3Hf+FTdjUElkeSyI= X-Google-Smtp-Source: ABdhPJz/m9ka37DjgqOyNf1/RYHFb+Axy8Zf/cCaVdBMNJVRLcNDxs/7JVIY2wgNcMG+HlGhAqInbw== X-Received: by 2002:a17:90b:2251:: with SMTP id hk17mr8849232pjb.31.1639527461171; Tue, 14 Dec 2021 16:17:41 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id e7sm223855pfv.156.2021.12.14.16.17.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Dec 2021 16:17:40 -0800 (PST) In-Reply-To: <86mtl3629t.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222402 Archived-At: On 12/14/2021 12:30 AM, Juri Linkov wrote: > Thanks. The current question was raised by Drew who worried that > sometimes authors might want to leave two adjacent separators > for an empty submenu. But you answered this question that it can be > addressed by using a special form of a separator with a menu-item. > So I see no more problems here. For simplicity, I'll focus on *just* the issue described in the original post to this bug (i.e. improving how we detect consecutive separators so we can de-duplicate them more reliably). Then I'll send a message to emacs-devel to gauge interest in supporting de-duplication in other menus. If there's interest, it would probably make sense to have the de-duplication be opt-in so that we avoid any surprising behavior in other menus. However, if people don't think de-duplication of separators would be useful in other menus, then we can just keep the logic we have now (along with the bug fix mentioned above). Does that sound reasonable?