From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken Date: Mon, 21 Feb 2022 12:37:59 -0800 Message-ID: <71c773bd-1166-8d36-5dac-8d6b81240a2a@gmail.com> References: <7da3e8b2-7400-dca6-6d92-0a60e3d9c215@gmail.com> <83mtinz222.fsf@gnu.org> <83ley6y5gx.fsf@gnu.org> <83a6emxak3.fsf@gnu.org> <272c6d13-6d35-a896-1468-2c9bc3befe87@gmail.com> <83a6ekuomt.fsf@gnu.org> <87k0dof7az.fsf@gnus.org> <835yp8ul58.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------0D483DB86DAFD49FC8869D67" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8243"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54062@debbugs.gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 21 21:39:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMFSi-0001yJ-W5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Feb 2022 21:39:13 +0100 Original-Received: from localhost ([::1]:34088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMFSi-0004ep-3q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Feb 2022 15:39:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMFSZ-0004dl-CM for bug-gnu-emacs@gnu.org; Mon, 21 Feb 2022 15:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45368) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMFSZ-0006Il-2F for bug-gnu-emacs@gnu.org; Mon, 21 Feb 2022 15:39:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMFSX-0007eY-Ou for bug-gnu-emacs@gnu.org; Mon, 21 Feb 2022 15:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Feb 2022 20:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54062-submit@debbugs.gnu.org id=B54062.164547589529362 (code B ref 54062); Mon, 21 Feb 2022 20:39:01 +0000 Original-Received: (at 54062) by debbugs.gnu.org; 21 Feb 2022 20:38:15 +0000 Original-Received: from localhost ([127.0.0.1]:39265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMFRg-0007dO-Jq for submit@debbugs.gnu.org; Mon, 21 Feb 2022 15:38:15 -0500 Original-Received: from mail-pg1-f169.google.com ([209.85.215.169]:42765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMFRf-0007dB-Js for 54062@debbugs.gnu.org; Mon, 21 Feb 2022 15:38:08 -0500 Original-Received: by mail-pg1-f169.google.com with SMTP id d16so15223332pgd.9 for <54062@debbugs.gnu.org>; Mon, 21 Feb 2022 12:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=EVa1/6KZLwYFSXb6erM5Nc5PSQXgG0+LNUky711DIyQ=; b=b3J3yEdAI0/FuFG8x0NGpn7ltkQ1cY3RQEbUEljXmzE55GgmoFfFjNx5HxpSW+YuRQ kxMnaD2AL5oKgwyFZ3Pei58/h6fJlkx4GlbvrBlNm9Q5tD7iTHtT2+BL7p5aXjPVxF+x GrpsEKugmw2w2QXPhKx5Y+X5JSZ3MRdInyfsn3yOqZidH7YCHd8KG1p+vGONQDVeBK3v tMmg8vMLAVALdUKvRd7sUxsx9GyonDXvQ1+0F7y/2C7uT+e4P+fsSAVTXu4CZ7f5gBSo RozA6/8N+8k4C9ThfLhNEn2o0ivvSM21iVpk8DA+UbxIR1rRUJWds1rP+EcCFRsGfSxI mDVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=EVa1/6KZLwYFSXb6erM5Nc5PSQXgG0+LNUky711DIyQ=; b=idUXk780HbsC6pakwr/6cBidjibRwESXDduhd8RT6P8y9fksI4CRi3jVWitzJCWTgh Avu/4ACgwtarQUaXQyhY98Dto3b2IFUbtXAFRal7sUIPhVetisBNVvlWoPilHUyIScxe 6jFXFMYv+UdZguWByzGtr72vI2wthfWc004QkCyw76nBOb3uG3bLNYFy3qRr7/eibt9b 2U2l16k2eqsE5cJg0J8BUnYYKkDi7Q4DDz+bnmWWAzPRcjHfYv/tZ0AfxpLPLuQNFjWt +Ba5soNw7DNagEkGjmfDeE4P77546tMNA9oe6ULCNuQPGO5KLmW8/QGTphSkB1QaOT9n Miwg== X-Gm-Message-State: AOAM533ew1lN76at+2i5cvUhmR8Pc5Itt2xy0t++m6Udb3brFyzSYsmF 9S7teBY513kb54solrJzIXmttcowIBc= X-Google-Smtp-Source: ABdhPJwDDBmr0ebOgGMfBltSZTySNPv5hVIypV6XhsTBxwVcVUN3tkvY4WT1VcxTKjkuNzAl6FwHxw== X-Received: by 2002:a63:e744:0:b0:370:25a8:bfed with SMTP id j4-20020a63e744000000b0037025a8bfedmr17648402pgk.432.1645475881575; Mon, 21 Feb 2022 12:38:01 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id k18sm13772535pfi.10.2022.02.21.12.38.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 12:38:00 -0800 (PST) In-Reply-To: <835yp8ul58.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227385 Archived-At: This is a multi-part message in MIME format. --------------0D483DB86DAFD49FC8869D67 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2/21/2022 10:31 AM, Eli Zaretskii wrote: >> From: Lars Ingebrigtsen >> Cc: Jim Porter , 54062@debbugs.gnu.org >> Date: Mon, 21 Feb 2022 18:39:16 +0100 >> >> Eli Zaretskii writes: >> >>> Thanks; I have no further comments. >> >> So I've pushed the patch series to Emacs 29. > > Something's amiss here: the new test fails on MS-Windows because it > signals an error inside eshell-wait-for-subprocess: > > Test esh-proc-test/sigpipe-exits-process backtrace: > signal(eshell-pipe-broken #) > eshell-output-object-to-target("killed\n" #) > eshell-output-object("killed\n" nil [nil (nil . 0) (nil . 0)]) > #f(compiled-function () #)() > apply(#f(compiled-function () #) nil) > timer-event-handler([t 25107 54636 874750 nil #f(compiled-function ( > sleep-for(0.1) > sit-for(0.1) > (while (if all eshell-process-list (eshell-interactive-process-p)) ( > (let ((start (current-time))) (while (if all eshell-process-list (es > eshell-wait-for-subprocess(t) > > Sounds like the shell is already dead/killed when > eshell-wait-for-subprocess tries to send it a string? Thanks for merging, and sorry about the bustage. This turned out to be because `eshell-sentinel' for the "head" process in the pipeline called `eshell-output-object', but because the tail process was already dead, it raised `eshell-pipe-broken'. I believe the reason this only manifested on MS Windows was due to a timing difference between `delete-process' and `signal-process'; using the `delete-process' path on GNU/Linux shows the same problem. Attached is a patch that ignores the `eshell-pipe-broken' error in `eshell-sentinel'. It's not really an error in that case anyway, since we only want to write the last bit of output *if we can*. -------------------- There's just one problem remaining: when running the following command on MS Windows[1], you'll (usually) see two Eshell prompts get emitted after it finishes: yes | sh -c 'read NAME' However, this is a separate bug that appears in Emacs 27.2 as well. It can happen whenever multiple commands in a pipeline get killed. For example: ~ $ sh -c 'while true; do sleep 1; echo y; done' | sh -c 'while true; do read NAME; echo ${NAME}; done' C-c C-c ; Call `eshell-interrupt-process' The same happens with C-c C-k (`eshell-kill-process') too. I'll file another bug about this, but I wanted to mention it here so no one's surprised if they see this come up when testing out this patch. [1] Well, I assume it's a problem on MS Windows. I actually tested the MS Windows code path on GNU/Linux. --------------0D483DB86DAFD49FC8869D67 Content-Type: text/plain; charset=UTF-8; name="0001-Ignore-eshell-broken-pipe-error-in-eshell-sentinel.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Ignore-eshell-broken-pipe-error-in-eshell-sentinel.patc"; filename*1="h" RnJvbSBmNDFiOWUyNTk5ZmUzYTFhOTU5ZWYxYjUyZjc3MDMyZmQ4ZDI4YzIwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMjEgRmViIDIwMjIgMTI6MTQ6MzQgLTA4MDAKU3ViamVjdDogW1BB VENIXSBJZ25vcmUgJ2VzaGVsbC1icm9rZW4tcGlwZScgZXJyb3IgaW4gJ2VzaGVsbC1zZW50 aW5lbCcKClRoaXMgY2FuIGhhcHBlbiBpZiAnZXNoZWxsLXNlbnRpbmVsJyB0cmllcyB0byB3 cml0ZSBvdXRwdXQgdG8gYW5vdGhlcgpwcm9jZXNzLCBidXQgdGhhdCBwcm9jZXNzIGhhcyBh bHJlYWR5IHRlcm1pbmF0ZWQuCgoqIGxpc3AvZXNoZWxsL2VzaC1wcm9jLmVsIChlc2hlbGwt c2VudGluZWwpOiBVc2UgJ2lnbm9yZS1lcnJvcicKaW5zdGVhZCBvZiAndW53aW5kLXByb3Rl Y3QnLgotLS0KIGxpc3AvZXNoZWxsL2VzaC1wcm9jLmVsIHwgMTIgKysrKysrLS0tLS0tCiAx IGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1wcm9jLmVsIGIvbGlzcC9lc2hlbGwvZXNoLXByb2Mu ZWwKaW5kZXggZWQzN2RlODVmNy4uZDdkMjJkMmE5ZSAxMDA2NDQKLS0tIGEvbGlzcC9lc2hl bGwvZXNoLXByb2MuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLXByb2MuZWwKQEAgLTQzNSwx MiArNDM1LDEyIEBAIGVzaGVsbC1zZW50aW5lbAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChsYW1iZGEgKCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChpZiAobnRoIDQgZW50cnkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKHJ1bi1hdC10aW1lIDAgbmlsIGZpbmlzaC1pbykKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKHVud2luZC1wcm90ZWN0Ci0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAod2hlbiBzdHIKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGVzaGVsbC1vdXRwdXQtb2JqZWN0Ci0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHIgbmlsIGhh bmRsZXMpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlc2hl bGwtY2xvc2UtaGFuZGxlcwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzdGF0dXMgJ25pbCBoYW5kbGVzKSkpKSkpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICh3aGVuIHN0cgorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIChpZ25vcmUtZXJyb3IgJ2VzaGVsbC1waXBlLWJyb2tlbgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGVzaGVsbC1vdXRwdXQtb2Jq ZWN0CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RyIG5p bCBoYW5kbGVzKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChl c2hlbGwtY2xvc2UtaGFuZGxlcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgc3RhdHVzICduaWwgaGFuZGxlcykpKSkpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgIChmdW5jYWxsIGZpbmlzaC1pbykpKSkpCiAJCShlc2hlbGwtcmVtb3ZlLXByb2Nlc3Mt ZW50cnkgZW50cnkpKSkpCiAJKGVzaGVsbC1raWxsLXByb2Nlc3MtZnVuY3Rpb24gcHJvYyBz dHJpbmcpKSkpKQotLSAKMi4yNS4xCgo= --------------0D483DB86DAFD49FC8869D67--