unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 39379@debbugs.gnu.org
Subject: bug#39379: 27.0.60; Fix for #38457 broke ido-vertical-mode
Date: Sun, 2 Feb 2020 13:58:36 +0000	[thread overview]
Message-ID: <71c2898c-aca7-ea92-e7d2-f4fd122b566d@gmail.com> (raw)
In-Reply-To: <83a762k9p2.fsf@gnu.org>


On 01/02/2020 08:12, Eli Zaretskii wrote:
>> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
>> Date: Fri, 31 Jan 2020 23:53:19 +0000
>>
>> Fix for #38457, commit 3b0938c0420de2b845e7e8f8fbbb57ddc61718f2, seems
>> to have broken ido-vertical-mode and perhaps other minor modes that uses
>> similar techniques to render a custom ido completion list. Is there
>> another fix possible, or better yet, introduce a new overridable
>> function that controls how the prompt is displayed?
>>
>> https://github.com/creichert/ido-vertical-mode.el/issues/48
> Please show a recipe to reproduce the problem.  I don't use
> ido-vertical-mode, and the issue you point to doesn't provide any
> description of the actual problem, either.  So it's unclear what
> exactly was broken by that commit and why.
>
> Thanks.

Steps for reproduction:

1. $ echo "(ido-mode)(require 'ido-vertical-mode)(ido-vertical-mode)" >
.emacs

2. $ emacs

3. C-x C-f

4. The Find file prompt is missing since that commit.

I've also attached screenshots here.

https://github.com/creichert/ido-vertical-mode.el/issues/48#issuecomment-581033055






  reply	other threads:[~2020-02-02 13:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 23:53 bug#39379: 27.0.60; Fix for #38457 broke ido-vertical-mode Jimmy Yuen Ho Wong
2020-02-01  8:12 ` Eli Zaretskii
2020-02-02 13:58   ` Jimmy Yuen Ho Wong [this message]
2020-02-02 16:13     ` Eli Zaretskii
2020-02-02 17:23       ` Eli Zaretskii
2020-02-02 18:06         ` Eli Zaretskii
2020-02-02 18:38           ` Eli Zaretskii
2020-02-02 21:33             ` Jimmy Yuen Ho Wong
2020-02-03  3:21               ` Eli Zaretskii
2020-02-03 13:19               ` Dmitry Gutov
2020-02-03 15:40                 ` Eli Zaretskii
2020-02-03 21:51                   ` Dmitry Gutov
2020-02-04  3:27                     ` Eli Zaretskii
2020-02-04 13:19                       ` Dmitry Gutov
2020-02-04 15:40                         ` Eli Zaretskii
2020-02-04 23:55                           ` Dmitry Gutov
2020-02-05  3:36                             ` Eli Zaretskii
2020-02-10 15:44           ` Eli Zaretskii
2020-02-11 23:42             ` Dmitry Gutov
2020-02-12 18:18               ` Eli Zaretskii
2020-02-12 18:24                 ` Dmitry Gutov
2020-02-12 19:42                   ` Eli Zaretskii
2020-03-03 14:02                   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71c2898c-aca7-ea92-e7d2-f4fd122b566d@gmail.com \
    --to=wyuenho@gmail.com \
    --cc=39379@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).