From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60025: [PATCH] Add go-ts-mode and go-mod-ts-mode Date: Tue, 13 Dec 2022 18:22:11 -0800 Message-ID: <71C3BCE2-C63A-4705-B598-0725FF5438A6@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37839"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , theo@thornhill.no, 60025@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 14 03:23:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5HQP-0009eF-FO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Dec 2022 03:23:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5HQF-0007pa-M2; Tue, 13 Dec 2022 21:23:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5HQE-0007pS-Pp for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 21:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5HQE-0004Ih-Gh for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 21:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5HQE-0000QB-2l for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 21:23:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Dec 2022 02:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60025-submit@debbugs.gnu.org id=B60025.16709845401608 (code B ref 60025); Wed, 14 Dec 2022 02:23:02 +0000 Original-Received: (at 60025) by debbugs.gnu.org; 14 Dec 2022 02:22:20 +0000 Original-Received: from localhost ([127.0.0.1]:36027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5HPY-0000Ps-0H for submit@debbugs.gnu.org; Tue, 13 Dec 2022 21:22:20 -0500 Original-Received: from mail-pg1-f170.google.com ([209.85.215.170]:42750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5HPW-0000Pf-P0 for 60025@debbugs.gnu.org; Tue, 13 Dec 2022 21:22:19 -0500 Original-Received: by mail-pg1-f170.google.com with SMTP id h33so1087959pgm.9 for <60025@debbugs.gnu.org>; Tue, 13 Dec 2022 18:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=kMIocUv8o8OVgHNKnHhBSvlWPOwhILlN3LZvnoCQ45Y=; b=oVrVD9kmhx5aEFH3onwrD7b3zJ0KA44vIva2TUxkJNjgZfpydgmUAs1hCBAAFo4TG0 wVpPe9qWgpeYwSyUee9Nu2ZAl3uLMuGH/ke8S3Q2+DikU57NVcRKF1eRMvJBHofPuseQ yx1TCZBK3oL12n0qvJjyhyOvaTNlq5oH/7YxeUO/dh3/hRVvjWRkgBBy6cmSaqco6By9 z26+JN+H3jXIDL3JerN311E66Ek2KJUx5PBTbjI+L08dSN0p3tBmcmZ7ccvu40x+/JDD XlprvL2D/ubzitmfOifJl+YoYMigZ9EWpLF4qgFtrU9mo7V0LhIQ10lOa7ISBy6CYtNn wf6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kMIocUv8o8OVgHNKnHhBSvlWPOwhILlN3LZvnoCQ45Y=; b=vQAb/NArUTFzVt0Aq56A4BlwJOSo+1AEEOLtGZPP5C3EMhynMNqKATNfvZGgsaW59K zHjDP4vsmC1Wk4pQjHpRkBdIp4ougnSu12P3bcUwi9rGYyUoGSB2zlCkQmTagpy76VLy o4LDvW2P9Rh4M11vizr4KPLBawD8TtZVxwA+7Do+6ZeLbA3opX+J+QoGPZBktYopH3bu JcaEeqyraiyy+v4lCw/PzrSfdGRGz0lpWC5riABl1CLFsfWWm7grcLaOqjOj+1mS7bML +0BdU5v2xtvwSO7a+1mb9rq4OonQcmahdk8p6lz3BZ4s03sG14rhHf5cR1CJ28jr8/tp gHtA== X-Gm-Message-State: ANoB5pnqRL+v9+S6i2TX4I67ZMroc47Jgs2EV4Fw1yTZ6lqYlUU7AVVM CQZb4tj584KDS0AVHg40kro= X-Google-Smtp-Source: AA0mqf45fJ2xuP59TMzP2Xw/rwCjqYjNM+t6cear8hsOt4s6leJC3RZ290HlqiCHA+FOQxF/AFynaA== X-Received: by 2002:a62:e519:0:b0:575:bf29:d1e0 with SMTP id n25-20020a62e519000000b00575bf29d1e0mr25023177pff.26.1670984532915; Tue, 13 Dec 2022 18:22:12 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id v7-20020aa799c7000000b0055f209690c0sm8294198pfi.50.2022.12.13.18.22.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Dec 2022 18:22:12 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250910 Archived-At: Randy Taylor writes: > On Tuesday, December 13th, 2022 at 07:25, Eli Zaretskii = wrote:=20 >>=20 >> > Cc: casouri@gmail.com, theo@thornhill.no >>=20 >> > Date: Tue, 13 Dec 2022 02:13:47 +0000 >> > From: Randy Taylor dev@rjt.dev >> >=20 >> > --- a/etc/NEWS >> > +++ b/etc/NEWS >> > @@ -3078,6 +3078,11 @@ A major mode based on the tree-sitter = library for editing CMake files. >> > It includes support for font-locking, indentation, Imenu, and >> > which-func. >> >=20 >> > +** New major modes 'go-ts-mode' and 'go-mod-ts-mode'. >> > +Major modes based on the tree-sitter library for editing programs = in >> > +the Go language. It includes support for font-locking, = indentation, >> > +Imenu, and which-func. >>=20 >>=20 >> This should say something about go-mod-ts-mode, at least which files >> it's supposed to support and for what purpose. > > Indeed, thanks. I decided to split them up, and I also added that they = will be auto-enabled. > >> > +(add-to-list 'auto-mode-alist '("go\\.mod\\'" . go-mod-ts-mode)) >>=20 >>=20 >> Aren't the files's base name always exactly "go.mod" and nothing = else? >> If so, the regexp should be augmented, because we don't want to use >> this moder for, say, foogo.mod or fubar-go.mod, right? > > Oops, that's right. Good catch. Looks pretty good to me :-) Yuan