From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jacob Faibussowitsch Newsgroups: gmane.emacs.bugs Subject: bug#49877: [Emacs 28.0.50 Trunk] *ERROR*: No applicable method: frame-creation-function Date: Fri, 6 Aug 2021 08:55:42 -0400 Message-ID: <715D80C2-F959-404A-AE41-9737E62CDCCD@gmail.com> References: <1DD4A5FD-DB2F-4780-AA3F-8E3D656FFB7B@gmail.com> <87o8acgn69.fsf@gnus.org> <2A23BAE4-107B-40D8-A341-493BCB2CE956@gmail.com> <87pmuqc3fl.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_0D61CEC3-8C58-45D5-A64F-A6918075FB75" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17502"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , 49877@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 06 14:56:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBzOa-0004Kf-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Aug 2021 14:56:16 +0200 Original-Received: from localhost ([::1]:32842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBzOY-0002Lo-Mt for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Aug 2021 08:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBzOL-0002Jr-W2 for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 08:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBzOL-0004jT-Ph for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 08:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBzOL-0000qm-O2 for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 08:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jacob Faibussowitsch Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Aug 2021 12:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 49877-submit@debbugs.gnu.org id=B49877.16282545523251 (code B ref 49877); Fri, 06 Aug 2021 12:56:01 +0000 Original-Received: (at 49877) by debbugs.gnu.org; 6 Aug 2021 12:55:52 +0000 Original-Received: from localhost ([127.0.0.1]:49447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBzOB-0000qN-I0 for submit@debbugs.gnu.org; Fri, 06 Aug 2021 08:55:52 -0400 Original-Received: from mail-qv1-f52.google.com ([209.85.219.52]:36557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBzO8-0000q3-Vo for 49877@debbugs.gnu.org; Fri, 06 Aug 2021 08:55:50 -0400 Original-Received: by mail-qv1-f52.google.com with SMTP id dk2so4816647qvb.3 for <49877@debbugs.gnu.org>; Fri, 06 Aug 2021 05:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=+RfCle5HAaal+aA/ncXRIiAGRIG4GSwBbDLXibYfekI=; b=Gd8ZgT4khm6UxmoJdGQUFnMlEYTjl9vtkzItSMB6cIwhfa/1WWMLjryY4dwyemitJu 7leYR9IuZNXekygyk1NahG0o6ZmhECnr49FsOlakkxtAzLnrOP5YefVxfohBtSwVm9F0 5R8oyQqdkVfPcyHYvt4KC72STYDfBUl5XzvcMf7VPJb1I7qLONVeLgQyf+SqSsL4KGnJ jFMTX+RN3DteDN7AefbgdUSOS9uqryH9w7kmXLplRyVmfoZJ7SrhyO4G5s0rYhRy8qjC MYUca8XVtHzfXbQxl/R0cNTgyx5JTBLi0bQV/Bt21XDdA5VLrs3wnjnzHGPUjKV8eitT 77Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=+RfCle5HAaal+aA/ncXRIiAGRIG4GSwBbDLXibYfekI=; b=Ons0WRFVcni49QqLRVhgDXxmbpcdjCYctP8ORvB4eZG0KQ2aq4vkj8lezK+/Pa2QT0 Ex5E5LxxrFaIAHZWKUGHXqvVepjb+1yiizISeA3D1Eh5obGyaDYwTxFS5tBKTTYVzn3e S9mfvnWhv+cCBW353ba8tsXLk0M3iGyDIv3cgdHbw9llvqRP7qPXuy6DKzxJ+fVdgcLI sruLcuKi2+obSxpw6M4wMSxCZvgIWcBeKaa4Fmv/jkqGYCzF8TicAxApY9apjkVOTsiB Jt4WKQks/o0QwgV5Sz+pGfR3twetodyvgdpWPCvTKPrLUPi/cCdu43fhM6tOi/QjWBTP 4Mcg== X-Gm-Message-State: AOAM530xxWGpeNHs6LKXrSU6xleko2prR3VzSCpOA11GvXMbx5pWZ/nV kHPYMLjGgcKqGHEZsp/eqTs= X-Google-Smtp-Source: ABdhPJytKB3zx2NIFBpeY+HNKV++zwUVrJ4H/HR/nM2ZqEYFJPRUeeYWsElfp3p+1yxv2YLtjWKpXg== X-Received: by 2002:ad4:5b8a:: with SMTP id 10mr10872976qvp.48.1628254543341; Fri, 06 Aug 2021 05:55:43 -0700 (PDT) Original-Received: from smtpclient.apple (pool-71-251-8-32.nycmny.fios.verizon.net. [71.251.8.32]) by smtp.gmail.com with ESMTPSA id 71sm2844786qkk.26.2021.08.06.05.55.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Aug 2021 05:55:42 -0700 (PDT) In-Reply-To: <87pmuqc3fl.fsf@gnus.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211332 Archived-At: --Apple-Mail=_0D61CEC3-8C58-45D5-A64F-A6918075FB75 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > I'm still not able to reproduce the problem, but a different user > reported exactly the same problem... which then went away. So > something's definitely going on here. Ok so on a whim I went and started bisecting my init file, and lo and = behold it turns out there is some sort of subtle interaction with doom = mode-line. Specifically, I configure it via: (use-package-select doom-modeline :after all-the-icons :hook (after-init . doom-modeline-mode) :config (column-number-mode 1) :custom (doom-modeline-icon t) (doom-modeline-project-detection =E2=80=98project) <=E2=80=94=E2=80=94=E2= =80=94 commenting out this line fixes the problem (doom-modeline-major-mode-icon t) (doom-modeline-major-mode-color-icon t) (doom-modeline-buffer-state-icon t) (doom-modeline-buffer-modification-icon t) (doom-modeline-unicode-fallback nil) (doom-modeline-modal-icon t) (doom-modeline-minor-modes nil) (doom-modeline-indent-info nil) (doom-modeline-lsp t)) So somehow this new eql change is related to the project root detection? = I tried byte-compiling doom modeling again to see if perhaps there is an = additional warning triggered, but the only warning emitted was In doom-modeline--project-root: doom-modeline-core.el:1193:26: Warning: =E2=80=98project-roots=E2=80=99 = is an obsolete function (as of 0.3.0); use =E2=80=98project-root=E2=80=99 = instead. =46rom this function: (defun doom-modeline--project-root () "Get the path to the root of your project. Return nil if no project was found." (or doom-modeline--project-root (setq doom-modeline--project-root (pcase doom-modeline-project-detection ('ffip (when (fboundp 'ffip-get-project-root-directory) (let ((inhibit-message t)) (ffip-get-project-root-directory)))) ('projectile (when (fboundp 'projectile-project-root) (projectile-project-root))) ('project (when (fboundp 'project-current) (when-let ((project (project-current))) (car (project-roots project))))))))) = <=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94 here Best regards, Jacob Faibussowitsch (Jacob Fai - booss - oh - vitch) > On Aug 6, 2021, at 05:45, Lars Ingebrigtsen wrote: >=20 > Jacob Faibussowitsch writes: >=20 >> Is this with a fresh >> checkout (or "make bootstrap")? >>=20 >> I=E2=80=99m not sure I follow, what is the difference? >=20 > Sorry, that was unclear. I meant that as an inclusive or, and as > opposed to doing an incremental build. >=20 >> I am able to reproduce/build emacs via: >>=20 >> 1. git checkout master >> 2. make clean >> 3. ./reconfigure.sh (attached) >> 3. make all >=20 > I'm still not able to reproduce the problem, but a different user > reported exactly the same problem... which then went away. So > something's definitely going on here. >=20 > So I've added Stefan to the CCs -- could you take a look at this? It > looks like a possible problem with the recent eql changes, but is > weirdly difficult to reproduce. =20 >=20 > diff --git a/lisp/frame.el b/lisp/frame.el > index 9b3d120598..8c05ad2fe5 100644 > --- a/lisp/frame.el > +++ b/lisp/frame.el > @@ -36,7 +36,11 @@ as its argument.") > (cl-generic-define-context-rewriter window-system (value) > ;; If `value' is a `consp', it's probably an old-style specializer, > ;; so just use it, and anyway `eql' isn't very useful on cons cells. > - `(window-system ,(if (consp value) value `(eql ,value)))) > + `(window-system ,(if (consp value) value > + ;; WARNING: unsure whether this eql expression > + ;; is actually an eql specializer. > + ;; Bug #47327 > + `(eql ',value)))) >=20 >=20 > --=20 > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no --Apple-Mail=_0D61CEC3-8C58-45D5-A64F-A6918075FB75 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
I'm still not able to = reproduce the problem, but a different user
reported = exactly the same problem...  which then went away.  So
something's definitely going on here.

Ok so on a whim I went and started = bisecting my init file, and lo and behold it turns out there is some = sort of subtle interaction with doom mode-line. Specifically, I = configure it via:

(use-package-select doom-modeline
  :after = all-the-icons
  :hook (after-init . = doom-modeline-mode)
  :config
  = (column-number-mode 1)
  :custom
  = (doom-modeline-icon t)
  = (doom-modeline-project-detection =E2=80=98project) <=E2=80=94=E2=80=94=E2= =80=94 commenting out this line fixes the problem
  = (doom-modeline-major-mode-icon t)
  = (doom-modeline-major-mode-color-icon t)
  = (doom-modeline-buffer-state-icon t)
  = (doom-modeline-buffer-modification-icon t)
  = (doom-modeline-unicode-fallback nil)
  = (doom-modeline-modal-icon t)
  = (doom-modeline-minor-modes nil)
  = (doom-modeline-indent-info nil)
  (doom-modeline-lsp = t))

So somehow this new eql change is = related to the project root detection? I tried byte-compiling doom = modeling again to see if perhaps there is an additional warning = triggered, but the only warning emitted was

In doom-modeline--project-root:
doom-modeline-core.el:1193:26: Warning: =E2=80=98project-roots=E2= =80=99 is an obsolete function (as of 0.3.0); use = =E2=80=98project-root=E2=80=99 instead.

=46rom this function:

(defun = doom-modeline--project-root ()
  "Get the path to the = root of your project.
Return nil if no project was = found."
  (or doom-modeline--project-root
      (setq doom-modeline--project-root
            (pcase = doom-modeline-project-detection
      =         ('ffip
      =          (when (fboundp = 'ffip-get-project-root-directory)
      =            (let ((inhibit-message t))
                =    (ffip-get-project-root-directory))))
  =             ('projectile
               (when = (fboundp 'projectile-project-root)
      =            (projectile-project-root)))
              ('project
               (when = (fboundp 'project-current)
        =          (when-let ((project = (project-current)))
          =          (car (project-roots project))))))))) = <=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94 = here

Best regards,

Jacob = Faibussowitsch
(Jacob Fai - booss - oh - vitch)

On Aug 6, 2021, at 05:45, Lars Ingebrigtsen <larsi@gnus.org> = wrote:

Jacob Faibussowitsch <jacob.fai@gmail.com> writes:

Is this with a fresh
checkout (or "make bootstrap")?

I=E2=80=99m not sure I follow, what is the difference?

Sorry, that was unclear.  I = meant that as an inclusive or, and as
opposed to doing an = incremental build.

I am able to reproduce/build emacs via:

1. git checkout master
2. make clean
3. ./reconfigure.sh (attached)
3. make all

I'm still not able to reproduce = the problem, but a different user
reported exactly the = same problem...  which then went away.  So
something's definitely going on here.

So I've added Stefan to the CCs -- could you take a look at = this?  It
looks like a possible problem with the = recent eql changes, but is
weirdly difficult to reproduce. =  

diff --git a/lisp/frame.el = b/lisp/frame.el
index 9b3d120598..8c05ad2fe5 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -36,7 +36,11 @@ as its argument.")
(cl-generic-define-context-rewriter window-system (value)
;; If `value' is a `consp', it's probably an old-style = specializer,
;; so just use it, and anyway `eql' isn't = very useful on cons cells.
- `(window-system ,(if (consp = value) value `(eql ,value))))
+ `(window-system ,(if = (consp value) value
+ ;; WARNING: unsure whether this eql = expression
+ ;; is actually an eql specializer.
+ ;; Bug #47327
+ `(eql ',value))))


--
(domestic = pets only, the antidote for overdose, milk.)
=   bloggy blog: http://lars.ingebrigtsen.no

= --Apple-Mail=_0D61CEC3-8C58-45D5-A64F-A6918075FB75--