From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 34949@debbugs.gnu.org
Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete
Date: Wed, 25 Mar 2020 23:59:46 +0200 [thread overview]
Message-ID: <7124e9e5-bf3a-5bba-d9f9-9d0867444e4c@yandex.ru> (raw)
In-Reply-To: <87y2rpqt28.fsf@mail.linkov.net>
On 25.03.2020 00:36, Juri Linkov wrote:
> Finally settled with the following patch.
LGTM, thank you.
> Often this is a minor problem, but given the above, a keybinding
> like `* u' should be of a little help.
The follow-up patch from the next email look good as well.
> - (bindings--define-key map [vc-dir]
> - '(menu-item "VC Dir" vc-dir
> - :help "Show the VC status of files in a directory"))
> + (bindings--define-key map [vc-dir-root]
> + '(menu-item "VC Dir" vc-dir-root
> + :help "Show the VC status of the repository"))
This part, though... Is it intentional?
I'm all for it personally, but:
- It will need a NEWS entry.
- Are we comfortable with changing the menu entry to the new command,
but keeping the old key binding pointing to the old command? Looks a bit
inconsistent.
next prev parent reply other threads:[~2020-03-25 21:59 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 17:50 bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Philipp Stephani
2019-10-09 22:40 ` Lars Ingebrigtsen
2019-12-24 19:53 ` Dmitry Gutov
2019-12-24 23:28 ` Juri Linkov
2020-02-17 23:42 ` Juri Linkov
2020-02-18 22:27 ` Dmitry Gutov
2020-02-18 23:36 ` Juri Linkov
2020-02-20 23:14 ` Juri Linkov
2020-02-21 0:22 ` Dmitry Gutov
2020-02-23 0:04 ` Juri Linkov
2020-02-23 9:01 ` Dmitry Gutov
2020-02-23 23:25 ` Juri Linkov
2020-02-24 0:17 ` Dmitry Gutov
2020-02-25 0:12 ` Juri Linkov
2020-02-25 10:32 ` Dmitry Gutov
2020-02-25 21:23 ` Juri Linkov
2020-02-26 22:49 ` Dmitry Gutov
2020-02-26 23:46 ` Juri Linkov
2020-02-27 7:28 ` Dmitry Gutov
2020-02-27 23:15 ` Juri Linkov
2020-02-28 19:22 ` Dmitry Gutov
2020-02-29 21:25 ` Juri Linkov
2020-02-29 22:25 ` Dmitry Gutov
2020-03-09 22:55 ` Juri Linkov
2020-03-12 0:08 ` Dmitry Gutov
2020-03-12 0:41 ` Juri Linkov
2020-03-12 22:43 ` Juri Linkov
2020-03-13 12:11 ` Dmitry Gutov
2020-03-14 23:31 ` Juri Linkov
2020-03-15 21:54 ` Dmitry Gutov
2020-03-15 23:58 ` Juri Linkov
2020-03-16 20:17 ` Dmitry Gutov
2020-03-24 22:16 ` Juri Linkov
2020-03-25 20:47 ` Juri Linkov
2020-03-25 21:32 ` Dmitry Gutov
2020-03-29 22:35 ` Juri Linkov
2020-03-30 19:53 ` Dmitry Gutov
2020-03-24 22:36 ` Juri Linkov
2020-03-25 20:59 ` Juri Linkov
2020-03-25 21:15 ` Drew Adams
2020-03-25 21:50 ` Juri Linkov
2020-03-25 22:04 ` Drew Adams
2020-03-26 23:18 ` Juri Linkov
2020-03-27 16:11 ` Drew Adams
2020-03-27 22:41 ` Dmitry Gutov
2020-03-28 23:54 ` Juri Linkov
2020-03-29 18:41 ` Dmitry Gutov
2020-03-29 22:27 ` Juri Linkov
2020-03-30 20:01 ` Dmitry Gutov
2020-03-30 22:40 ` Juri Linkov
2020-03-30 23:22 ` Dmitry Gutov
2020-03-31 1:02 ` Drew Adams
2020-04-02 22:08 ` Juri Linkov
2020-04-03 0:21 ` Dmitry Gutov
2020-04-03 20:08 ` Philipp Stephani
2020-04-04 23:37 ` Juri Linkov
2020-04-05 9:47 ` Philipp Stephani
2020-04-05 23:05 ` Juri Linkov
2020-04-09 8:41 ` Eli Zaretskii
2020-04-11 23:38 ` Juri Linkov
2020-04-12 6:33 ` Eli Zaretskii
2020-04-12 23:51 ` Juri Linkov
2020-04-13 4:31 ` Eli Zaretskii
2020-04-13 23:25 ` Juri Linkov
2020-03-25 21:59 ` Dmitry Gutov [this message]
2020-03-26 23:10 ` Juri Linkov
2020-03-26 23:51 ` Dmitry Gutov
2020-02-21 0:16 ` Dmitry Gutov
2019-12-25 21:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7124e9e5-bf3a-5bba-d9f9-9d0867444e4c@yandex.ru \
--to=dgutov@yandex.ru \
--cc=34949@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).