From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#71518: 30.0.50; Errors during redisplay with c++-ts-mode Date: Wed, 12 Jun 2024 23:51:21 -0700 Message-ID: <7108109B-3AFB-4623-890E-1E19903FA0D0@gmail.com> References: <865xue1gtu.fsf@gnu.org> <26599430.1r3eYUQgxm@3-191.divsi.unimi.it> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14644"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71518@debbugs.gnu.org, eliz@gnu.org To: Vincenzo Pupillo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 13 08:52:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHeK1-0003Xp-Fq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jun 2024 08:52:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHeJa-0001B4-Mw; Thu, 13 Jun 2024 02:52:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHeJX-00019A-5z for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 02:52:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHeJW-0003J8-UC for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 02:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sHeJW-0002bh-3z for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 02:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jun 2024 06:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71518 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: 71518@debbugs.gnu.org, Bug Report Emacs , Eli Zaretskii Original-Received: via spool by submit@debbugs.gnu.org id=B.17182615019961 (code B ref -1); Thu, 13 Jun 2024 06:52:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Jun 2024 06:51:41 +0000 Original-Received: from localhost ([127.0.0.1]:56602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHeJA-0002aX-SW for submit@debbugs.gnu.org; Thu, 13 Jun 2024 02:51:41 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:42370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHeJ9-0002aN-0P for submit@debbugs.gnu.org; Thu, 13 Jun 2024 02:51:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHeJ9-00017k-E2 for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 02:51:39 -0400 Original-Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHeJ7-0003Hz-Ol; Thu, 13 Jun 2024 02:51:39 -0400 Original-Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-6c702226b0aso1268928a12.1; Wed, 12 Jun 2024 23:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718261495; x=1718866295; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=znZcxYZlWsT8em/DfG+FR1Iu6jt0BUT519yYnWV3YX8=; b=CFzVgmdtQVctB1FnptxMe6/mlklVwfxVTx0vUH5jPFqecSTFbkm8/v9MF8ZXbTKu65 TK9fqOCDFQpwqA0DkYyz6/xw+F4Y5X4pV3Ua8SvzTZUkvKqk4t0ZRSHLlsByXn7LYN0Q qEqrBU8h6EkEdvcKZ22y6KU3VDwL+yYDCvz0zT8Y5r6p/SqAuFqTvcHkoycK9aTBzJez HITQr2xjNqrtTRY/ZXyfKgjjfRbxdILcN8WQqQAqXNEE7nbdEa12ux5qwRe9/kTkjc/H CY8pJoDSduWXL12g4PqQD2vc/ZgWzOwSiIutn17OIuqEZdjc/cutZdWz96jgqz7xCkFF EYqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718261495; x=1718866295; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=znZcxYZlWsT8em/DfG+FR1Iu6jt0BUT519yYnWV3YX8=; b=GLbyn5juDRck9akE0gYzMOb1MPOms1uQaqGee+7Y56d9LCtKCuL70ofxbDpe0noG5u os5j37KrWIGc6XAyaW2bIZgV+UnOi4rQtcc3xeHHCbNrHLEv3ZgKAzbp+bEQt8svqGKX ua03r4CzBJgN5Sx4fQFHL9wo53etnI6AEk0CxfVuqIsL1JRDlVsu0DPWR+yMqwfHOvuO GRMK6wRWZCyCH/weu7DbGqC7hnGhi239Z4iu/7nQ50I8s3H0Q5ZCexni7eOPq77VCJ+2 /21EuiIbvXKRYdtH3IYfZQnX+ry4FFfkrK2BHOU4t136MceA0KA5wPl4KfZO4ClEzlAy D4WA== X-Forwarded-Encrypted: i=1; AJvYcCUj/F0Cmmd0SecQr0RtJKMLlJ35DbX6LKk9Mf9lW+KxcBjYfaQ73gGVmIj0r2Pg7YACofLy8fwZnoZV+wrldN+gZ9HIelc/BMBH1MK6NzMCQD1UZw== X-Gm-Message-State: AOJu0YzWqVyKkmH8HDIeXqerj1hrfIorLXpobF1wUBynIdyfgf676pX1 A1Vq8xc/T3qYaM4QnP09xw65z8Bho1pUtvgPfGBc1RlvkaAVK03f X-Google-Smtp-Source: AGHT+IGEcveeAvzEPET5BF7X8yVrM0D15m7iIBKode9qyTIwYG+UrxaoSB7WXRy1XpG8lv0jdYvslQ== X-Received: by 2002:a17:90a:ca15:b0:2c1:dc60:d933 with SMTP id 98e67ed59e1d1-2c4bd9fc010mr2908863a91.19.1718261494465; Wed, 12 Jun 2024 23:51:34 -0700 (PDT) Original-Received: from smtpclient.apple ([98.47.187.88]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c4a75d207dsm3133617a91.12.2024.06.12.23.51.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 23:51:33 -0700 (PDT) In-Reply-To: <26599430.1r3eYUQgxm@3-191.divsi.unimi.it> X-Mailer: Apple Mail (2.3774.600.62) Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=casouri@gmail.com; helo=mail-pg1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287179 Archived-At: > On Jun 12, 2024, at 6:53=E2=80=AFAM, Vincenzo Pupillo = wrote: >=20 >=20 > In data mercoled=C3=AC 12 giugno 2024 14:33:17 CEST, Eli Zaretskii ha = scritto: >> To reproduce in "emacs -Q", visit some C++ source file (I used >> breakpoint.c from the GDB sources), then turn on c++-ts-mode. The >> fontification is all incorrect, and *Messages* has these error >> messages: >>=20 >> Error during redisplay: (jit-lock-function 7286) signaled = (treesit-query-error "Node type error at" 575 "[\"_Atomic\" \"break\" = \"case\" \"const\" \"continue\" \"default\" \"do\" \"else\" \"enum\" = \"extern\" \"for\" \"goto\" \"if\" \"inline\" \"register\" \"restrict\" = \"return\" \"sizeof\" \"static\" \"struct\" \"switch\" \"typedef\" = \"union\" \"volatile\" \"while\" \"and\" \"and_eq\" \"bitand\" \"bitor\" = \"catch\" \"class\" \"co_await\" \"co_return\" \"co_yield\" \"compl\" = \"concept\" \"consteval\" \"constexpr\" \"constinit\" \"decltype\" = \"delete\" \"explicit\" \"final\" \"friend\" \"mutable\" \"namespace\" = \"new\" \"noexcept\" \"not\" \"not_eq\" \"operator\" \"or\" \"or_eq\" = \"override\" \"private\" \"protected\" \"public\" \"requires\" = \"template\" \"throw\" \"try\" \"typename\" \"using\" \"virtual\" = \"xor\" \"xor_eq\"] @font-lock-keyword-face (auto) = @font-lock-keyword-face (this) @font-lock-keyword-face" "Debug the query = with `treesit-query-validate'") >>=20 >> This happens with the latest C++ tree-sitter grammar library. I = guess >> they made some incompatible change in the grammar or something? >>=20 >>=20 > Yes, they changed the grammar.=20 > https://github.com/tree-sitter/tree-sitter-cpp/issues/271 >=20 > V. So it seems =E2=80=9Cvirtual=E2=80=9D is now a named node rather than an = anonymous node, which is a little odd. I asked the author about it in = the GitHub issue, let me clear that up before fixing c-ts-mode. And, Eli, we really really should pin tree-sitter grammars. As more = people start using tree-sitter modes, they will found out about the = breakage before we do and the tree-sitter major mode would be unusable = for them before they upgrade their grammar. Most of them will not know = how to do it and which commit to downgrade to. And I really don=E2=80=99t = want to chase the random changes these grammars make all the time. = Fixing for these breakages is arguably a heavier maintenance burden than = pinning tree-sitter grammars. Yuan=20=