From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Date: Wed, 05 May 2021 08:09:04 +0000 Message-ID: <70f2eadd5f48937bb057@heytings.org> References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21510"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48153@debbugs.gnu.org To: Jimmy Yuen Ho Wong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 10:10:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leCbw-0005Tr-HT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 10:10:24 +0200 Original-Received: from localhost ([::1]:59360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leCbv-0001E9-JM for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 04:10:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leCbc-0001CQ-Ta for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 04:10:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leCba-0004hZ-GY for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 04:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leCba-0005Ih-9Y for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 04:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 08:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162020214920192 (code B ref 48153); Wed, 05 May 2021 08:10:02 +0000 Original-Received: (at 48153) by debbugs.gnu.org; 5 May 2021 08:09:09 +0000 Original-Received: from localhost ([127.0.0.1]:58457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leCai-0005Fc-Ro for submit@debbugs.gnu.org; Wed, 05 May 2021 04:09:09 -0400 Original-Received: from heytings.org ([95.142.160.155]:38270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leCag-0005FK-4C for 48153@debbugs.gnu.org; Wed, 05 May 2021 04:09:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620202144; bh=5oDmrCxwDIkeVIFjrX71G80w+/QW4M3m2GHiDAh4Hx8=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Z2oskSilOdFgMlUHe5xaqMTDeUZGCZO/5eIFJbYxgkwEa5CB3wIz4DIOFTiyRhfQX rxfpIRgG3nK1eeRliFzcXSKC/KEQW22V90aws24CDhazbkkpcUTYqohzKClYqbs2Qk ivytzi/7O+EUzYY/gtWFd5Ev23+h/YY75jMdlnSSiyXMYAlABV7Ej9vagQZtt+XsH2 DP+d1A35wqg7z3mwhIfrcgZoSYUWTAvo0wYp8o0EAVCb1a1JBQeeapKTE2COHwje/g QUoGS0zk4JZ5/Nt6MQkUFzrkhiUyDaCE/3Fnvsu0VfWxHlY3brqaAMdi0PO/ugEzhm XUhGuSSYPwcLQ== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205662 Archived-At: > > Second of all, in order to get the key map bindings to > read-from-minibuffer overridden on emacs 27, it requires quitting from > switch-to-buffer, and then C-x b C-h b again to see that C-k is bound to > `bad`. In other words, on emacs 27, one has to pop up the minibuffer > twice. On emacs 28, just opening the minibuffer the first time will see > the key bindings overridden. I guess this is why I say this is a > regression on emacs 28 but you said you couldn't reproduce it. I think > both versions are wrong, it's just on emacs 28, it's wrong in a more > obvious way. > Okay, now I finally see what you mean (and I can reproduce it). Indeed this is a recent change in the handling of minibuffers, the first time the minibuffer is entered is not anymore different from the other times. > > In any case, I'm not sure if the minor mode maps should override the key > bindings in the keymap given to read-from-buffer. > Why would they not? The minibuffer behaves, in that respect, like any other buffer. Note that they do so only when the minor mode is enabled in the minibuffer. With the example init file, using (define-global-minor-mode test-global-mode test-mode (lambda () (or (minibufferp) (test-mode 1)))) works as you want it with both Emacs 27 and 28.