From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 59459@debbugs.gnu.org, 59459-done@debbugs.gnu.org
Subject: bug#59459: 29.0.50; Compilation warnings without tree-sitter
Date: Tue, 22 Nov 2022 15:22:10 -0800 [thread overview]
Message-ID: <70E5913F-2B44-4053-A7A3-8DC713607EFB@gmail.com> (raw)
In-Reply-To: <83wn7n18p7.fsf@gnu.org>
> On Nov 22, 2022, at 4:21 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Mon, 21 Nov 2022 14:01:14 -0800
>>
>> [Continuing from bug#59426]
>>
>> Those warnings are due to no-tree-sitter build not having functions
>> defined in treesit.c. Eli fixed those warnings by adding
>> declare-function’s in every file using those functions. Can we make it a
>> bit nicer for lisp developers? Maybe defining those functions with
>> dummies with something like
>>
>> (defun xxx
>> (error ’treesit "Tree-sitter not available"))
>>
>> ?
>
> I'm not sure this is justified. The cases where a build lacks a very large
> group of primitives references in *.el files are quite rare in our practice;
> about the only two examples I know of are xwidgets.el and treesit.el (plus
> modes which use tree-sitter). It's easy enough (albeit annoying) to add a
> few declare-function's, so unless we are going to have more and more of
> these cases, adding a whole new infrastructure, let alone tricks like the
> above, which will raise a lot of brows, sound excessive to me.
If it cannot be easily done with existing tools, then I agree declare-function is good enough.
Thanks,
Yuan
prev parent reply other threads:[~2022-11-22 23:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 22:01 bug#59459: 29.0.50; Compilation warnings without tree-sitter Yuan Fu
2022-11-22 12:21 ` Eli Zaretskii
2022-11-22 23:22 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70E5913F-2B44-4053-A7A3-8DC713607EFB@gmail.com \
--to=casouri@gmail.com \
--cc=59459-done@debbugs.gnu.org \
--cc=59459@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).