From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Shigeru Fukaya Newsgroups: gmane.emacs.bugs Subject: bug#20588: [PATCH] 24.5; delete-consecutive-dups may loop infinity Date: Sat, 16 May 2015 14:18:35 +0900 Message-ID: <70D08F97C21E77shigeru.fukaya@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-n7A5Iqhq9hlcHHbQ193C0" X-Trace: ger.gmane.org 1431753563 8703 80.91.229.3 (16 May 2015 05:19:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 May 2015 05:19:23 +0000 (UTC) To: 20588@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 16 07:19:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YtUVC-0003d6-GZ for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 May 2015 07:19:10 +0200 Original-Received: from localhost ([::1]:33678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUVB-0005zn-CM for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 May 2015 01:19:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUV8-0005zi-20 for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:19:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtUV4-0007Jk-RL for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:19:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUV4-0007JQ-NL for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YtUV4-0006Tj-8J for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Shigeru Fukaya Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 May 2015 05:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20588 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.143175353424882 (code B ref -1); Sat, 16 May 2015 05:19:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 May 2015 05:18:54 +0000 Original-Received: from localhost ([127.0.0.1]:46702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtUUv-0006TE-86 for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35420) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtUUs-0006T0-Ky for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtUUm-0007Bh-Ks for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:45 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:37787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUUm-0007Bb-HK for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUUl-0005zY-JN for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:18:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtUUi-0007Ab-DT for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:18:43 -0400 Original-Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]:34678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUUi-0007A9-4q for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:18:40 -0400 Original-Received: by pdeq5 with SMTP id q5so46432076pde.1 for ; Fri, 15 May 2015 22:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:mime-version:content-type:message-id; bh=1RSohDnH/7cTo1ZGsXqj8EMIxIz234JUh/waYVhtMVM=; b=yBbX65TN3DalUSCpRUvSDsxp/7O7+dILcEOaZoH1//D1lfG75X2OIOKTsk0Gg3RMzc tpJW47soUqquAU6Paqdf+Jnq67XRra00uA/JFge8ezzRHsqccNbZ/DPoR/bbqEPR9Eq/ 3NyyJTUcfja0FrbMTt4k93FQfz/3Cr1i0cPg9dNUBeNozrRWdF2xI/YPBjbK+3yHyQR0 EmmeYTP+fbu1DWG28HE+RUBFhHHD7lIwVY5WDz6uClq7SYh1bktVjScI6/hMDC/gLzvq mesuu6+o6l5qAT/CwABp2TUslhKec29w68GWjyA1S3upW0BVJinbTcEK0IcxcOcAKz3+ HwTw== X-Received: by 10.68.219.1 with SMTP id pk1mr24455657pbc.18.1431753518389; Fri, 15 May 2015 22:18:38 -0700 (PDT) Original-Received: from gmail.com (115x125x38x32.ap115.ftth.ucom.ne.jp. [115.125.38.32]) by mx.google.com with ESMTPSA id p5sm3472616pdi.2.2015.05.15.22.18.36 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 May 2015 22:18:37 -0700 (PDT) X-Mailer: HidemaruMail 6.30 (WinNT,602) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102863 Archived-At: --Boundary-n7A5Iqhq9hlcHHbQ193C0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hello. delete-consecutive-dups falls into infinite loop if the last element is nil. The attached code will fix it, and besides, avoid re-scan (call of nbutlast) of a circular list in deletion of the last element. Regards, Shigeru --Boundary-n7A5Iqhq9hlcHHbQ193C0 Content-Type: application/octet-stream; name="subr.diff" Content-Disposition: attachment; filename="subr.diff" Content-Transfer-Encoding: base64 KioqIHN1YnIuZWwJVGh1IE1heSAgNyAxMjoyNDoyMSAyMDE1Ci0tLSBzdWJyLm5ldy5lbAlT YXQgTWF5IDE2IDEzOjQwOjQ3IDIwMTUKKioqKioqKioqKioqKioqCioqKiA0NDAsNDU1ICoq KioKICBGaXJzdCBhbmQgbGFzdCBlbGVtZW50cyBhcmUgY29uc2lkZXJlZCBjb25zZWN1dGl2 ZSBpZiBDSVJDVUxBUiBpcwogIG5vbi1uaWwuIgogICAgKGxldCAoKHRhaWwgbGlzdCkgbGFz dCkKISAgICAgKHdoaWxlIChjb25zcCB0YWlsKQogICAgICAgIChpZiAoZXF1YWwgKGNhciB0 YWlsKSAoY2FkciB0YWlsKSkKICAJICAoc2V0Y2RyIHRhaWwgKGNkZHIgdGFpbCkpCiEgCShz ZXRxIGxhc3QgKGNhciB0YWlsKQogIAkgICAgICB0YWlsIChjZHIgdGFpbCkpKSkKICAgICAg KGlmIChhbmQgY2lyY3VsYXIKISAJICAgICAoY2RyIGxpc3QpCiEgCSAgICAgKGVxdWFsIGxh c3QgKGNhciBsaXN0KSkpCiEgCShuYnV0bGFzdCBsaXN0KQohICAgICAgIGxpc3QpKSkKICAK ICAoZGVmdW4gbnVtYmVyLXNlcXVlbmNlIChmcm9tICZvcHRpb25hbCB0byBpbmMpCiAgICAi UmV0dXJuIGEgc2VxdWVuY2Ugb2YgbnVtYmVycyBmcm9tIEZST00gdG8gVE8gKGJvdGggaW5j bHVzaXZlKSBhcyBhIGxpc3QuCi0tLSA0NDAsNDU1IC0tLS0KICBGaXJzdCBhbmQgbGFzdCBl bGVtZW50cyBhcmUgY29uc2lkZXJlZCBjb25zZWN1dGl2ZSBpZiBDSVJDVUxBUiBpcwogIG5v bi1uaWwuIgogICAgKGxldCAoKHRhaWwgbGlzdCkgbGFzdCkKISAgICAgKHdoaWxlIChjZHIg dGFpbCkKICAgICAgICAoaWYgKGVxdWFsIChjYXIgdGFpbCkgKGNhZHIgdGFpbCkpCiAgCSAg KHNldGNkciB0YWlsIChjZGRyIHRhaWwpKQohIAkoc2V0cSBsYXN0IHRhaWwKICAJICAgICAg dGFpbCAoY2RyIHRhaWwpKSkpCiAgICAgIChpZiAoYW5kIGNpcmN1bGFyCiEgCSAgICAgbGFz dAohIAkgICAgIChlcXVhbCAoY2FyIHRhaWwpIChjYXIgbGlzdCkpKQohIAkoc2V0Y2RyIGxh c3QgbmlsKSkpCiEgICBsaXN0KQogIAogIChkZWZ1biBudW1iZXItc2VxdWVuY2UgKGZyb20g Jm9wdGlvbmFsIHRvIGluYykKICAgICJSZXR1cm4gYSBzZXF1ZW5jZSBvZiBudW1iZXJzIGZy b20gRlJPTSB0byBUTyAoYm90aCBpbmNsdXNpdmUpIGFzIGEgbGlzdC4K --Boundary-n7A5Iqhq9hlcHHbQ193C0 Content-Type: application/octet-stream; name="ChangeLog" Content-Disposition: attachment; filename="ChangeLog" Content-Transfer-Encoding: base64 CSogc3Vici5lbCAoZGVsZXRlLWNvbnNlY3V0aXZlLWR1cHMpOiBBdm9pZCBpbmZpbml0ZSBs b29wIGFuZAoJaW52b2NhdGlvbiBvZiBuYnV0bGFzdC4K --Boundary-n7A5Iqhq9hlcHHbQ193C0--