unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, 39902@debbugs.gnu.org
Subject: bug#39902: 28.0.50; Marking in dired with active region
Date: Wed, 4 Mar 2020 13:07:53 -0800 (PST)	[thread overview]
Message-ID: <7083e1db-20ca-4227-a6d3-81dc814ba65f@default> (raw)
In-Reply-To: <87zhcw14zp.fsf@rub.de>

> >> (1) Docstring of `dired-mark' says
> >>   "If the region is active, mark all files in the region."
> >>
> >> However, the file in the last line of the region is never marked, even
> >> if the region spans the whole line of this file.
> >
> > The problem seems to be that movement doesn't
> > put the cursor where you (and `dired-mark')
> > expect - the full lines are not selected.
> 
> This is due to the following code in dired-mark:
> 
> 	(dired-mark-files-in-region
> 	 (progn (goto-char beg) (line-beginning-position))
> 	 (progn (goto-char end) (line-beginning-position))))))
> 
> It may be that the second use of line-beginning-position is simply a
> mistake, and should be line-end-position (CCing Juri Linkov, who wrote
> that code).  That's what diredp-mark-region-files in the library
> dired+.el uses, which is the inspiration for the dired-mark code
> (see bug#10624).

Indeed.  I looked only at `dired-mark', and saw
that Dired+ doesn't substitute anything different
for that (`m' etc. are still bound to vanilla
`dired-mark').

I agree with you about the bug and proposed fix. 





  reply	other threads:[~2020-03-04 21:07 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 14:29 bug#39902: 28.0.50; Marking in dired with active region Michael Heerdegen
2020-03-04 15:41 ` Drew Adams
2020-03-04 16:04   ` Stephen Berman
2020-03-04 21:07     ` Drew Adams [this message]
2020-03-04 23:46 ` Juri Linkov
2020-03-05  1:11   ` Drew Adams
2020-03-05 13:58   ` Michael Heerdegen
2020-03-05 23:42     ` Juri Linkov
2020-03-06  2:30       ` Drew Adams
2020-03-07  0:07       ` Michael Heerdegen
2020-03-08  0:38         ` Juri Linkov
2020-03-08 14:00           ` Michael Heerdegen
2020-03-08 17:04             ` Drew Adams
2020-03-08 23:56               ` Juri Linkov
2020-03-09  0:37                 ` Drew Adams
2020-03-09 14:53                   ` Michael Heerdegen
2020-03-09 22:28                   ` Juri Linkov
2020-03-10  0:41                     ` Drew Adams
2020-03-10 23:24                       ` Juri Linkov
2020-03-10 23:49                         ` Stephen Berman
2020-03-10 23:56                           ` Juri Linkov
2020-03-11  0:24                         ` Drew Adams
2020-03-10 23:55                     ` Michael Heerdegen
2020-03-11  0:08                       ` Juri Linkov
2020-03-11  0:18                         ` Juri Linkov
2020-03-11  0:29                           ` Drew Adams
2020-03-11  1:21                             ` Michael Heerdegen
2020-03-12  0:43                             ` Juri Linkov
2020-03-12  1:13                               ` Drew Adams
2020-03-13  0:39                                 ` Juri Linkov
2020-03-13  8:31                                   ` Pieter van Oostrum
2020-03-13 22:30                                     ` Michael Heerdegen
2020-03-14 18:03                                       ` Drew Adams
2020-03-14 17:56                                   ` Drew Adams
2020-03-14 23:45                                     ` Juri Linkov
2020-03-15  2:46                                       ` Michael Heerdegen
2020-03-15 20:52                                         ` Drew Adams
2020-03-15 20:50                                       ` Drew Adams
2020-03-15 23:41                                         ` Juri Linkov
2020-03-16  1:46                                           ` Drew Adams
2020-03-17  0:51                                             ` Michael Heerdegen
2020-03-18 23:51                                               ` Juri Linkov
2020-03-19 23:54                                                 ` Juri Linkov
2020-03-22  2:48                                                   ` Michael Heerdegen
2020-03-22 23:33                                                     ` Drew Adams
2020-03-23  0:43                                                       ` Juri Linkov
2020-03-23 15:09                                                         ` Drew Adams
2020-03-24 21:58                                                           ` Juri Linkov
2020-03-24 22:14                                                             ` Drew Adams
2020-03-23  0:35                                                     ` Juri Linkov
2020-03-23 15:20                                                       ` Drew Adams
2020-03-24 21:58                                                         ` Juri Linkov
2020-03-24 22:13                                                           ` Drew Adams
2020-03-16 15:21                             ` Drew Adams
2020-03-09 14:52                 ` Michael Heerdegen
2020-03-09 14:50               ` Michael Heerdegen
2020-03-09 15:22                 ` Drew Adams
2020-03-10 16:04                   ` Michael Heerdegen
2020-03-10 16:33                     ` Drew Adams
2020-03-09  9:04         ` martin rudalics
2020-03-09 15:02           ` Michael Heerdegen
2020-03-09 15:39             ` Drew Adams
2020-03-10 16:08               ` Michael Heerdegen
2020-03-09 17:12             ` martin rudalics
2020-03-10 15:52               ` Michael Heerdegen
     [not found] <5230692c-c665-a330-7a12-e59fa25d97dd@gmail.com>
     [not found] ` <be365062-44db-24bd-0d20-82b27609a5e5@gmail.com>
     [not found]   ` <E1jYLLe-0003O1-Ex@fencepost.gnu.org>
     [not found]     ` <M77rwr6--3-2@tutanota.com>
     [not found]       ` <871rnnvmdx.fsf@red-bean.com>
     [not found]         ` <efc501d8-a73e-0c5c-f518-001396d89c55@online.de>
     [not found]           ` <87pnb7sira.fsf@red-bean.com>
     [not found]             ` <06bcddd4-6991-e4f7-e944-93de14af263d@yandex.ru>
     [not found]               ` <87h7wjsd8o.fsf@red-bean.com>
     [not found]                 ` <20897f01-122d-7f91-eac2-70f5ad75796f@yandex.ru>
     [not found]                   ` <87d077qfmm.fsf@red-bean.com>
     [not found]                     ` <d1b52baf-6940-a34e-baf8-f06906c891db@yandex.ru>
     [not found]                       ` <806193B0-1248-4522-83F1-21FA8206C5A8@traduction-libre.org>
     [not found]                         ` <E1jaWgL-0004Y4-Sj@fencepost.gnu.org>
     [not found]                           ` <87imgtlofi.fsf@fastmail.fm>
     [not found]                             ` <lypnb1cch3.fsf@Lumet.home>
     [not found]                               ` <f36b18ee-ddfa-49f6-a007-c8de75913087@default>
     [not found]                                 ` <VI1PR06MB45260C2EA2DE91E2D44774F396B90@VI1PR06MB4526.eurprd06.prod.outlook.com>
     [not found]                                   ` <87zha35mci.fsf@web.de>
     [not found]                                     ` <87tuztngxr.fsf@mail.linkov.net>
2020-06-03  4:32                                       ` bug#39902: transient Michael Heerdegen
2020-06-03 22:49                                         ` bug#39902: 28.0.50; Marking in dired with active region Juri Linkov
2020-06-04 12:31                                           ` Michael Heerdegen
2020-06-04 22:18                                             ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7083e1db-20ca-4227-a6d3-81dc814ba65f@default \
    --to=drew.adams@oracle.com \
    --cc=39902@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).