unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Vincenzo Pupillo <v.pupillo@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 71518@debbugs.gnu.org, casouri@gmail.com
Subject: bug#71518: 30.0.50; Errors during redisplay with c++-ts-mode
Date: Sat, 22 Jun 2024 18:14:54 +0200	[thread overview]
Message-ID: <7030786.9J7NaK4W3v@fedora> (raw)
In-Reply-To: <86a5jdgece.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

In data sabato 22 giugno 2024 17:57:21 CEST, Eli Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo@gmail.com>
> > Cc: 71518@debbugs.gnu.org
> > Date: Sat, 22 Jun 2024 16:42:09 +0200
> > 
> > fortunately, this time it was easier than usual!
> 
> Thanks, but this change will _require_ the new version of the grammar
> library, right?  I think we usually fix these problems in a way that
> both the old and the new versions are supported, because people could
> have different versions installed.

In the tests I have done, it works with both the new and the old grammar.

> 
> Could you please amend the fix along these lines?
Okay, done. Can this be okay? 

Thanks.
Vincenzo

[-- Attachment #2: 0001-Fix-for-grammar-change-of-keyword-virtual-in-tree-si.patch --]
[-- Type: text/x-patch, Size: 1541 bytes --]

From 5f88ff0001e8c4edb7519d1a85ebb13390d1a285 Mon Sep 17 00:00:00 2001
From: Vincenzo Pupillo <v.pupillo@gmail.com>
Date: Sat, 22 Jun 2024 16:22:16 +0200
Subject: [PATCH] Fix for grammar change of keyword "virtual" in
 tree-sitter-cpp

The new rule works with both the new (>= 0.22.1) and the old (<= 0.22.0)
grammar.

* lisp/progmodes/c-ts-mode.el (c-ts-mode--keywords):
  Removed the keyword "virtual".
* lisp/progmodes/c-ts-mode.el (c-ts-mode--font-lock-settings):
  New font lock rule. (Bug#71518)
---
 lisp/progmodes/c-ts-mode.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el
index f453392ff7f..7bfb84baecb 100644
--- a/lisp/progmodes/c-ts-mode.el
+++ b/lisp/progmodes/c-ts-mode.el
@@ -572,7 +572,7 @@ c-ts-mode--keywords
                   "not" "not_eq" "operator" "or"
                   "or_eq" "override" "private" "protected"
                   "public" "requires" "template" "throw"
-                  "try" "typename" "using" "virtual"
+                  "try" "typename" "using"
                   "xor" "xor_eq"))
       (append '("auto") c-keywords))))
 
@@ -632,7 +632,8 @@ c-ts-mode--font-lock-settings
 
    :language mode
    :feature 'keyword
-   `([,@(c-ts-mode--keywords mode)] @font-lock-keyword-face
+   `((virtual) @font-lock-keyword-face
+     [,@(c-ts-mode--keywords mode)] @font-lock-keyword-face
      ,@(when (eq mode 'cpp)
          '((auto) @font-lock-keyword-face
            (this) @font-lock-keyword-face)))
-- 
2.45.2


  reply	other threads:[~2024-06-22 16:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12 12:33 bug#71518: 30.0.50; Errors during redisplay with c++-ts-mode Eli Zaretskii
2024-06-12 13:53 ` Vincenzo Pupillo
2024-06-13  6:51   ` Yuan Fu
2024-06-13  8:24     ` Eli Zaretskii
2024-06-13  8:57     ` Vincenzo Pupillo
2024-06-22  8:26     ` Eli Zaretskii
2024-06-22 14:42       ` Vincenzo Pupillo
2024-06-22 15:57         ` Eli Zaretskii
2024-06-22 16:14           ` Vincenzo Pupillo [this message]
2024-06-22 16:56             ` Eli Zaretskii
2024-06-22 17:03               ` Eli Zaretskii
2024-06-22 17:59                 ` Vincenzo Pupillo
2024-06-22 18:15                   ` Eli Zaretskii
2024-06-22 18:15                   ` Vincenzo Pupillo
2024-06-22 18:19                     ` Eli Zaretskii
2024-06-22 23:18                       ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7030786.9J7NaK4W3v@fedora \
    --to=v.pupillo@gmail.com \
    --cc=71518@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).