From: Glenn Morris <rgm@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: rcopley@gmail.com, 17884@debbugs.gnu.org
Subject: bug#17884: 24.3.92; `vc-next-action' discards commit message
Date: Mon, 14 Jul 2014 15:31:12 -0400 [thread overview]
Message-ID: <6rr41nivpb.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <v0tx6mpbnz.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sat, 12 Jul 2014 16:25:20 -0400")
I applied this, which hopefully covers it.
--- a/lisp/vc/vc-dispatcher.el 2014-07-12 02:24:02 +0000
+++ b/lisp/vc/vc-dispatcher.el 2014-07-14 19:29:29 +0000
@@ -591,12 +591,19 @@
;; Set up key bindings for use while editing log messages
+(declare-function log-edit-empty-buffer-p "log-edit" ())
+
(defun vc-log-edit (fileset mode backend)
"Set up `log-edit' for use on FILE."
(setq default-directory
(buffer-local-value 'default-directory vc-parent-buffer))
+ (require 'log-edit)
(log-edit 'vc-finish-logentry
- (= (point-min) (point-max))
+ ;; Setup a new log message if the log buffer is "empty",
+ ;; or was previously used for a different set of files.
+ (or (log-edit-empty-buffer-p)
+ (and (local-variable-p 'vc-log-fileset)
+ (not (equal vc-log-fileset fileset))))
`((log-edit-listfun . (lambda ()
;; FIXME: Should expand the list
;; for directories.
prev parent reply other threads:[~2014-07-14 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 15:23 bug#17884: 24.3.92; `vc-next-action' discards commit message Richard Copley
2014-06-30 15:39 ` Glenn Morris
2014-06-30 17:35 ` Richard Copley
2014-06-30 19:33 ` Glenn Morris
2014-07-12 2:25 ` Paul Eggert
2014-07-12 2:56 ` Glenn Morris
2014-07-12 3:09 ` Paul Eggert
2014-07-12 20:25 ` Glenn Morris
2014-07-14 19:31 ` Glenn Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6rr41nivpb.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=17884@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).