From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#51941: Detect duplication of ERT tests Date: Thu, 18 Nov 2021 17:51:07 -0500 Message-ID: <6pk0h5axic.fsf@fencepost.gnu.org> References: <21CD2DED-354E-4C46-9794-07172E3BD5F1@acm.org> <87fsrtkayn.fsf@gnus.org> <87mtm1z7dc.fsf@gnus.org> <977035C0-5706-419C-A7D8-88FC9F3B890F@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23301"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 51941@debbugs.gnu.org, Lars Ingebrigtsen , Philipp To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 18 23:52:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnqGO-0005vO-KU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 23:52:16 +0100 Original-Received: from localhost ([::1]:44136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnqGN-0004kW-HW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 17:52:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnqGA-0004kL-Mi for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 17:52:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnqGA-0007wa-Dy for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 17:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnqGA-0001Gm-AV for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 17:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Nov 2021 22:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51941 X-GNU-PR-Package: emacs Original-Received: via spool by 51941-submit@debbugs.gnu.org id=B51941.16372758804816 (code B ref 51941); Thu, 18 Nov 2021 22:52:02 +0000 Original-Received: (at 51941) by debbugs.gnu.org; 18 Nov 2021 22:51:20 +0000 Original-Received: from localhost ([127.0.0.1]:37383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnqFT-0001Fc-Q2 for submit@debbugs.gnu.org; Thu, 18 Nov 2021 17:51:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnqFQ-0001FN-S9 for 51941@debbugs.gnu.org; Thu, 18 Nov 2021 17:51:18 -0500 Original-Received: from [2001:470:142:3::e] (port=41366 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnqFL-0007o9-Ac; Thu, 18 Nov 2021 17:51:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=BVFK8U0rukEH7qkkySUymDpT34KifU4OQwLVjiSm+lc=; b=YaGsK+kpaBkVyAhDJh+8 Da1/DxhueNyjguyQmDoQpPOCJrr7wlv0zyhwVhTvseWdi7/KZkElgOHmiYmh4Y5N8+wSPBMdCdHH8 OppT+tFHH1YKTq3q4J2BHSdGBBsmxjEmZZvObtPna7eUUA90mDCnlufz2FC+Oo9tFn6kZT85+0fPo Q2k+UAsfLaxhfoB7GMOk7yo1qeZF9drgFPFDqj0DvE6HnWZtY35UdpCqIopctDKwpfh76v/q0Iofr 0N8npDW/Hsp0T+X5sNoFNGH5vW3pSjNOsN3s6OaWux+6H20H3jiGmE8JCo1dIptpdlCEt78ct7CZ9 My8PumBTxVWAmA==; Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mnqFH-0007b6-6V; Thu, 18 Nov 2021 17:51:07 -0500 X-Spook: SUN Aid B.D.M. DCJFTF Rumsfeld Noriega GEODSS GOE X-Ran: xu`FgrWOY1E${|~u+nru=y6Gj3q2d&6]l}>[J3X*R!]~#bKu@6']AU:;>eBg<#RQZ(/8dj X-Hue: blue X-Attribution: GM In-Reply-To: <977035C0-5706-419C-A7D8-88FC9F3B890F@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Thu, 18 Nov 2021 20:13:59 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220350 Archived-At: Mattias Engdeg=C3=A5rd wrote: > It would certainly be good to detect such mistakes, but I'm not sure > how to go about finding them. I wrote a quick-and-dirty scanner that > found about 400 uncalled functions in the test tree of which 1 or 2, > maybe, should have been `ert-deftest` (will fix those right away). > > Clearly something with much better signal/noise ratio is called for. > One would be to only consider functions using `should` etc. Seems to me that making "should" only be defined within tests would have flagged these (https://debbugs.gnu.org/28385).