From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: daanturo Newsgroups: gmane.emacs.bugs Subject: bug#59333: [PATCH] Define macro dlet* Date: Sat, 19 Nov 2022 12:29:24 +0700 Message-ID: <6ff5662c-eaaa-e8dd-2fa0-2c27c384cdaf@gmail.com> References: <0e8ca5ce-a413-0dd0-c62e-647d19953a3b@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------fY9ubDAKlBc0kwdv5WaByJ0N" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34305"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Cc: 59333@debbugs.gnu.org To: Jean Louis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 19 06:32:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owGSa-0008nd-M9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Nov 2022 06:32:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owGSR-0001sK-QN; Sat, 19 Nov 2022 00:32:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owGSQ-0001rx-Ej for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 00:32:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owGSQ-0007SD-6c for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 00:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owGSQ-0003Zu-2E for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 00:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: daanturo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Nov 2022 05:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59333-submit@debbugs.gnu.org id=B59333.166883590913723 (code B ref 59333); Sat, 19 Nov 2022 05:32:01 +0000 Original-Received: (at 59333) by debbugs.gnu.org; 19 Nov 2022 05:31:49 +0000 Original-Received: from localhost ([127.0.0.1]:38769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owGSC-0003ZG-Hw for submit@debbugs.gnu.org; Sat, 19 Nov 2022 00:31:48 -0500 Original-Received: from mail-pj1-f43.google.com ([209.85.216.43]:54251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owGSA-0003Z0-B0 for 59333@debbugs.gnu.org; Sat, 19 Nov 2022 00:31:46 -0500 Original-Received: by mail-pj1-f43.google.com with SMTP id t17so5528411pjo.3 for <59333@debbugs.gnu.org>; Fri, 18 Nov 2022 21:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Q2L3ZRH+TU72NYUQgc7/k2K7slsuzk3KWvGNWzvJc80=; b=fwHTFFmdMkZ1qsQJxMNjOEkzyU/dZ2UzaBGNOTgWm+N3MGQ4lpqmgp8cF+p+GWGunf V6t1IGiJDYQRGGxWfkyxB46MHQvVTx5tgsp5StipEoUVVv+B1ZL61Jo3qLRRBPta0m61 tR2V8xvgvbHiHrcWAHRedoX2BiTeeSGrhHAXuubwN/OlGP0PEhlezgOR5gIakMqwJ4hS P2oRBqsy/tPH4Q9sELPV81vTunRHNaDtRyLGkz7DBYJCxPxC0yy6tqdnVrXV/r+GlsQ3 Te+Vpdn6IBkRwOw/RwywnPkftIPXdnllrkRcZcnF4P6FFKxmtn0loBT/vBdBmBiWHCZ4 4UgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Q2L3ZRH+TU72NYUQgc7/k2K7slsuzk3KWvGNWzvJc80=; b=F5UIcPbEJWNZB1dm8ItMgJws/L254SeEg4LY3EPiSccMMvBy4UGQhLQAibRf+e0kFy XKlZw8RTaKICPa9xQKN4YqP2qX4GrVMMnkeX428trfuZYZ1MTG1RzqTFp4DQ1YkgGATk eeD0GQcSdb1sAtxeaKpEBbpo8Ay91GPyu+kgn6xoPxuDu08GWvV7d/x5wuCVeS83fGID 6hv7TSk7M5kMAbzYpCKNbcKxZNFDqGvQoUB86gCYQv0egGVrWjmdjmQcjv+8dE7ntfSE 3LW5uHdQqkY0XZbhQmQYreuYMFbVYXR0zAoEh4FXREIbIgTVVTdq8nkyqwXD3O/CBDl1 ptjw== X-Gm-Message-State: ANoB5ple2O29R4xp+MBgctkyy4kJbp3QsKVVSrgY7muGGRzjlKiRFES1 XjhM6Rb9ntUE65RCzKeFfAE= X-Google-Smtp-Source: AA0mqf6YeCdqWLHoq72zeaj9vhyYMwAJa7ebVVmQyQGWVQpJ4cahagzLhIP3SRj88FtSzLj+QE3rvw== X-Received: by 2002:a17:90a:bf17:b0:213:587b:8a83 with SMTP id c23-20020a17090abf1700b00213587b8a83mr951335pjs.22.1668835900288; Fri, 18 Nov 2022 21:31:40 -0800 (PST) Original-Received: from [192.168.1.11] ([113.173.246.114]) by smtp.gmail.com with ESMTPSA id x1-20020a628601000000b005289a50e4c2sm4152157pfd.23.2022.11.18.21.31.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 21:31:39 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248304 Archived-At: This is a multi-part message in MIME format. --------------fY9ubDAKlBc0kwdv5WaByJ0N Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On @ 2022-11-17 13:36, Mattias Engdegård wrote: > The proposed patch also appears incorrect It was a mistake when I copying and pasting. This patch corrected that and removed the erroneous breakage mention. If there would ever be a vote to reduce the number of `let` variants to lighten the maintenance burden, I bet that the `let*` ones will remain instead of the versions without the ability to refer to prior bindings. As `let*` can cover `let` but the reverse is impossible. ```emacs-lisp (let* ((_a a)        (a (+ 1 _a))        (b (+ 2 _a)))) ``` Therefore, in my opinion, new `XXXlet` macros variants should be defined like `XXXlet*` instead, maybe with only `XXXlet*` without `XXXlet`, since we will eventually need an asterisk version in the future anyway. (Also dash-like easy destructuring is sweet if possible.) Why do need to define (publicly) then maintain for eternity `letf`, `flet`, `dlet`, `lexical-let`, `pcase-let`, `if-let`, `when-let`, etc. when only their `*` versions should be exposed and encompass every use case just fine? I think `and-let*` is the most sensible case here as it doesn't have a more limited `and-let` version. On 19/11/2022 11:47, Jean Louis wrote: > * daanturo [2022-11-17 10:16]: >> --=-=-= >> Content-Type: text/plain >> >> Tags: patch >> >> >> The dlet breakage comes as much surprise to me. There's not even a >> single entry in NEWS that mentions it. >> >> >> The last line of `dlet' is now: (let ,binders ,@body))) while I need >> it to be as below: (let* ,binders ,@body)) >> >> -- Daanturo. --------------fY9ubDAKlBc0kwdv5WaByJ0N Content-Type: text/x-patch; charset=UTF-8; name="0001-Define-macro-dlet-asterisk.patch" Content-Disposition: attachment; filename="0001-Define-macro-dlet-asterisk.patch" Content-Transfer-Encoding: base64 RnJvbSA1N2ZhMDE1ZDAzMjMyZTU1MTdjYjZkMjA4MmQyNGVmMThjYTg4ZTI0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYWFudHVybyA8ZGFhbnR1cm9AZ21haWwuY29tPgpE YXRlOiBTYXQsIDE5IE5vdiAyMDIyIDEyOjAyOjM1ICswNzAwClN1YmplY3Q6IFtQQVRDSF0g RGVmaW5lIG1hY3JvIGRsZXQqCgoqIGxpc3Avc3Vici5lbDogaW1wbGVtZW50YXRpb24uCiog ZG9jL2xpc3ByZWYvdmFyaWFibGVzLnRleGk6IGRvY3VtZW50YXRpb24uCiogZXRjL05FV1M6 IGFubm91bmNlIGl0LgotLS0KIGRvYy9saXNwcmVmL3ZhcmlhYmxlcy50ZXhpIHwgNiArKysr KysKIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgIHwgNSArKysrKwogbGlzcC9zdWJyLmVs ICAgICAgICAgICAgICAgfCA4ICsrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDE5IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9kb2MvbGlzcHJlZi92YXJpYWJsZXMudGV4aSBiL2Rv Yy9saXNwcmVmL3ZhcmlhYmxlcy50ZXhpCmluZGV4IDcyMDZmMmFjZDIuLjExYTBmMjIwY2Eg MTAwNjQ0Ci0tLSBhL2RvYy9saXNwcmVmL3ZhcmlhYmxlcy50ZXhpCisrKyBiL2RvYy9saXNw cmVmL3ZhcmlhYmxlcy50ZXhpCkBAIC0zMDMsNiArMzAzLDEyIEBAIExvY2FsIFZhcmlhYmxl cwogdGhlIGZvcm1zLCBhbmQgdGhlbiBtYWtlIHRoZSB2YXJpYWJsZXMgbm9uLXNwZWNpYWwg YWdhaW4uCiBAZW5kIGRlZnNwZWMKIAorQGRlZnNwZWMgZGxldCogKGJpbmRpbmdzQGRvdHN7 fSkgZm9ybXNAZG90c3t9CitUaGlzIGZvcm0gaXMgbGlrZSBAY29kZXtkbGV0fSwgYnV0IGVh Y2ggdmFsdWVmb3JtIGNhbiByZWZlciB0byB0aGUKK3N5bWJvbHMgYWxyZWFkeSBib3VuZCBw cmV2aW91c2x5LCBsaWtlIHdoYXQgQGNvZGV7bGV0Kn0gaXMgdG8KK0Bjb2Rle2xldH0uCitA ZW5kIGRlZnNwZWMKKwogQGRlZnNwZWMgbmFtZWQtbGV0IG5hbWUgYmluZGluZ3MgJnJlc3Qg Ym9keQogVGhpcyBzcGVjaWFsIGZvcm0gaXMgYSBsb29waW5nIGNvbnN0cnVjdCBpbnNwaXJl ZCBmcm9tIHRoZQogU2NoZW1lIGxhbmd1YWdlLiAgSXQgaXMgc2ltaWxhciB0byBAY29kZXts ZXR9OiBJdCBiaW5kcyB0aGUgdmFyaWFibGVzIGluCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBi L2V0Yy9ORVdTCmluZGV4IDBiOGY0NTM5ZjkuLjExZjljY2IyNmEgMTAwNjQ0Ci0tLSBhL2V0 Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0zMjY5LDYgKzMyNjksMTEgQEAgVGhlIGZvbGxv d2luZyBnZW5lcmFsaXplZCB2YXJpYWJsZXMgaGF2ZSBiZWVuIG1hZGUgb2Jzb2xldGU6CiAM CiAqIExpc3AgQ2hhbmdlcyBpbiBFbWFjcyAyOS4xCiAKKworKysrCisqKiBOZXcgbWFjcm8g J2RsZXQqJy4KK0xpa2Ugd2hhdCAnbGV0KicgaXMgdG8gJ2xldCcuCisKICsrKwogKiogSW50 ZXJwcmV0ZWQgY2xvc3VyZXMgYXJlICJzYWZlIGZvciBzcGFjZSIuCiBBcyB3YXMgYWxyZWFk eSB0aGUgY2FzZSBmb3IgYnl0ZS1jb21waWxlZCBjbG9zdXJlcywgaW5zdGVhZCBvZiBjYXB0 dXJpbmcKZGlmZiAtLWdpdCBhL2xpc3Avc3Vici5lbCBiL2xpc3Avc3Vici5lbAppbmRleCA2 YjgzMTk2ZDA1Li5lY2NhNTJmOTllIDEwMDY0NAotLS0gYS9saXNwL3N1YnIuZWwKKysrIGIv bGlzcC9zdWJyLmVsCkBAIC0yMTU1LDYgKzIxNTUsMTQgQEAgZGxldAogICAgICAgICAgICAg ICAgYmluZGVycykKICAgICAgKGxldCAsYmluZGVycyAsQGJvZHkpKSkKIAorKGRlZm1hY3Jv IGRsZXQqIChiaW5kZXJzICZyZXN0IGJvZHkpCisgICJMaWtlIGBsZXQqJyBidXQgdXNpbmcg ZHluYW1pYyBzY29waW5nLiIKKyAgKGRlY2xhcmUgKGluZGVudCAxKSAoZGVidWcgbGV0KSkK KyAgYChsZXQgKF8pCisgICAgICxAKG1hcGNhciAobGFtYmRhIChiaW5kZXIpCisgICAgICAg ICAgICAgICAgIGAoZGVmdmFyICwoaWYgKGNvbnNwIGJpbmRlcikgKGNhciBiaW5kZXIpIGJp bmRlcikpKQorICAgICAgICAgICAgICAgYmluZGVycykKKyAgICAgKGxldCogLGJpbmRlcnMg LEBib2R5KSkpCiAKIChkZWZtYWNybyB3aXRoLXdyYXBwZXItaG9vayAoaG9vayBhcmdzICZy ZXN0IGJvZHkpCiAgICJSdW4gQk9EWSwgdXNpbmcgd3JhcHBlciBmdW5jdGlvbnMgZnJvbSBI T09LIHdpdGggYWRkaXRpb25hbCBBUkdTLgotLSAKMi4zOC4xCgo= --------------fY9ubDAKlBc0kwdv5WaByJ0N--