From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order Date: Sun, 10 Sep 2023 10:58:17 -0300 Message-ID: <6fe31ce5-4be7-7f79-e310-52e04d869467@gmail.com> References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19474"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Stefan Kangas , 65852@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 10 15:59:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfKyD-0004sV-6X for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Sep 2023 15:59:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfKxt-0001tl-5v; Sun, 10 Sep 2023 09:59:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfKxn-0001p3-7Q for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 09:58:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfKxm-0005KJ-AS for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 09:58:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfKxp-00082v-NU for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 09:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2023 13:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65852 X-GNU-PR-Package: emacs Original-Received: via spool by 65852-submit@debbugs.gnu.org id=B65852.169435431230892 (code B ref 65852); Sun, 10 Sep 2023 13:59:01 +0000 Original-Received: (at 65852) by debbugs.gnu.org; 10 Sep 2023 13:58:32 +0000 Original-Received: from localhost ([127.0.0.1]:50991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfKxM-00082C-64 for submit@debbugs.gnu.org; Sun, 10 Sep 2023 09:58:32 -0400 Original-Received: from mail-oo1-xc32.google.com ([2607:f8b0:4864:20::c32]:50291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfKxI-00081x-Lz for 65852@debbugs.gnu.org; Sun, 10 Sep 2023 09:58:31 -0400 Original-Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-570e005c480so2232361eaf.0 for <65852@debbugs.gnu.org>; Sun, 10 Sep 2023 06:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694354299; x=1694959099; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FCCs7PDnM0ohvF9PInyyslmfJDhpveymeZ3ozEq7WZI=; b=qETrYQ4rdly47gOQqlPyUlJN9rGZdkxp50BzH42IuaeVS6sptQLdIoMMzXeTnHQDNj F3eliFyG6ybHxzbmn9HdUluTV2cNltHTrcbTO05mrQk/ts5jAjxrQMpwC2/slZFms8yE neNPRnJaoNhAj/RJaGtL3eDdqzpeZvmLyYAsgkNEQGt148wZcDXHzQLLgP6sFigDQ0u7 ZKcHjEn1yzp9hjTJoVDWXhgonAaj3+YHs5dhth5nHTGDG9lwbw2i0MAmi8wUwMuaFVUv cN+e0HHJSXjG3fPsumNZSkXIlZDADujde9OQ+XAP3WJFfzg4KHzxE0zdC6WUZfLwtmof oxGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694354299; x=1694959099; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FCCs7PDnM0ohvF9PInyyslmfJDhpveymeZ3ozEq7WZI=; b=RpZuScy2b6u7OBFTXuwKnjX1YNluLdtSg0bUlOfLqzmQfU2ufCQsZA+ddik+VA1lRQ 7J16DVyVCwn9c/Ml2bxdkYxYXXf3NgLAAogguH4/ef76xnNuKkJ5MHrRgQ7BCzFH2qdk OqY24LaFLzoCHGtOG5WyQMSgqnWgNsB4fZ5KeNArMITgK7o0hPLVFTRsgrB1bJaTMX5C p+Xg4xt4RPvocJZqYlqvdRSG0lwJ3cZmlMb0jmmlK/jAtBb7bN45cmu6Fax1UPz/HfRi wTpgR/nRvO4BqBdXeOIOpeZncvQaMhhZZsRJqSM48q+GXKfXVR00bYpGDy/3RbF1cKKI FKZw== X-Gm-Message-State: AOJu0YyVrOLNz8ZPs0b239K5G5CxwhBrBFs/ehgq9vpho3gCi+LNqWhU 07XWAuw+ONouyl3qKL5klo8= X-Google-Smtp-Source: AGHT+IGogk7cMVDCRK/JLit8y/O6idqC3e3rwIm8vhgx8P9yekk3KkeGYNYmiYVlwVBUApopblnY3A== X-Received: by 2002:a05:6870:d60f:b0:1d5:6161:76f2 with SMTP id a15-20020a056870d60f00b001d5616176f2mr9590707oaq.27.1694354299470; Sun, 10 Sep 2023 06:58:19 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id a16-20020a056870e35000b001cd1a628c40sm3009159oae.52.2023.09.10.06.58.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Sep 2023 06:58:19 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269963 Archived-At: On 10/9/23 10:49, Stefan Kangas wrote: > Mauro Aranda writes: > >> The :type for image-auto-resize looks like this: >> >> :type '(choice (const :tag "No resizing" nil) >>                 (const :tag "Fit to window" fit-window) >>                 (other :tag "Scale down to fit window" t) >>                 (number :tag "Scale factor" 1)) >> >> The `other' choice should come last.  Otherwise Custom thinks that >> that's the selected option, even when the value of image-auto-resize is >> a number. > > ENOPATCH I was waiting to get a bug number assigned, so I could add it in the commit message.  I don't know if there's any other way to do it. > Thanks for working on this.  Is it possible to detect issues like these > statically? I worked on something like that for elint.el, based on the wishlist on Bug#2591: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=2591 But I know it might be better to make it so that the byte-compiler warns, so I never posted it.