From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#74287: [PATCH] Rework history Isearch for Eshell Date: Tue, 26 Nov 2024 09:00:13 -0800 Message-ID: <6fdd8386-8915-e3a8-046a-b18750a7057d@gmail.com> References: <871pzjkhmm.fsf@pengjiz.com> <8c80ae91-476e-e665-43be-86d72fb57ed1@gmail.com> <86v7waz603.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20009"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74287@debbugs.gnu.org, Sean Whitton , Pengji Zhang , Juri Linkov To: James Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 26 18:02:40 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tFyxT-0004yJ-Qf for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Nov 2024 18:02:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFywy-0006tw-9w; Tue, 26 Nov 2024 12:02:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFyws-0006qX-OJ for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 12:02:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tFyws-0001vQ-Be for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 12:02:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=Dd2q8oXoPW2tjaKWhrhv+CkGE7AEdLDaP4iH25G3qvc=; b=fGNG8/ev5yJn/MnC7iQeo/4B8MA1BBl9yzVlnbDYkdzVLa3MtKhc8PiWaL7l9FO3vlMuW3cfxCzeRCVbRoQqcOWOiN4GJrkhA4yu9PPriUrnCKzQBcFnvebDvxmt+u49SyllpzQNG9cJbXOfzVnhbj4VqjqpEjgGTHtuiea3QlOmAZLiaSPerXjchXB/Jh+Et4FefZfGW9/VTHveN/rTEzVxnvTNM1NH3TSTzISkGBPGbmweK+oNKUW42xlrAOJZ8MNcimO19vxdBd6G34qm/PfjNwKurMF7KE8XHupHLcgJxLp0dGUvP9RQQJH8LheRtPuUaRAZPuAYXswredNdtw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tFyws-0004Lj-6C for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 12:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2024 17:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74287 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74287-submit@debbugs.gnu.org id=B74287.173264047616623 (code B ref 74287); Tue, 26 Nov 2024 17:02:02 +0000 Original-Received: (at 74287) by debbugs.gnu.org; 26 Nov 2024 17:01:16 +0000 Original-Received: from localhost ([127.0.0.1]:50723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFyw8-0004K1-7v for submit@debbugs.gnu.org; Tue, 26 Nov 2024 12:01:16 -0500 Original-Received: from mail-pf1-f177.google.com ([209.85.210.177]:56717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFyw6-0004Jt-Ee for 74287@debbugs.gnu.org; Tue, 26 Nov 2024 12:01:15 -0500 Original-Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-724f41d520cso2190429b3a.1 for <74287@debbugs.gnu.org>; Tue, 26 Nov 2024 09:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732640413; x=1733245213; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=Dd2q8oXoPW2tjaKWhrhv+CkGE7AEdLDaP4iH25G3qvc=; b=VH8R3EjGrB0wQru28nerfPhM0GK8E6VGXAv9Kob1KgyXySuKwEOjJ6ypOnGIfyW6rN VGkbTnlfbMkIUHtg1lcWN5cvbRw9XcRe+lH1SvX+g5SoWWL2b21y/j6fGJnfMY0NbRgC SdS96RuNqY5SX+CkoBAxiQvID0EKInwyFQKRl8OYV51yrqdwjsxvB+mLrWJ0UHofMgGB BR1ZEAQz2+rEy7phTZTh/dWIHVPw3yNY7RGj0V8DNkm63SlGwekmWZ6Rwizia3xIRQ5x acgfqLzXYKq1TlhSBRg0b8t7P7+9Qd1WUK8vUJARH6F1kNWpRxI1M4XhxYElceZQcG5S vAWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732640413; x=1733245213; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dd2q8oXoPW2tjaKWhrhv+CkGE7AEdLDaP4iH25G3qvc=; b=bO8GW+l/iw92MiELpO5bxbwQnjd4iW1KMkGUtcfAFSJtu2laHhCXfTDFr/A6RM75rf HqE+MA2yA9u9KuMrwXbGyDeGq7weoXeZBG96/PU4oiw13VJ6XyBgIuPrP4sxxgbaQXn1 IXTzoHdi0sjTY0fYElcDvVMPSLM2NHpIcOHlfOXj08iA3DEwHuNGWfTDA56YGfZvospI h2+ewLZFPCz7zQh6n799Kl2kjeFUhQzt06niqLv+6pFobXW6USeUUMLXhkk408sLeZ6e B0uKKMe5xvSCPMOJmbozd64VaUuDMRNTg4OS+aXQnxbRQ3q0Pl7BlqSULjqfVkkA8LYh lbzA== X-Gm-Message-State: AOJu0Yze3QQHu6BWKp43qYBiv/AMVsxCbokIyJo+tm1sVzeV3yY51h9+ QwEWYU+TyJSzTOV6Jm7vxDKYYqVXRLwKWhQHuTd/+taZRxpT64Qt X-Gm-Gg: ASbGncsl+aI/LlSvsoZfh+ERiPWJCmAGbBcjAlDRrD6k+OGklN4YV3sWg7Vd9AeDPi1 DMHmVCmQuBe28Xhza2vjig3RXHAUGC8ucZw9wzydtVQxWshybfPmGB59DUkxU/FwMlqJCHEIcbd bTS+ZOOI7Fw2uxG4F315bQ3OCaMFweYR+b9PqlRFT9s84ziUSvoBFH2qv5MAclY/vA/Z7ozhJ7/ //hzJZIt0Om1cJeTD3Nf0SBC7uhhK0er2gAI92FfuE7jZ2Cp3nFRI5VKY3fr3EQNgNv0DeYL+G+ 8RUZl+SJ/xq6kVTLSMYZeR7Grek= X-Google-Smtp-Source: AGHT+IEFMyYdkIqLzUnojOc30XudscLHKh+njVeJzL4QCFd+ONSXoqMLlEc34wJdN1nou0qDSc1Y/w== X-Received: by 2002:a05:6a00:4a10:b0:724:e80a:330 with SMTP id d2e1a72fcca58-724e80a0f26mr14926604b3a.5.1732640412923; Tue, 26 Nov 2024 09:00:12 -0800 (PST) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-724de55b160sm8638120b3a.161.2024.11.26.09.00.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Nov 2024 09:00:12 -0800 (PST) Content-Language: en-US In-Reply-To: <86v7waz603.fsf@gmx.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295994 Archived-At: On 11/26/2024 1:41 AM, James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > My 2c: I now think it's better to hold out for something with way less > code, using capf. Like mentioned in the emacs-devel list, that's probably how *I'd* want a command history search implementation to use, but I also think that an Isearch interface makes a lot of sense as an option, depending on user preferences. As far as I can tell, we'd have to write different code for each of these styles (i.e. you can't just make Isearch use capf). Though as mentioned I'm not very familiar with Isearch's internals. So long as this doesn't prevent a capf-based implementation (and I'm guessing it wouldn't, since that would just be a new option), I think we could merge this patch. I also prefer to have Shell and Eshell work the same way unless there's some compelling reason why they should be different.