From: Jim Porter <jporterbugs@gmail.com>
To: James Thomas <jimjoe@gmx.net>
Cc: 74287@debbugs.gnu.org, Sean Whitton <spwhitton@spwhitton.name>,
Pengji Zhang <me@pengjiz.com>, Juri Linkov <juri@linkov.net>
Subject: bug#74287: [PATCH] Rework history Isearch for Eshell
Date: Tue, 26 Nov 2024 09:00:13 -0800 [thread overview]
Message-ID: <6fdd8386-8915-e3a8-046a-b18750a7057d@gmail.com> (raw)
In-Reply-To: <86v7waz603.fsf@gmx.net>
On 11/26/2024 1:41 AM, James Thomas via Bug reports for GNU Emacs, the
Swiss army knife of text editors wrote:
> My 2c: I now think it's better to hold out for something with way less
> code, using capf.
Like mentioned in the emacs-devel list, that's probably how *I'd* want a
command history search implementation to use, but I also think that an
Isearch interface makes a lot of sense as an option, depending on user
preferences. As far as I can tell, we'd have to write different code for
each of these styles (i.e. you can't just make Isearch use capf). Though
as mentioned I'm not very familiar with Isearch's internals.
So long as this doesn't prevent a capf-based implementation (and I'm
guessing it wouldn't, since that would just be a new option), I think we
could merge this patch. I also prefer to have Shell and Eshell work the
same way unless there's some compelling reason why they should be different.
next prev parent reply other threads:[~2024-11-26 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-10 1:22 bug#74287: [PATCH] Rework history Isearch for Eshell Pengji Zhang
2024-11-10 23:40 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-12 8:54 ` Pengji Zhang
2024-11-26 6:53 ` Jim Porter
2024-11-26 9:41 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-26 17:00 ` Jim Porter [this message]
2024-11-27 5:37 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fdd8386-8915-e3a8-046a-b18750a7057d@gmail.com \
--to=jporterbugs@gmail.com \
--cc=74287@debbugs.gnu.org \
--cc=jimjoe@gmx.net \
--cc=juri@linkov.net \
--cc=me@pengjiz.com \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).