unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Fabrice Popineau <fabrice.popineau@gmail.com>
Cc: 28508-done@debbugs.gnu.org
Subject: bug#28508: 26.0.60; Problem with mkdir() on root drive (ms-windows)
Date: Tue, 19 Sep 2017 01:50:59 -0700	[thread overview]
Message-ID: <6fb106d9-c129-28e2-9ac4-1737a3f256ff@cs.ucla.edu> (raw)
In-Reply-To: <CAFgFV9OgEKDeAA+eUpwSHjmaJHNt5gs40YAvX6qOcCxLqj5dGA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 84 bytes --]

Thanks for reporting that. I installed the attached patch into the emacs-26 branch.

[-- Attachment #2: 0001-Fix-bug-with-make-directory-on-MS-Windows-root.patch --]
[-- Type: text/x-patch, Size: 871 bytes --]

From 3c8da733879cd9c9ffd3b4709b596589f79f4fdf Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue, 19 Sep 2017 01:47:39 -0700
Subject: [PATCH] Fix bug with make-directory on MS-Windows root

* lisp/files.el (files--ensure-directory): Treat any error, not
just file-already-exists, as an opportunity to check whether DIR
is already a directory (Bug#28508).
---
 lisp/files.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/files.el b/lisp/files.el
index ff0ab70..0c30d40 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -5337,7 +5337,7 @@ files--ensure-directory
   "Make directory DIR if it is not already a directory.  Return nil."
   (condition-case err
       (make-directory-internal dir)
-    (file-already-exists
+    (error
      (unless (file-directory-p dir)
        (signal (car err) (cdr err))))))
 
-- 
2.7.4


  reply	other threads:[~2017-09-19  8:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19  8:26 bug#28508: 26.0.60; Problem with mkdir() on root drive (ms-windows) Fabrice Popineau
2017-09-19  8:50 ` Paul Eggert [this message]
2017-09-19 16:40   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fb106d9-c129-28e2-9ac4-1737a3f256ff@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=28508-done@debbugs.gnu.org \
    --cc=fabrice.popineau@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).