bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Drew Adams]

> > > Perhaps the frame-switch event should simply empty the echo area.
> > > Patches to that effect are welcome.
> >
> > Frame-switch should not systematically empty the echo area, IMO.
> 
> Of course not.  I meant only in this specific case.  IOW, set things
> up in text-scale-adjust so that the echo area is emptied when frame is
> switched after displaying this particular message.

That sounds good to me.

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Drew Adams]

> > > > Here I see it only in the frame where I invoked "C-x -".
> > >
> > > After you see it there, click the title bar of the other frame,
> > > to select it.  The message is moved to that (selected) frame's
> > > echo area.  But using +, 0, or - in that frame does not have
> > > the effect of the message.  That frame shows a different buffer,
> > > so +, 0, or - there is governed by the keymap of that buffer's
> > > frame.
> >
> > Not sure what should happen instead (i.e., the proper fix).
> 
> As long as "C-x C--" uses 'message' to display these instructions,
> nothing can be done, because what you see is the usual behavior of
> messages displayed in the echo area: they follow the selected frame.
> 
> Perhaps the frame-switch event should simply empty the echo area.
> Patches to that effect are welcome.

Frame-switch should not systematically empty the echo area, IMO.

Perhaps there is no easy way to fix the problem for this scenario
or similar (anytime the message makes no sense with a different
frame selected).  Dunno.

But note that the problem does not occur when a different window
(not frame) is selected.  For example, with a single frame with
two windows showing two buffers, `C-x C--' in one window shows
the message, but as soon as you select the other window (e.g.
clicking in it) the message goes away and the scaling command
is quit (e.g. selecting the window with the scaled text again
does not redisplay the message).

Feel free to close this bug, if you don't see a solution.
(I don't have a patch to fix it.)  Or perhaps leave it open,
in case it can be fixed in the future.  Ideally, selecting a
different frame should be handled, I think, similarly to 
selecting a different window.

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Eli Zaretskii]

> Date: Mon, 6 Mar 2017 08:52:42 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: 25978@debbugs.gnu.org
> 
> > As long as "C-x C--" uses 'message' to display these instructions,
> > nothing can be done, because what you see is the usual behavior of
> > messages displayed in the echo area: they follow the selected frame.
> > 
> > Perhaps the frame-switch event should simply empty the echo area.
> > Patches to that effect are welcome.
> 
> Frame-switch should not systematically empty the echo area, IMO.

Of course not.  I meant only in this specific case.  IOW, set things
up in text-scale-adjust so that the echo area is emptied when frame is
switched after displaying this particular message.

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> > As long as "C-x C--" uses 'message' to display these instructions,
>> > nothing can be done, because what you see is the usual behavior of
>> > messages displayed in the echo area: they follow the selected frame.
>> > 
>> > Perhaps the frame-switch event should simply empty the echo area.
>> > Patches to that effect are welcome.
>> 
>> Frame-switch should not systematically empty the echo area, IMO.
>
> Of course not.  I meant only in this specific case.  IOW, set things
> up in text-scale-adjust so that the echo area is emptied when frame is
> switched after displaying this particular message.

Do we have any machinery for setting up an action like that?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Drew Adams <drew.adams@oracle.com>,  25978@debbugs.gnu.org
> Date: Thu, 20 Aug 2020 18:31:05 +0200
> 
> >> Frame-switch should not systematically empty the echo area, IMO.
> >
> > Of course not.  I meant only in this specific case.  IOW, set things
> > up in text-scale-adjust so that the echo area is emptied when frame is
> > switched after displaying this particular message.
> 
> Do we have any machinery for setting up an action like that?

Not that I know of, no.  But I'm far from being an expert on all the
features related to echo-area messages.

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> Do we have any machinery for setting up an action like that?
>
> Not that I know of, no.  But I'm far from being an expert on all the
> features related to echo-area messages.

I've now just make text-scale-adjust clear the echo area in Emacs 29,
which I think shouldn't have any adverse effects in general.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Drew Adams]

With two buffers shown in two frames, do `C-x -' in one of them.
That shows the message:

 "Use +, -, 0 for further adjustment" in the other frame also.

But selecting the other frame and using +, -, or 0 does not do that.
Instead, it just invokes whatever commands are bound to those keys in
that other buffer (or says that the key is not bound).

In GNU Emacs 25.1.1 (x86_64-w64-mingw32)
 of 2016-11-15
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --without-dbus --without-compress-install 'CFLAGS=-O2
 -static -g3''

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Eli Zaretskii]

> Date: Sun, 5 Mar 2017 08:13:01 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> 
> With two buffers shown in two frames, do `C-x -' in one of them.
> That shows the message:
> 
>  "Use +, -, 0 for further adjustment" in the other frame also.

Here I see it only in the frame where I invoked "C-x -".

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Drew Adams]

> > Here I see it only in the frame where I invoked "C-x -".
> 
> After you see it there, click the title bar of the other frame,
> to select it.  The message is moved to that (selected) frame's
> echo area.  But using +, 0, or - in that frame does not have
> the effect of the message.  That frame shows a different buffer,
> so +, 0, or - there is governed by the keymap of that buffer's
> frame.

Not sure what should happen instead (i.e., the proper fix).

The simplest fix, and probably the least confusing for users,
would be to cancel the command as soon as another frame is
selected.

Alternatively, we might try to make it so that if/when you
select the original frame again the command resumes where
it left off, with the same message etc.

I think the latter, besides being more complicated to
implement, might confuse a user who did a bunch of other
stuff before coming back to the original frame (selecting
it again).  IOW, it would probably be better for the
command not to be modal in that buffer (resuming when its
frame is reselected), but just to be canceled as soon as
you select another frame.

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Eli Zaretskii]

> Date: Sun, 5 Mar 2017 08:56:41 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: 25978@debbugs.gnu.org
> 
> > > Here I see it only in the frame where I invoked "C-x -".
> > 
> > After you see it there, click the title bar of the other frame,
> > to select it.  The message is moved to that (selected) frame's
> > echo area.  But using +, 0, or - in that frame does not have
> > the effect of the message.  That frame shows a different buffer,
> > so +, 0, or - there is governed by the keymap of that buffer's
> > frame.
> 
> Not sure what should happen instead (i.e., the proper fix).

As long as "C-x C--" uses 'message' to display these instructions,
nothing can be done, because what you see is the usual behavior of
messages displayed in the echo area: they follow the selected frame.

Perhaps the frame-switch event should simply empty the echo area.
Patches to that effect are welcome.

bug#25978: 25.1; Message from `text-scale-adjust' is shown in other frames too

[Drew Adams]

> > With two buffers shown in two frames, do `C-x -' in one of them.
> > That shows the message:
> >
> >  "Use +, -, 0 for further adjustment" in the other frame also.
> 
> Here I see it only in the frame where I invoked "C-x -".

After you see it there, click the title bar of the other frame,
to select it.  The message is moved to that (selected) frame's
echo area.  But using +, 0, or - in that frame does not have
the effect of the message.  That frame shows a different buffer,
so +, 0, or - there is governed by the keymap of that buffer's
frame.