From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Date: Thu, 10 Aug 2023 19:58:24 -0300 Message-ID: <6f1b1234-ed8c-5391-4646-2e7db5dfa8d0@gmail.com> References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------oHgPXDvjzeb8knj0zLBTJSV0" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8578"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 63290@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 11 00:59:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUEcl-000233-Nq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Aug 2023 00:59:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUEcR-00062I-PS; Thu, 10 Aug 2023 18:59:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUEcQ-000623-5S for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 18:59:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUEcP-00013R-TV for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 18:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUEcP-0004K8-PJ for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 18:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Aug 2023 22:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63290 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63290-submit@debbugs.gnu.org id=B63290.169170831916580 (code B ref 63290); Thu, 10 Aug 2023 22:59:01 +0000 Original-Received: (at 63290) by debbugs.gnu.org; 10 Aug 2023 22:58:39 +0000 Original-Received: from localhost ([127.0.0.1]:44252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUEc2-0004JL-NH for submit@debbugs.gnu.org; Thu, 10 Aug 2023 18:58:39 -0400 Original-Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]:54552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUEby-0004J1-HC for 63290@debbugs.gnu.org; Thu, 10 Aug 2023 18:58:38 -0400 Original-Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-1bff2d2c141so1123176fac.1 for <63290@debbugs.gnu.org>; Thu, 10 Aug 2023 15:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691708308; x=1692313108; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=aeL1Yxbhtw9nvFuyf2J28XuAQvR2QCBBnWyFH4UXZNM=; b=qffMWX4MU81YvAPipT7UCVTRcg6Qe2227XTd11xV1y935DK1OyHiFyITeg1d9bwnbe YWDfVaJIr8t3jYLcvf/niAm/cNgwtVpj3ZldPTMWCfEQ8NSmvDnX+HQxDub7oesyAavw CpifxzJ99mjnAdfF5OsDmWgYQZTCcU4je7VihnFHTUc6AivBrNoTda8wAK4pelvBnC1e peJQuUD95+20UjAvj36IFwJXReOibjTt9ZUM9+1ub9l9I4BgyYWQmwhaw9g/tOvoQGLg tCMx4pcwTv7fwxpRk4tNSRF+0ypWq/wevYtz+pv49kQgv/0nyvqMzt4hjIbYkq1Lw8Yl 7VzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691708308; x=1692313108; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aeL1Yxbhtw9nvFuyf2J28XuAQvR2QCBBnWyFH4UXZNM=; b=dafTVJ4n4SQmWFXYwYw7+UnC9RwYkwaX85bTCgjZvEsx1wwQBy2bj2HFzHGQiB5Tlv blTiGksxK2CjriGkp8psd05k/2UXnKVhJfUlt+Nhec1WzjzcunrhCf9pVRv5slbaKjkp y6AZ6dm05LUbHsdC7UhACZFss/D/r0VhPat4Miyg86W7yF1tZWzWPG7YB0DEY3SirBud B+4+p+JME/eKXbAufgThTQX0LAUlVaWfWWY4+T51Kxh/g3+GNrS4XRbW9hc+Ca/hqxpd n5bqh439V1jByVy/dmMJDK8WjMmzdvUPSk8DaTnBgMHFKtGB2WCiHYbUXoNFRNqynkLR kHig== X-Gm-Message-State: AOJu0YwOrpd0evU2q4e18BT7kCcJ+yEJWYUI2whpQSr2jPl6yMHxRqKo V6CYg4q0tEuvm2Bdl6Z82vnpVA4Ucg4= X-Google-Smtp-Source: AGHT+IGqWJBb5CnnPSZJdb84mU/KZmhmKkHXsKkIUX5CFbCAUszi4Adq508r6n9KLpi9jpyuWlbdhA== X-Received: by 2002:a05:6870:3328:b0:1b7:3f07:e431 with SMTP id x40-20020a056870332800b001b73f07e431mr172542oae.54.1691708308451; Thu, 10 Aug 2023 15:58:28 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id p9-20020a056830130900b006b46b913767sm1111300otq.24.2023.08.10.15.58.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Aug 2023 15:58:27 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267165 Archived-At: This is a multi-part message in MIME format. --------------oHgPXDvjzeb8knj0zLBTJSV0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Thomas Fitzsimmons writes: > Hi Mauro, > > Mauro Aranda writes: > >> I ended up adding a custom :default-get >> function for the list widget, to make it respect a nil value as the >> :value.  This should be backward compatible with other widgets, and >> should fix these "ghost" elements insertions. I also added a test >> for cus-edit-tests. > > Can you try this patch with: > > M-x package-install RET excorporate RET > > Then: > > M-x customize-variable RET excorporate-configuration RET > > then select "Value Menu" and 3, which is "EWS URL OAuth 2.0 settings > (no autodiscovery)".  With your wis-edit.el patch applied I still get > empty values for: > >    INS DEL Argument name:             Argument value: > > and: > >    INS DEL OAuth 2.0 setting name:             OAuth 2.0 setting >   value: > > and when I apply the setting the value contains:   (... (... (#1# > . #1#))    (#1# . #1#)) > > Maybe this is a more complicated case than the test case I provided > (which does now work for me with your patch)? I think this ammended patch fixes it.  Since we want widget-list-default-get to respect a nil :value property, the alist widget needs to be modified so that its default value is nil. --------------oHgPXDvjzeb8knj0zLBTJSV0 Content-Type: text/x-patch; charset=UTF-8; name="0001-Respect-the-value-property-in-a-list-widget-Bug-6329.patch" Content-Disposition: attachment; filename*0="0001-Respect-the-value-property-in-a-list-widget-Bug-6329.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1YWUxN2ZjYzQ1ZWE0MDVmNWNjMmRjNTE2ZWZhMWU5YzA1NzgyMDIxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFdlZCwgOSBBdWcgMjAyMyAwOToxNzo0MyAtMDMwMApTdWJqZWN0OiBb UEFUQ0hdIFJlc3BlY3QgdGhlIDp2YWx1ZSBwcm9wZXJ0eSBpbiBhIGxpc3Qgd2lkZ2V0IChC dWcjNjMyOTApCgoqIGxpc3Avd2lkLWVkaXQuZWwgKHdpZGdldC1saXN0LWRlZmF1bHQtZ2V0 KTogTmV3IGZ1bmN0aW9uLgooYWxpc3QpOiBEZWZpbmUgbmlsIGFzIGEgZGVmYXVsdCB2YWx1 ZS4KKiB0ZXN0L2xpc3AvY3VzLWVkaXQtdGVzdHMuZWwgKGN1cy1lZGl0LXRlc3QtYnVnLTYz MjkwLW9wdGlvbikKKGN1cy1lZGl0LXRlc3QtYnVnLTYzMjkwLW9wdGlvbjIpOiBOZXcgdGVz dCBvcHRpb25zLgooY3VzLWVkaXQtdGVzdC1idWc2MzI5MCk6IE5ldyB0ZXN0LgotLS0KIGxp c3Avd2lkLWVkaXQuZWwgICAgICAgICAgICB8IDEyICsrKysrKysrKysrCiB0ZXN0L2xpc3Av Y3VzLWVkaXQtdGVzdHMuZWwgfCA0MyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDU1IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQg YS9saXNwL3dpZC1lZGl0LmVsIGIvbGlzcC93aWQtZWRpdC5lbAppbmRleCA0NzUzMTExM2Jh OC4uZDUzOGRjNDJkNTMgMTAwNjQ0Ci0tLSBhL2xpc3Avd2lkLWVkaXQuZWwKKysrIGIvbGlz cC93aWQtZWRpdC5lbApAQCAtMzgxMiw4ICszODEyLDE5IEBAIHdpZGdldC1jaGFyYWN0ZXIt bm90aWZ5CiAoZGVmaW5lLXdpZGdldCAnbGlzdCAnZ3JvdXAKICAgIkEgTGlzcCBsaXN0LiIK ICAgOnRhZyAiTGlzdCIKKyAgOmRlZmF1bHQtZ2V0ICMnd2lkZ2V0LWxpc3QtZGVmYXVsdC1n ZXQKICAgOmZvcm1hdCAiJXsldCV9OlxuJXYiKQogCisoZGVmdW4gd2lkZ2V0LWxpc3QtZGVm YXVsdC1nZXQgKHdpZGdldCkKKyAgIlJldHVybiB0aGUgZGVmYXVsdCBleHRlcm5hbCB2YWx1 ZSBmb3IgYSBsaXN0IFdJREdFVC4KKworVGhlIGRlZmF1bHQgdmFsdWUgaXMgdGhlIG9uZSBz dG9yZWQgaW4gdGhlIDp2YWx1ZSBwcm9wZXJ0eSwgZXZlbiBpZiBpdCBpcyBuaWwsCitvciBh IGxpc3Qgd2l0aCB0aGUgZGVmYXVsdCB2YWx1ZSBvZiBlYWNoIGNvbXBvbmVudCBvZiB0aGUg bGlzdCBXSURHRVQuIgorICAod2lkZ2V0LWFwcGx5IHdpZGdldCA6dmFsdWUtdG8tZXh0ZXJu YWwKKyAgICAgICAgICAgICAgICAoaWYgKHdpZGdldC1tZW1iZXIgd2lkZ2V0IDp2YWx1ZSkK KyAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1nZXQgd2lkZ2V0IDp2YWx1ZSkKKyAgICAg ICAgICAgICAgICAgICh3aWRnZXQtZ3JvdXAtZGVmYXVsdC1nZXQgd2lkZ2V0KSkpKQorCiAo ZGVmaW5lLXdpZGdldCAndmVjdG9yICdncm91cAogICAiQSBMaXNwIHZlY3Rvci4iCiAgIDp0 YWcgIlZlY3RvciIKQEAgLTM5NTIsNiArMzk2Myw3IEBAICdhbGlzdAogICA6a2V5LXR5cGUg JyhzZXhwIDp0YWcgIktleSIpCiAgIDp2YWx1ZS10eXBlICcoc2V4cCA6dGFnICJWYWx1ZSIp CiAgIDpjb252ZXJ0LXdpZGdldCAnd2lkZ2V0LWFsaXN0LWNvbnZlcnQtd2lkZ2V0CisgIDp2 YWx1ZSBuaWwKICAgOnRhZyAiQWxpc3QiKQogCiAoZGVmdmFyIHdpZGdldC1hbGlzdC12YWx1 ZS10eXBlKQk7RHluYW1pYyB2YXJpYWJsZQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2N1cy1l ZGl0LXRlc3RzLmVsIGIvdGVzdC9saXNwL2N1cy1lZGl0LXRlc3RzLmVsCmluZGV4IGVjYTM1 ZDdjOTZhLi4zYTc4OGYxOTc0NSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2N1cy1lZGl0LXRl c3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9jdXMtZWRpdC10ZXN0cy5lbApAQCAtOTIsNSArOTIs NDggQEAgdGVzdC1zZXRvcHQKICAgICAgICAgICAgIChidWZmZXItc3Vic3RyaW5nLW5vLXBy b3BlcnRpZXMgKHBvaW50LW1pbikgKHBvaW50LW1heCkpKSkpCiAgICAgKHNob3VsZCAoc3Ry aW5nLXNlYXJjaCAiVmFsdWUgYDpmb28nIGRvZXMgbm90IG1hdGNoIHR5cGUgbnVtYmVyIgog ICAgICAgICAgICAgICAgICAgICAgICAgICAgd2Fybi10eHQpKSkpCisKKyhkZWZjdXN0b20g Y3VzLWVkaXQtdGVzdC1idWc2MzI5MC1vcHRpb24gbmlsCisgICJDaG9pY2Ugb3B0aW9uIGZv ciB0ZXN0aW5nIEJ1ZyM2MzI5MC4iCisgIDp0eXBlICcoY2hvaWNlIChhbGlzdAorICAgICAg ICAgICAgICAgICAgOmtleS10eXBlIChzdHJpbmcgOnRhZyAia2V5IikKKyAgICAgICAgICAg ICAgICAgIDp2YWx1ZS10eXBlIChzdHJpbmcgOnRhZyAidmFsdWUiKSkKKyAgICAgICAgICAg ICAgICAgKGNvbnN0IDp0YWcgImF1dG8iIGF1dG8pKSkKKworKGRlZmN1c3RvbSBjdXMtZWRp dC10ZXN0LWJ1ZzYzMjkwLW9wdGlvbjIgJ3NvbWUKKyAgIkNob2ljZSBvcHRpb24gZm9yIHRl c3RpbmcgQnVnIzYzMjkwLiIKKyAgOnR5cGUgJyhjaG9pY2UKKyAgICAgICAgICAoY29uc3Qg OnRhZyAic29tZSIgc29tZSkKKyAgICAgICAgICAoYWxpc3QKKyAgICAgICAgICAgOmtleS10 eXBlIChzdHJpbmcgOnRhZyAia2V5IikKKyAgICAgICAgICAgOnZhbHVlLXR5cGUgKHN0cmlu ZyA6dGFnICJ2YWx1ZSIpKSkpCisKKyhlcnQtZGVmdGVzdCBjdXMtZWRpdC10ZXN0LWJ1ZzYz MjkwICgpCisgICJUZXN0IHRoYXQgY2hhbmdpbmcgYSBjaG9pY2UgdmFsdWUgYmFjayB0byBh biBhbGlzdCByZXNwZWN0cyBpdHMgbmlsIHZhbHVlLiIKKyAgKGN1c3RvbWl6ZS12YXJpYWJs ZSAnY3VzLWVkaXQtdGVzdC1idWc2MzI5MC1vcHRpb24pCisgIChzZWFyY2gtZm9yd2FyZCAi VmFsdWUiKQorICA7OyBTaW11bGF0ZSBjaGFuZ2luZyB0aGUgdmFsdWUuCisgIChsZXQqICgo Y2hvaWNlICh3aWRnZXQtYXQpKQorICAgICAgICAgKGFyZ3MgKHdpZGdldC1nZXQgY2hvaWNl IDphcmdzKSkKKyAgICAgICAgIChsaXN0LW9wdCAoY2FyICh3aWRnZXQtZ2V0IGNob2ljZSA6 Y2hpbGRyZW4pKSkKKyAgICAgICAgIChjb25zdC1vcHQgKG50aCAxIGFyZ3MpKSkKKyAgICAo d2lkZ2V0LXB1dCBjaG9pY2UgOmV4cGxpY2l0LWNob2ljZSBjb25zdC1vcHQpCisgICAgKHdp ZGdldC12YWx1ZS1zZXQgY2hvaWNlICh3aWRnZXQtZGVmYXVsdC1nZXQgY29uc3Qtb3B0KSkK KyAgICAod2lkZ2V0LXB1dCBjaG9pY2UgOmV4cGxpY2l0LWNob2ljZSBsaXN0LW9wdCkKKyAg ICAod2lkZ2V0LXZhbHVlLXNldCBjaG9pY2UgKHdpZGdldC1kZWZhdWx0LWdldCBsaXN0LW9w dCkpKQorICA7OyBObyBlbXB0eSBrZXkvdmFsdWUgcGFpcnMgc2hvdWxkIHNob3cgdXAuCisg IChzaG91bGQtbm90IChzZWFyY2gtZm9yd2FyZCAia2V5IiBuaWwgdCkpCisgIChjdXN0b21p emUtdmFyaWFibGUgJ2N1cy1lZGl0LXRlc3QtYnVnNjMyOTAtb3B0aW9uMikKKyAgKHNlYXJj aC1mb3J3YXJkICJWYWx1ZSIpCisgIDs7IFNpbXVsYXRlIGNoYW5naW5nIHRoZSB2YWx1ZS4K KyAgKGxldCogKChjaG9pY2UgKHdpZGdldC1hdCkpCisgICAgICAgICAoYXJncyAod2lkZ2V0 LWdldCBjaG9pY2UgOmFyZ3MpKQorICAgICAgICAgKGNvbnN0LW9wdCAoY2FyICh3aWRnZXQt Z2V0IGNob2ljZSA6Y2hpbGRyZW4pKSkKKyAgICAgICAgIChsaXN0LW9wdCAobnRoIDEgYXJn cykpKQorICAgICh3aWRnZXQtcHV0IGNob2ljZSA6ZXhwbGljaXQtY2hvaWNlIGxpc3Qtb3B0 KQorICAgICh3aWRnZXQtdmFsdWUtc2V0IGNob2ljZSAod2lkZ2V0LWRlZmF1bHQtZ2V0IGxp c3Qtb3B0KSkpCisgIDs7IE5vIGVtcHR5IGtleS92YWx1ZSBwYWlycyBzaG91bGQgc2hvdyB1 cC4KKyAgKHNob3VsZC1ub3QgKHNlYXJjaC1mb3J3YXJkICJrZXkiIG5pbCB0KSkpCisKIChw cm92aWRlICdjdXMtZWRpdC10ZXN0cykKIDs7OyBjdXMtZWRpdC10ZXN0cy5lbCBlbmRzIGhl cmUKLS0gCjIuMzQuMQoK --------------oHgPXDvjzeb8knj0zLBTJSV0--