From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes Date: Tue, 25 Jun 2019 16:17:02 -0700 (PDT) Message-ID: <6eba02d9-7143-4b47-85e9-ee381b4b5494@default> References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="129778"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 22457@debbugs.gnu.org To: Michael Heerdegen , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 01:18:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfuhf-000Xdy-EJ for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 01:18:19 +0200 Original-Received: from localhost ([::1]:35716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfuhe-0008TI-FU for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 19:18:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40098) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfuhR-0008T4-N6 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 19:18:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfuhQ-0003rs-LY for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 19:18:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48537) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfuhP-0003oM-A2 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 19:18:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfuhN-0002zA-Mq for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 19:18:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 23:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22457 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22457-submit@debbugs.gnu.org id=B22457.156150463711396 (code B ref 22457); Tue, 25 Jun 2019 23:18:01 +0000 Original-Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 23:17:17 +0000 Original-Received: from localhost ([127.0.0.1]:33848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfugf-0002xk-6a for submit@debbugs.gnu.org; Tue, 25 Jun 2019 19:17:17 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:46974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfugc-0002xV-IL for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 19:17:15 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PNEGYI096667; Tue, 25 Jun 2019 23:17:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=xEe6bWA/H6WnJxq6T+VVaPD0YX/ellqnZr/rm1mnVoo=; b=456O/H9tauGZ86uTaz8qMrXmCioJomdPStG9AQjxmu8t5/lqxhK/G1MoZvgi2T1PgKEC JwpqBMaSakjN/cjmHMuSPzvNOpz766shwx5UhBeABiuZQDZtEHDGlU4LgYPfLbL7flx8 dKdwKH6iMYSrcPj3NtrsXZkBgesC678wiakC29wNz6ndhqduWJU/AUhUcpnJspEyKosi ELZsVJc6lbjL7aXd2acwe7PgNQtynoIYsvIX2n491SN+W3L7GuPg0p2RWVY8GPnF7N9H nefq7E08EEeAy3RW4Ct6kFzWVrKJIV8Ih/LDku9BzB9rrDqdx8keRlC+eeDBvrEpyXXW /A== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2t9c9pq49y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 23:17:08 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PNFrrY045919; Tue, 25 Jun 2019 23:17:07 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2t99f454hn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 23:17:07 +0000 Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5PNH3Ms002046; Tue, 25 Jun 2019 23:17:05 GMT In-Reply-To: <87o92lmgez.fsf@web.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250188 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250188 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161443 Archived-At: > > *** The marking commands now report how many files were marked by the > > command itself, not how many files are marked in total. > > -- >=20 > I don't think this exactly describes what the patch changed: it is not > about new vs total marks, but about marks of files that were already > marked before, right? It's about making the reported count refer to the number of marks that were changed or added. The old way counted all of the matches. The new way counts only matches that are not already marked the same way. > > Perhaps somebody will want to weigh in here; feel free to revert the > > commit if this is felt to be a confusing change. >=20 > IIUC: Maybe we could add to the summary message something like > "(N already were marked)" or so if a command finds existent marks on file= s > to be marked? That might be useful information, even independent from > this change, because it might also be a hint for a pilot error. That's what the "better" version does that I sent as an _attachment_. If some were already marked as directed it says: "42 foobars matched, 35 newly marked" or "42 foobars matched, 35 newly unmarked" or "42 foobars matched, 35 newly flagged" or "42 foobars matched, 35 newly unflagged" (If all that were matched were already marked as directed then instead of "35" it says "0".) Otherwise (no matches were already marked as directed) it says: "42 foobars newly marked" or "42 foobars newly unmarked" or "42 foobars newly flagged" or "42 foobars newly unflagged"