From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Wed, 27 Nov 2024 03:45:05 +0200 Message-ID: <6e9f5784-21ae-483b-9996-5af6dedf43d0@gutov.dev> References: <87msi1ueb0.fsf@mail.linkov.net> <4256f446-e11b-450c-b455-131cb75acab0@gutov.dev> <871pzbj8mq.fsf@mail.linkov.net> <87sernhxoa.fsf@mail.linkov.net> <875xoi4cei.fsf@mail.linkov.net> <2ef677aa-1433-4aaa-92a5-c600774dd457@gutov.dev> <87frnl9h0w.fsf@mail.linkov.net> <4df18965-61f5-41a6-a5ee-67f18b02b1b5@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38951"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: martin rudalics , 74361@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 27 02:46:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tG78S-0009yH-Kr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Nov 2024 02:46:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tG781-0000Ma-LA; Tue, 26 Nov 2024 20:46:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG77z-0000LI-OL for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 20:46:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tG77z-00024j-FX for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 20:46:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:References:From:MIME-Version:Date:To:Subject; bh=M9i6Drs0N2+WCBoaqU1Ii66JGjCBjJkiXiAgftdP6V4=; b=AomsImAjEthLgYFJO2dGM1ghOrxmsPeUlRVx01WN/ioQ6JF5Um47lCZsUCz4yIpr3Gjla84gKQk8DkMQDxMoDWcpVoN0G1yzDuzCsMP8Xem4O5nXc5iOUkJo7FoJ96wMYyLDsQ9Q7UpBJc/GQ7MUEKeXZQdPuunSxSKighOY8ojduGNEArQQw+NYsCBnf9Tthw7iuXVE85o1zSV4nupyo27kNcpo8x5jMOuYNGYJ2MtSxGr5V6lXXtTY+uXCeP828k1Ne+zeT0qbKS7FYiXvHK2hhbAqIEF3Bo/J7v4NMhYNLcRMU3gQiOFgCKCY2oWX6ScAfcfOGK13jsLKhkyT5g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tG77y-0005qs-90 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 20:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Nov 2024 01:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173267191922425 (code B ref 74361); Wed, 27 Nov 2024 01:46:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 27 Nov 2024 01:45:19 +0000 Original-Received: from localhost ([127.0.0.1]:55658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG77H-0005pd-Aa for submit@debbugs.gnu.org; Tue, 26 Nov 2024 20:45:19 -0500 Original-Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]:49303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG77E-0005ok-FP for 74361@debbugs.gnu.org; Tue, 26 Nov 2024 20:45:17 -0500 Original-Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id B44DA254013D; Tue, 26 Nov 2024 20:45:10 -0500 (EST) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Tue, 26 Nov 2024 20:45:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1732671910; x=1732758310; bh=M9i6Drs0N2+WCBoaqU1Ii66JGjCBjJkiXiAgftdP6V4=; b= EwYPjFWJVmJ3YDdEk9QWG7j+Tq1mXI1DpHM+1Ka3leBWTSmRZMIoET3XjzoJHedt bbtuWz5gPiLCzfR77/sHBmYLkzC36oOd0e2kcZMqsavrklwtuuCKGmoViENGr/qq 1knpx9uMOl493HVl193CM7li1Qg+SkQcHT9QapKKDXB/xW9jkq36gq0qkYOVNBBb +11w9o2sDJJA1z0Ew2zD7qJJJpoow9glzqVjFsrlM1MKJZKu6LC9PT2yRU+hDKAQ slBU49DujzJoaRwj/MauVTQ8QJYYyDCRL2VjKLPQ6XYar7S/bXOgTruZLiNO1OsG aZPAT6wfY5Y8vlV2dX0klg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1732671910; x= 1732758310; bh=M9i6Drs0N2+WCBoaqU1Ii66JGjCBjJkiXiAgftdP6V4=; b=g s/A6JBhEtul1SbqabWUuaBGu8qzVpTY9IM8Lh1eeAwRLlQ5NMVd7d86BIEZD04f3 oTivSbNhnG19cDx64tE4wfyg7Fms5g7gvPmTH5nRP3qZbVAPXnLWzvk4rKvGCXwl 3EP4jJBDDlBLCOY5JIZ57CXzrK9Jcykd3kSsvWEeE68BEYCyudxrqHtEkjMrcFEP dYhrS/cw3YRg8g+h1iNlnePbFdCcg+R2R3vhWVGtBybsYYxKyCyFegb6WZa8MsJ8 dhXPnloSOn0SVQSKEdZQ4Ixdb3bghF0cAkgA60RpI0wIz9IG2htvmHE/gm2ZgtzR y8m8x9Yjg3JmoEM76CBHg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgeekgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefkffggfgfuhffvvehfjggtgfesthekredttddvjeen ucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvg hvqeenucggtffrrghtthgvrhhnpedvleeijeevkeejleffgeduiedujeffhfevudduffdv veetkeegveffjefgffelueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohep fedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjhhurhhisehlihhnkhhovhdrnh gvthdprhgtphhtthhopehruhgurghlihgtshesghhmgidrrghtpdhrtghpthhtohepjeeg feeiudesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 26 Nov 2024 20:45:08 -0500 (EST) Content-Language: en-US In-Reply-To: <4df18965-61f5-41a6-a5ee-67f18b02b1b5@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296010 Archived-At: On 25/11/2024 03:58, Dmitry Gutov wrote: >> Debugger entered--Lisp error: (wrong-type-argument listp xref) >>    append(nil nil nil (category . xref) nil nil ...) >>    display-buffer(# ((category . xref))) >>    xref--show-pos-in-buf(...) >>    xref--show-location(...) >>    command-execute(xref-goto-xref) >> >> This is not reproducible in `emacs -Q`.  If you want, >> I could try to find minimal customization. >> But the main thing is that with my customization >> (window-live-p xref--original-window) is nil, >> so 'xref--show-pos-in-buf' uses the last branch of 'cond'. > > No it's okay - I guess if this makes some customizations easier (not > erroring out), that's also a win. Now pushed to patch to master in commit 0624fe6f849, thanks for the comments. I'll wait for the rest of the discussion to settle before closing the bug.