From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Sat, 22 Apr 2023 14:24:47 +0300 Message-ID: <6e91a10e-e8bb-c7db-f6ce-917790e7e391@gutov.dev> References: <87a5zj2vfo.fsf@gmail.com> <87a5z3izst.fsf@web.de> <83v8hr7qk9.fsf@gnu.org> <83pm7z7nkc.fsf@gnu.org> <4b63ef62-5e1c-3dcf-ec7b-06b69e79133b@gutov.dev> <83o7nj7mfn.fsf@gnu.org> <556e0fbb-215e-c11d-0e8b-73e97441abbb@gutov.dev> <83pm7y6fdo.fsf@gnu.org> <47140c27-ba63-ca7b-8b9e-cc38a6f9a866@gutov.dev> <838rem636a.fsf@gnu.org> <83leil4u63.fsf@gnu.org> <8a9d0e2b-6ae2-bcdc-efd0-52a44ac862bb@gutov.dev> <83h6t94hru.fsf@gnu.org> <7676c8d2-1324-31e7-38b3-de167ecf683a@gutov.dev> <8e9bd99a-3093-3b69-8429-aa1ae6b7240d@gutov.dev> <834jp82u5c.fsf@gnu.org> <83ildo189j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24928"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org, monnier@iro.umontreal.ca, larsi@gnus.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 22 13:25:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqBMg-0006Gm-EM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Apr 2023 13:25:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqBMW-0007qj-OE; Sat, 22 Apr 2023 07:25:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqBMU-0007qN-AU for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 07:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqBMU-0002U7-0A for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 07:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqBMT-0004xF-OY for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 07:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Apr 2023 11:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168216269919032 (code B ref 62720); Sat, 22 Apr 2023 11:25:01 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 22 Apr 2023 11:24:59 +0000 Original-Received: from localhost ([127.0.0.1]:41954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqBMQ-0004wt-U1 for submit@debbugs.gnu.org; Sat, 22 Apr 2023 07:24:59 -0400 Original-Received: from new2-smtp.messagingengine.com ([66.111.4.224]:37451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqBMO-0004we-Kh for 62720@debbugs.gnu.org; Sat, 22 Apr 2023 07:24:57 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 8FDD9582213; Sat, 22 Apr 2023 07:24:51 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 22 Apr 2023 07:24:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1682162691; x=1682166291; bh=dKOPEoXCo5wjuBqCzWu8jv71GpE2a+P3Y9e W4cXR2Bk=; b=HroloNQ54B3/zfV1kCfQnJ3JKcce+FAaBvEZ5dY/8Bd42YU6ZkM gaeIIu1lIkqiAfiMMxYeK/4Zp2VapI9CgdXoY72zjdaqyRs+WmzdC+12buPf/BgM WJXCN3Il0FYXICCVEYqF1EpSlhIil/ArqNuWuOpcW6EJD+4d9q6RbTDgVby3qN4M b2Kq42J/c45hQu4s881s81aCDJuD6+4A34pph23alUn2vlBr3pu/6fL1cCvimtK8 TW8qRSKqjVl9UTiEXRP0M+b0TtQH+g+bnlE7vKT7SGQY/8qlYTUvxFkna+AvzMD4 OQhB1JvyEBhc3lJ8n/2dgx5Z1AxwMoN3ZYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1682162691; x=1682166291; bh=dKOPEoXCo5wjuBqCzWu8jv71GpE2a+P3Y9e W4cXR2Bk=; b=WBDliKyN8WWsjN7gjJuIJ+IrLbYnuuO0Q9nPliG1uUugKPkWgs9 4ikalknzFNhhkXtWtECrRG4wbgJwsXWVCJy1640EAU+dtnFNhTVShKMfoNJY154F vtaL5w8NwOc9CorgNXoK7IqRlYNx9Ot3rl1yTjdxT7Th8jGB7vBpKEH8KrND4A8B 1bUlKhkB7W8O6LM6tf6qPt22rxUb2C4JcmM+kV3Xp45kobmX6LbFBlgBtnJ2UFCS iplc/bMhPIUaEAtAhU0m9Tn+WP++VtdEx+Nzrqa3+NJN9TAx8p9ranWPccCLrd0k W7IxWdiw6vRJ2nBiNH+RJRox8rWY7mM1BDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtiedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 22 Apr 2023 07:24:49 -0400 (EDT) Content-Language: en-US In-Reply-To: <83ildo189j.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260459 Archived-At: On 22/04/2023 14:11, Eli Zaretskii wrote: >> Date: Sat, 22 Apr 2023 13:30:41 +0300 >> Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org, >> joaotavora@gmail.com, larsi@gnus.org, monnier@iro.umontreal.ca >> From: Dmitry Gutov >> >>> Thanks, but this is not what was being discussed, AFAIU. What I said >>> I'd agree to is to have package-update accept a prefix argument and >>> heed package-install-upgrade-built-in (perhaps renamed), >> >> I think I explained in the previous email why reusing >> package-install-upgrade-built-in doesn't seem like a good idea. > > And I thought I've explained why I didn't see a need for another > option. I also don't see the point of using an option here. Also think forward to Emacs 30: I think the most reasonable choice would be to have package-update upgrade builtins by default, whereas package-update-all and package-menu-mark-for-upgrades probably still need to be preffed off (not sure, but we won't be able to make the choice until later, I think). But if to make package-update behave properly we need to flip the default of the said option, it will flip the behavior of package-update-all and package-menu-mark-for-upgrades as well. >>> and only then >>> update built-in packages. >> >> I asked what plausible scenario you think might be broken by having >> package-update upgrade builtin package by default. > > That's obvious: this is how package-update behaved until now. That's not an answer to the question. >>> I also don't think I like the significant changes in package-update, >>> nor understand why they are needed. >> >> Like I said: the changes are to avoid relying on package-install being >> able to install a package that's already installed. Which currently >> works only for builtins and when only a user option is set. It's a mess. >> >> And to "avoid interdependency". > > Why does this have to be in Emacs 29? It's a cleanup, right? Not a cleanup, no. If I just keep the previous version of the code, I get "package xxx is already installed". Because when upgrading a builtin package, the "current" version is not deleted. So we need to compute the exact version to install (then package-install does not say "it's already installed" because the installed version is different). The use of package-install-from-archive might have been a mistake, though, (in case dependencies need to be updated too) I'm looking into that now. Alternatively, we could add an optional argument to package-install which would mean "install the latest version anyway". >> Just to be clear, we are talking about the 4 lines at the end, right? > > Yes, and also the (somewhat mysterious) additions of tests for > pkg-desc. pkg-desc is nil for builtin packages in this case (they are not in package-alist, so (assq package package-alist) returns nil).