From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#39902: 28.0.50; Marking in dired with active region Date: Tue, 10 Mar 2020 17:29:55 -0700 (PDT) Message-ID: <6d82d04a-db94-4df4-82cc-3ea13a78a4dd@default> References: <87d09suras.fsf@web.de> <87tv33r8e2.fsf@mail.linkov.net> <87eeu6hpjf.fsf@web.de> <875zfixuoy.fsf@mail.linkov.net> <87h7z1jadw.fsf@web.de> <87y2sbloaa.fsf@mail.linkov.net> <877dzvgd4l.fsf@web.de> <8736aiqu3y.fsf@mail.linkov.net> <7a0a6f19-f958-4b38-beaf-3d60dc8a279f@default> <87d09lb1ts.fsf@mail.linkov.net> <87a74n4vet.fsf@web.de> <87eetzah2s.fsf@mail.linkov.net> <87zhcn9229.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="115484"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39902@debbugs.gnu.org To: Juri Linkov , Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 11 01:33:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jBpJ9-000Tu6-0g for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Mar 2020 01:33:11 +0100 Original-Received: from localhost ([::1]:42174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBpJ8-0000sA-30 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Mar 2020 20:33:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34032) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBpJ1-0000s3-Gk for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 20:33:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBpJ0-0006m5-I9 for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 20:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47517) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBpJ0-0006lt-FD for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 20:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jBpJ0-00011n-Co for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 20:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Mar 2020 00:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39902 X-GNU-PR-Package: emacs Original-Received: via spool by 39902-submit@debbugs.gnu.org id=B39902.15838867263891 (code B ref 39902); Wed, 11 Mar 2020 00:33:02 +0000 Original-Received: (at 39902) by debbugs.gnu.org; 11 Mar 2020 00:32:06 +0000 Original-Received: from localhost ([127.0.0.1]:53490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBpI6-00010g-KJ for submit@debbugs.gnu.org; Tue, 10 Mar 2020 20:32:06 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:45470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBpI5-00010D-6u for 39902@debbugs.gnu.org; Tue, 10 Mar 2020 20:32:05 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02B0Q08T190999; Wed, 11 Mar 2020 00:31:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=OUg9VBrqA31br2kVbzf3HCd/Em09O2tb24IReEwl5cs=; b=B4M9qTJduwILDlPpvELfZKe0OM/V8IgWvKaAfNv5916RVJbF+APtR1Tiji1kVHH5eZ8Y zRmw6TEfg1dMbb3xp+WnBFZ9tQpFsuKZowaNswefOOcXl6JQT5CtXoeKwut9MaWEeeJ7 92IkoIbiLW5zKIBGyFVm1893XD/Cmh6246ThCwQFupBnthDrTjZK/J+rBklPTiBMmoZX 726CCsA/gf7phZGiGEpriigJRWUBwG4VIIxEzXyOt1M1DMNJg3h00GJ/zzAMKIxIOnu/ 63neTXb1P5NukjGs/1SYEOyXedDL/BwzcmtpbHkQC+yHDoPCtA5XwkxizLvd5tUQkBAi yg== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2ym31ugp3t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Mar 2020 00:31:58 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02B0C93j063476; Wed, 11 Mar 2020 00:29:57 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2yp8pv2syg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Mar 2020 00:29:57 +0000 Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02B0Turo004953; Wed, 11 Mar 2020 00:29:56 GMT In-Reply-To: <87zhcn9229.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4966.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9556 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003100146 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9556 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003100146 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177163 Archived-At: > +(defcustom dired-mark-inclusive nil > + "Non-nil means `dired-mark' marks file on the region end." > + :type 'boolean > + :version "28.1" > + :group 'dired) > +=09 (progn (goto-char end) > + (if (and dired-mark-inclusive > + (or (eolp) (get-text-property (point) 'dired- > filename))) > + (line-end-position) > + (line-beginning-position))))))) I see no reason for such an option. And no reason for the broken default behavior that the original complaint was about. Is using `line-beginning-position' here really something you think is useful? My vote is to use what I suggested, or similar: (progn (goto-char end) =09 (when (bolp) (backward-char)) =09 (line-end-position))