From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#32970: 26; doc string of `this-command-keys-vector' (minor) Date: Thu, 11 Jul 2019 10:11:55 -0700 (PDT) Message-ID: <6cee3e8e-e197-495c-bb8c-275e3f426d1c@default> References: <87ef2w36rs.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187699"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 32970@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 11 19:13:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlcd4-000mio-E6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jul 2019 19:13:10 +0200 Original-Received: from localhost ([::1]:43712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlcd2-0003ZZ-OG for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jul 2019 13:13:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57292) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlccz-0003ZG-EW for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 13:13:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlccy-0004oz-CK for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 13:13:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlccy-0004nV-7Y for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 13:13:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlccv-0004ir-U3 for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 13:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2019 17:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32970 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 32970-submit@debbugs.gnu.org id=B32970.156286512718086 (code B ref 32970); Thu, 11 Jul 2019 17:13:01 +0000 Original-Received: (at 32970) by debbugs.gnu.org; 11 Jul 2019 17:12:07 +0000 Original-Received: from localhost ([127.0.0.1]:38554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlcc2-0004he-QU for submit@debbugs.gnu.org; Thu, 11 Jul 2019 13:12:07 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:40980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlcc0-0004h7-83 for 32970@debbugs.gnu.org; Thu, 11 Jul 2019 13:12:05 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6BH91A2162022; Thu, 11 Jul 2019 17:11:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=uw8BolcNzb+y/4tgTmSlDnRAQ39X6Sj7BsYo9uvfik0=; b=SI69ZecY6cONCoHS6m9sSCO3xmqQ2L59su6ZGduwbuhVzJhSZu/CFdOMHjQ4VZ7OUgP9 Xv+X12h29Kob+HatKLRFCdqMhgkGUJCrNRY98T08Pcss7g2c8eIejo7iNpuP1qm7sIcP flNAGnICZwQmM6dq6a68Gz65VUydB5U3Y2EUXYfYTQ/G2CRQI4W5n/mqOhNK/8UMTZIj 5Sf5bRyiHKUvn4xrTDTWD5uwy8CmnljNg78hvGtXmC4sidy+vcBOVkMNzJsaFom5rIRt nStiwm/5S+JzsDM0jyYcU5zk2zxQCA4NuuPK0FI8wiHXgOdEGmwFbTTG9lbv8bMSXN0J 1A== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2tjm9r1b59-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jul 2019 17:11:58 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6BH8KOB099943; Thu, 11 Jul 2019 17:11:57 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2tmwgy7q46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jul 2019 17:11:57 +0000 Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x6BHBudp006397; Thu, 11 Jul 2019 17:11:56 GMT In-Reply-To: <87ef2w36rs.fsf@mouse.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9315 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907110190 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9315 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907110190 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162722 Archived-At: > > this-command-keys-vector is a built-in function in 'C source code'. > > > > (this-command-keys-vector) > > > > Return the key sequence that invoked this command, as a vector. > > However, if the command has called 'read-key-sequence', it returns > > the last key sequence that has been read. > > > > See also 'this-command-keys'. > > This function does not change global state, including the match data. > > > > It would be clearer, I think, if the order of the last two sentences > > were reversed. And perhaps they should not even be in the same > > paragraph. The current order can lead to thinking that "this function" > > means `this-command-keys', and that it is only `this-command-keys', not > > also `this-command-keys-vector', that does not change global state. >=20 > The current help buffer is: >=20 > -- >=20 > this-command-keys-vector is a built-in function in =E2=80=98src/keyboard.= c=E2=80=99. >=20 > (this-command-keys-vector) >=20 > This function does not change global state, including the match data. >=20 > Return the key sequence that invoked this command, as a vector. > However, if the command has called =E2=80=98read-key-sequence=E2=80=99, i= t returns > the last key sequence that has been read. >=20 > See also =E2=80=98this-command-keys=E2=80=99. > -- >=20 > So this has been fixed. For some definition of "fixed". ;-) Yes, the original problem is gone. Unfortunately, a worse problem was introduced: putting that statement about the match data before doc string itself. Such info belongs at the end, but separated from the doc string, e.g., by a horizontal line. Anyway, yes, this can be closed. (On n'arrete pas le progres.)