unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Ivan Kanis <gnu@kanis.fr>
Cc: 8337@debbugs.gnu.org
Subject: bug#8337: patches that fixes the problem in appt
Date: Tue, 07 Jun 2011 03:28:45 -0400	[thread overview]
Message-ID: <6c62oigkwi.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <877hay7ev3.fsf@kanis.fr> (Ivan Kanis's message of "Wed, 13 Apr 2011 10:08:32 +0200")


Sorry about the delay. I do think this is something that needs to be
fixed, though I don't think it (ie, overlapping appointments) is very
important and I expect to be busy over the next several weeks. Thanks
for sending the patch and rest assured I won't forget about it.

The patch seems far too large to me though, and is hard to follow since
presented as a set of 14 consecutive patches, many of which seem
unrelated to the actual issue. They include a lot of stuff that isn't
directly relevant and that I don't want (deletion/addition of options,
renaming of local variables, what seems like unnecessary refactoring,
etc.). It looks like I've done some of this independently in the
meantime (patches 1, 2, at first glance). Of the rest: 3 and 6 are
entirely cosmetic; 5 is unrelated and incorrect; 10 I don't want, and it
and others like it just make subsequent patches harder to follow.

At first sight, I'd just like the minimum change: appt-check to not stop
at the first relevant entry from appt-time-msg-list, but instead
accumulate all the relevant ones. In case of multiple appointments, the
modeline should just say "Appts in 3,5,...mins", and the appointment
display should just concatenate multiple appts on new lines. No need for
new display options. I don't see that this should require such large
changes. Maybe this is buried down in patch 12 somewhere, but it looks
like it will take some extracting, hence the delay.






  reply	other threads:[~2011-06-07  7:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 15:55 bug#8337: 23.3; Appointment shadow another one with different warning time Ivan Kanis
2011-04-13  8:08 ` bug#8337: patches that fixes the problem in appt Ivan Kanis
2011-06-07  7:28   ` Glenn Morris [this message]
2011-06-11 18:02     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c62oigkwi.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=8337@debbugs.gnu.org \
    --cc=gnu@kanis.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).