From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61577: 30.0.50; project-try-vc missing vc-got Date: Sat, 18 Feb 2023 01:11:10 +0200 Message-ID: <6c541782-294f-49cb-7138-93b45016a79e@yandex.ru> References: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33494"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: Omar Polo , 61577-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 18 00:12:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pT9tu-0008aH-Hp for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Feb 2023 00:12:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pT9tc-0006MK-8i; Fri, 17 Feb 2023 18:12:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT9ta-0006Lx-L3 for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 18:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pT9ta-0004gy-C3 for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 18:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pT9ta-0005Ys-6v for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 18:12:02 -0500 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Feb 2023 23:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 61577 X-GNU-PR-Package: emacs Mail-Followup-To: 61577@debbugs.gnu.org, dgutov@yandex.ru, op@omarpolo.com Original-Received: via spool by 61577-done@debbugs.gnu.org id=D61577.167667548021297 (code D ref 61577); Fri, 17 Feb 2023 23:12:02 +0000 Original-Received: (at 61577-done) by debbugs.gnu.org; 17 Feb 2023 23:11:20 +0000 Original-Received: from localhost ([127.0.0.1]:41837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT9su-0005XR-10 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 18:11:20 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:38515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT9st-0005XB-3z for 61577-done@debbugs.gnu.org; Fri, 17 Feb 2023 18:11:19 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id o10-20020a05600c510a00b003e21e018039so1010426wms.3 for <61577-done@debbugs.gnu.org>; Fri, 17 Feb 2023 15:11:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=wzq10H/HOpxCBDwmg7N+Lbch0LaZD69f4YC1+PL82KU=; b=pYTirqP5ut6slXv1NXY6NFbBkkhPe1ro8BHMS22cqvA9YjjmrH8GpZkwc5J3lTAefI 66hasi6nb0c0qUjBYU6dlgd48BFTWL3+qWlv6GuAndTEXggbMD+scvJK4Nw6HUxx/IZS 89Wv2w7fV9aDODHf+iMIvQ9uVy9GCRWxO3rYhANgD/HI2giP0H3y5JH/Z5PZmnIZo969 U8L0qcmGWCGsqeC679pqB/XLLbuU09+aeUtmpr/c3s0N1yBMVRaLY32ML2g6cXL+pAI0 4lXBT6ttpkBlL9y52zH5ku3WSDP2+Mtk1HmwtB0TH0RMfr1ziJtgT6BTcv3ImgxNW2Zy rFZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wzq10H/HOpxCBDwmg7N+Lbch0LaZD69f4YC1+PL82KU=; b=vr+RPVgDtsaWd0KQbmLQRQbalfMpVAa+Bs/i34X11NibyqGqlBmCX40KN15GI2GBlO OiKGT12Kvpt8jDQNBK+MAQ5MXSNqq5U9SWopxVeDgowlq2taoRQal/MuJdYm7NxzSh/A H8AE4fF591ISLtqm3MIbDW8lrmRPYeqMctPee2VWb48sjPnMqz3qESA5hxOt7exSRCrK 6/4D2rP/SeaHhjfD1Nc8+qV+6FScs49YhtfV+1+myQi8Nu3+HJiB/vBXkAUHlBuwhJFG ABq18ZfVFJDnCU2IQAuWqVrYRwRHNgtCyAO5RrQOaalaS6mYlhCu85EAZFpvPWXBga22 cq3g== X-Gm-Message-State: AO0yUKX60mM1Ujjb6Ebnh5Ot7f3DT70pGp6K6+fKAq4xOvBFA9QXwxir e2eo056icfMOQ+6/PWG9Qu0= X-Google-Smtp-Source: AK7set+5cjQqh/xEt0FwWZicLwNVEcf2D43g6kFyO56cmFeje0LPlUDHjXwJGUXihl91biX49NpjkA== X-Received: by 2002:a05:600c:502c:b0:3d1:caf1:3f56 with SMTP id n44-20020a05600c502c00b003d1caf13f56mr6195334wmr.9.1676675472921; Fri, 17 Feb 2023 15:11:12 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l33-20020a05600c1d2100b003db012d49b7sm3165475wms.2.2023.02.17.15.11.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Feb 2023 15:11:12 -0800 (PST) Content-Language: en-US In-Reply-To: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255910 Archived-At: Version: 29.1 Hi! On 17/02/2023 18:56, Omar Polo wrote: > project-try-vc (IIRC) used to loop over all the vc-backends to find the > root of a project. Now, it’s just an hardcoded list in a local > variable. This breaks the project-* functions on Got checkouts. > > I can imagine the reason of the change (avoid loading all the vc-*.el > files I guess) but it would be nice for this variable to be at least > user-configurable, otherwise we will always end up with missing entries. The reasons were actually related to performance during the search. > (Yeah, one could add their own hooks in project-find-functions for > that, but seems replicating stuff that project.el tries to do anyway.) > > Attaching a diff that temporarly works around the problem by adding the > Got -> .got mapping. Thanks for the report, I've pushed your addition and also moved the list to a defvar. Not defcustom, though, to avoid encouraging people from changing it unnecessarily (instead of project-vc-extra-root-markers). Originally, I figured all major backends should be covered, but it won't hurt to add one more, especially since vc-got is in ELPA.