From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Sun, 29 Aug 2021 22:50:11 +0300 Message-ID: <6c1eff82-28f1-606c-4d9f-addd904880c8@yandex.ru> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <85lfp7ygk3.fsf@gmail.com> <87pmxwgcps.fsf@gnus.org> <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> <87k0lildtq.fsf@gnus.org> <6e6060f9-0259-9b12-f925-a1a85c6757c4@yandex.ru> <877dgoutmz.fsf@gnus.org> <2602aeaf-0f02-e744-2b4f-012e73e012e8@yandex.ru> <87y28nbky4.fsf@linkov.net> <9fa4e453-9f8b-9c2b-b3d3-76bb656d6ad5@yandex.ru> <87h7f8dzm5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4728"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Cc: Lars Ingebrigtsen , Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 29 21:51:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKQpq-00012u-IZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Aug 2021 21:51:18 +0200 Original-Received: from localhost ([::1]:51774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKQpl-0003hu-0L for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Aug 2021 15:51:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKQpa-0003eT-Oz for bug-gnu-emacs@gnu.org; Sun, 29 Aug 2021 15:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKQpa-0005cC-HY for bug-gnu-emacs@gnu.org; Sun, 29 Aug 2021 15:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKQpa-0005km-G8 for bug-gnu-emacs@gnu.org; Sun, 29 Aug 2021 15:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Aug 2021 19:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.163026662222042 (code B ref 39452); Sun, 29 Aug 2021 19:51:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 29 Aug 2021 19:50:22 +0000 Original-Received: from localhost ([127.0.0.1]:57448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKQov-0005jS-ON for submit@debbugs.gnu.org; Sun, 29 Aug 2021 15:50:22 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:33428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKQou-0005jD-0e for 39452@debbugs.gnu.org; Sun, 29 Aug 2021 15:50:20 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id d26so19407604wrc.0 for <39452@debbugs.gnu.org>; Sun, 29 Aug 2021 12:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kHF4ObSNAKgW3qWwMITVgJLx/Nl1MaWS4BhEIceUd7M=; b=n6Z6Jj92nl60AfNHXMW5bBxKk0b2sLiGXYO/zpVaauW3n8ej9/cLY0yUCaory60MUQ 3UqIqXjPM2RjC7TALzs7oD51tuhYbTxwXfnpCssPanrH/egBSPgZVrfjjPU45YDQQlSE MoYdBkf0+xw+xJteE3TWnHYrq/BiZBucJw3WqzdlTs/zgkE25h6WzSSoCJGDIPNu6sSf AXGmdcyfrx+YjM4UcKYoDLP9RNRT0tZpRIyxrx9+wmNvQ4aUcNDq3wKt2HMiEsBzWjoy VHhboNlrtalCx+RpU2RDyUfUjEuXkP4afWer5gdEm/X0LK8kfklvqs19EwcYiC27koWm B4vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kHF4ObSNAKgW3qWwMITVgJLx/Nl1MaWS4BhEIceUd7M=; b=pQOBzNikR/CYCxOIcSYHAaGen1WpuniFrUUx1HfY45wEkIHpCJZLf60feYcId4+O/W FdDNm0PcXLBxqHbqSSuDIqf6l1CkeY1WMBab+gVRRwpgKUk8WIHqoBsqAuw+BjsKICeA vCvfTkDrDveckj2uRdi4DhR4EFoDvUVM2TI8PIQatTevb4bjh+k2+fPDQu7NyZgSVBdV wqcb3RGw9ElJfxLIOgcfyl0tVd0wRWF3MGsswD4x0/BSzfpEeJkELLcCgoCVqacpEkHW 6juwuoUG9LavVpZv7jnZZ5CO0fmryB3GQUwrx3CWD84/SAEZOz3HH54y5eTt1wWqBNDP xfOw== X-Gm-Message-State: AOAM533eiXhAm8zQwYWMl0BfqFCXCljfnhaFC+jdTsjfc1XDrgcha50Z oExfbuaKkqRt5cf6kb9kkQk= X-Google-Smtp-Source: ABdhPJxyqbwO/zkzUJDNCtcHmxv098rJKyK8eYVX0EOwmAJUwVQ5+ar+D3048XP5ENCxm8h+TZ0UIw== X-Received: by 2002:a5d:404e:: with SMTP id w14mr22267346wrp.391.1630266613959; Sun, 29 Aug 2021 12:50:13 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id q14sm6790969wrc.31.2021.08.29.12.50.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Aug 2021 12:50:13 -0700 (PDT) In-Reply-To: <87h7f8dzm5.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212958 Archived-At: On 29.08.2021 19:44, Juri Linkov wrote: >>> Would be great to add some test, though. vc-tests.el currently doesn't >>> exercise vc-rename-file at all. >> >> Just added the tests for vc-rename-file. > > Thanks, I tried to run the test, but it fails: > > Test vc-test-rcs05-rename-file condition: > (ert-test-failed > ((should > (equal > (vc-state new-name) > 'added)) > :form > (equal up-to-date added) > :value nil :explanation > (different-atoms up-to-date added))) > FAILED 12/12 vc-test-rcs05-rename-file Could you go ahead and fix the expectation? The check is near the end of vc-test--rename-file, and the expected value can be made to depend on the current backend. I could only run the tests with Git, Hg and Bzr, and I couldn't find any CI builds for Emacs that are still working. > Another question: after removing vc-git--literal-pathspecs from > vc-git-rename-file, does this mean that vc-git-rename-file > now doesn't support literal paths? Maybe it could be possible > to fix vc-git--literal-pathspecs to support relative literal paths > for vc-git-rename-file? The original problem just meant that 'git mv' never supported pathspecs (which makes sense), that's why it broke after the change. Now we pass file names to it (which it interprets literally), and all is well.