From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase Date: Fri, 10 Jun 2022 08:44:22 -0700 Message-ID: <6c0578d4-4060-3c81-584e-53eb9912d40e@gmail.com> References: <37af046b-4257-6370-c765-9290eae73fd4@gmail.com> <831qw6dzra.fsf@gnu.org> <0278e759-237b-a32b-4b1f-fbdacf39c8ef@gmail.com> <83pmjpar0x.fsf@gnu.org> <9e8a8b42-2f42-3027-2ec0-97744bb91911@gmail.com> <83sfoja2xp.fsf@gnu.org> <34062848-8fe4-351c-df63-5cc341fefa57@gmail.com> <83sfoj7x6f.fsf@gnu.org> <83ee027yjc.fsf@gnu.org> <2b86123e-76c1-ec0c-c767-7d821473e5e1@gmx.at> <86a0c66e-86f9-6bd6-2010-eb1cf2d9f1e6@gmail.com> <83a6am47v6.fsf@gnu.org> <4abda9a0-7c34-cdad-fc9e-a6dc25e7c74b@gmail.com> <837d5p3hr7.fsf@gnu.org> <8e4fc184-8ca1-8094-f37d-f77d0cbb337c@gmail.com> <83edzx12vm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38746"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 10 17:45:56 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzgpf-0009xw-G8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jun 2022 17:45:55 +0200 Original-Received: from localhost ([::1]:34624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzgpd-0003ii-Sq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jun 2022 11:45:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzgoo-00038w-4G for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 11:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzgon-0003bG-Rq for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 11:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzgon-0002RU-QR for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 11:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jun 2022 15:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55696 X-GNU-PR-Package: emacs Original-Received: via spool by 55696-submit@debbugs.gnu.org id=B55696.16548758689334 (code B ref 55696); Fri, 10 Jun 2022 15:45:01 +0000 Original-Received: (at 55696) by debbugs.gnu.org; 10 Jun 2022 15:44:28 +0000 Original-Received: from localhost ([127.0.0.1]:51052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzgoG-0002QU-Mj for submit@debbugs.gnu.org; Fri, 10 Jun 2022 11:44:28 -0400 Original-Received: from mail-pj1-f53.google.com ([209.85.216.53]:33281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzgoG-0002QI-3F for 55696@debbugs.gnu.org; Fri, 10 Jun 2022 11:44:28 -0400 Original-Received: by mail-pj1-f53.google.com with SMTP id hv24-20020a17090ae41800b001e33eebdb5dso3876208pjb.0 for <55696@debbugs.gnu.org>; Fri, 10 Jun 2022 08:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=YJRKDESE2M04dDyrjXef975ghO9N7tbsNPHsghnplZc=; b=hJ/+wauoNtt9Bhg3Ntesd9Zriz/tPRpOvuXQ4nuTHeytOi/PxRfNdlivXstCHwsO52 PBYtrljYiMoVMH8BH60JGco1C2bm5YN1P+EiY6S//3FnMNJpTW1HcBdA2LqK4DM20V4W f+nFgMqH+iLHs1XaV8u4xajh4Pz4j9bTnWoFTUiMtr5WGkdSPqbHY6MBMhK0r2vinoaF JK4tyDXjPVEshDdxIX5F3+9mjRNii4g9UIFTJBmTUDggUOGIZE3E/hTjhpagplZdXCCB oS8Vpq8KeyKKtCLOBADU4FE8UV4Dmy8waBTA8dqi0InWmPkDQozKuLkMcqfVOIwTuIXP 6yRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YJRKDESE2M04dDyrjXef975ghO9N7tbsNPHsghnplZc=; b=mRtUuScR5x9b013oc1JXgpEOTrMfP56BUwKzEW454ZQnU7+0V2ilUKP9U9q8ofPcUK WS9j4xXG7jtG4uR33r5FCIj04WN8LPQH+7eTCvp6bxOy1ONNFO7j/3mBoBcFyAvFX1Tw iIICBsFeMzb3rElZz/GiNrCZP3qOV2sNN79nRivvhWaFO7/yyha5Q49migAq2nZgZFNL oJmFxMEwv+X9W/DAy7N9CWOY7Rq6KhoL1EeL6l7wYPPHfqz6aMWPhZ/xS0dfiLgYzvDr 0U9os88v7mzm7gWhUYZJJHhG79g6srBXt73RbPreak/EbWhE4xE6S8NNcr05e7BZcsis e3Aw== X-Gm-Message-State: AOAM533T1rg+cosdUu393SMblFtK3xgrCKPzYwYe48NV9DD7K0FE6M/w oJEniK8qEak4nXbb7ijD8sQ= X-Google-Smtp-Source: ABdhPJxctPS7ZE8EmwGr+XJjkZh7A4J+1KKU1btEHstb0AIKda5lnjJlrIHfbu59Pz+x5PqKywovsw== X-Received: by 2002:a17:902:e80a:b0:166:3a24:4572 with SMTP id u10-20020a170902e80a00b001663a244572mr45471897plg.30.1654875862135; Fri, 10 Jun 2022 08:44:22 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x13-20020a17090300cd00b001637529493esm18811853plc.66.2022.06.10.08.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 08:44:21 -0700 (PDT) In-Reply-To: <83edzx12vm.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234230 Archived-At: On 6/9/2022 10:52 PM, Eli Zaretskii wrote: > What if there's an external command named 'listify' -- is there any > chance that the test will invoke it? If so, I think we should come up > with a safer solution. No, that shouldn't be a problem. When Eshell executes something that looks like a shell command[1], the order of precedence is this: 1. If an alias for the command exists in .emacs.d/eshell/aliases, use that. (This won't happen in tests, since `eshell-test-command-result' binds `eshell-directory-name' to a temp dir.) 2. If there's a Lisp function named `eshell/COMMAND', use that. 3. If there's an external command named `COMMAND', use that. 4. If there's a Lisp function named `COMMAND', use that. > Otherwise, feel free to install the change, and thanks. Thanks. (I don't have direct commit access, so hopefully you or someone else with commit access can install it when you/they get the chance.) [1] Something like 'COMMAND args' or 'echo ${COMMAND args}'.